Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-15 08:23:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix chat history not being deduped (#199915)

Browse Source 
Fix #199719
This commit is contained in:
Rob Lourens
2023-12-03 18:45:18 -06:00
committed by GitHub
parent 34d475b9c9
commit ef7a4529be
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/contrib/chat/browser/chatInputPart.ts
+15 -8
View File
@@ -82,7 +82,8 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
return this._inputEditor;
}
private history: HistoryNavigator<{ text: string; state?: any }>;
private history: HistoryNavigator<string>;
private historyStates: Map<string, any> = new Map();
private historyNavigationBackwardsEnablement!: IContextKey<boolean>;
private historyNavigationForewardsEnablement!: IContextKey<boolean>;
private inputModel: ITextModel | undefined;
@@ -132,7 +133,11 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
setState(providerId: string, inputValue: string | undefined): void {
this.providerId = providerId;
const history = this.historyService.getHistory(providerId);
this.history = new HistoryNavigator(history, 50);
this.historyStates = new Map(history.map(h => [h.text, h.state]));
const historyTexts: string[] = [];
this.historyStates.forEach((_, str) => historyTexts.push(str));
this.history = new HistoryNavigator(historyTexts, 50);
if (typeof inputValue === 'string') {
this.setValue(inputValue);
@@ -154,11 +159,11 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
private navigateHistory(previous: boolean): void {
const historyInput = (previous ?
(this.history.previous() ?? this.history.first()) : this.history.next())
?? { text: '' };
?? '';
aria.status(historyInput.text);
this.setValue(historyInput.text);
this._onDidLoadInputState.fire(historyInput.state);
aria.status(historyInput);
this.setValue(historyInput);
this._onDidLoadInputState.fire(this.historyStates.get(historyInput));
if (previous) {
this._inputEditor.setPosition({ lineNumber: 1, column: 1 });
} else {
@@ -191,7 +196,8 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
*/
async acceptInput(userQuery?: string, inputState?: any): Promise<void> {
if (userQuery) {
this.history.add({ text: userQuery, state: inputState });
this.history.add(userQuery);
this.historyStates.set(userQuery, inputState);
}
if (this.accessibilityService.isScreenReaderOptimized() && isMacintosh) {
@@ -369,7 +375,8 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
saveState(): void {
const inputHistory = this.history.getHistory();
this.historyService.saveHistory(this.providerId!, inputHistory);
const historyEntries = inputHistory.map(entry => ({ text: entry, state: this.historyStates.get(entry) }));
this.historyService.saveHistory(this.providerId!, historyEntries);
}
}