Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-03-02 23:09:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: AI search runs even when toggle is hidden (#255496)

Browse Source
This commit is contained in:
Raymond Zhao
2025-07-14 10:25:32 -07:00
committed by GitHub
parent 190ec3670c
commit f497e76c8e
1 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts
View File

@@ -774,7 +774,7 @@ export class SettingsEditor2 extends EditorPane {
}
toggleAiSearch(): void {
if (this.showAiResultsAction) {
if (this.searchInputActionBar && this.showAiResultsAction && this.searchInputActionBar.hasAction(this.showAiResultsAction)) {
if (!this.showAiResultsAction.enabled) {
aria.status(localize('noAiResults', "No AI results available at this time."));
}
@@ -1824,23 +1824,27 @@ export class SettingsEditor2 extends EditorPane {
return;
}
// Kick off an AI search in the background. We purposely do not await it.
if (this.aiSearchPromise) {
this.aiSearchPromise.cancel();
}
this.aiSearchPromise = createCancelablePromise(token => {
return this.doAiSearch(query, token).then((results) => {
if (results && this.showAiResultsAction) {
this.showAiResultsAction.enabled = true;
this.showAiResultsAction.label = SHOW_AI_RESULTS_ENABLED_LABEL;
this.renderResultCountMessages(true);
}
}).catch(e => {
if (!isCancellationError(e)) {
this.logService.trace('Error during AI settings search:', e);
}
// Kick off an AI search in the background if the toggle is shown.
// We purposely do not await it.
if (this.searchInputActionBar && this.showAiResultsAction && this.searchInputActionBar.hasAction(this.showAiResultsAction)) {
this.aiSearchPromise = createCancelablePromise(token => {
return this.doAiSearch(query, token).then((results) => {
if (results && this.showAiResultsAction) {
this.showAiResultsAction.enabled = true;
this.showAiResultsAction.label = SHOW_AI_RESULTS_ENABLED_LABEL;
this.renderResultCountMessages(true);
}
}).catch(e => {
if (!isCancellationError(e)) {
this.logService.trace('Error during AI settings search:', e);
}
});
});
});
}
this.onDidFinishSearch(expandResults, progressRunner);
});