Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-01 21:54:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Create char offset in FastRenderedViewLine only when needed

Browse Source
This commit is contained in:
Alex Dima
2017-02-02 18:35:29 +01:00
parent 15627c7403
commit f86d894939
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/editor/browser/viewParts/lines/viewLine.ts
+14 -5
View File
@@ -247,7 +247,7 @@ class FastRenderedViewLine implements IRenderedViewLine {
private readonly _characterMapping: CharacterMapping;
private readonly _charWidth: number;
private readonly _charOffset: Uint32Array;
private _charOffset: Uint32Array;
constructor(domNode: FastDomNode, renderLineInput: RenderLineInput, characterMapping: CharacterMapping) {
this.domNode = domNode;
@@ -255,7 +255,7 @@ class FastRenderedViewLine implements IRenderedViewLine {
this._characterMapping = characterMapping;
this._charWidth = renderLineInput.spaceWidth;
this._charOffset = FastRenderedViewLine._createCharOffset(characterMapping);
this._charOffset = null;
}
private static _createCharOffset(characterMapping: CharacterMapping): Uint32Array {
@@ -281,8 +281,16 @@ class FastRenderedViewLine implements IRenderedViewLine {
return result;
}
private _getOrCreateCharOffset(): Uint32Array {
if (this._charOffset === null) {
this._charOffset = FastRenderedViewLine._createCharOffset(this._characterMapping);
}
return this._charOffset;
}
public getWidth(): number {
return this._getCharPosition(this._charOffset.length);
const charOffset = this._getOrCreateCharOffset();
return this._getCharPosition(charOffset.length);
}
public getVisibleRangesForRange(startColumn: number, endColumn: number, context: DomReadingContext): HorizontalRange[] {
@@ -309,11 +317,12 @@ class FastRenderedViewLine implements IRenderedViewLine {
}
private _getCharPosition(column: number): number {
if (this._charOffset.length === 0) {
const charOffset = this._getOrCreateCharOffset();
if (charOffset.length === 0) {
// No characters on this line
return 0;
}
return Math.round(this._charWidth * this._charOffset[column - 1]);
return Math.round(this._charWidth * charOffset[column - 1]);
}
public getColumnOfNodeOffset(lineNumber: number, spanNode: HTMLElement, offset: number): number {