Commit Graph

149771 Commits

Author SHA1 Message Date
Connor Peet
12f2ac1e27 agentHost: use memory db for sqlite tests to avoid locking weirdness (#306524) 2026-03-30 16:38:42 -07:00
Raymond Zhao
c1f3775929 chore: run npm audit fix (#306509) 2026-03-30 16:32:21 -07:00
Justin Chen
07407b39e5 fix markdown not getting escaped properly (#306527) 2026-03-30 23:31:59 +00:00
dependabot[bot]
33250873ec build(deps): bump picomatch from 2.3.1 to 2.3.2 in /build (#306399)
Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](https://github.com/micromatch/picomatch/compare/2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 2.3.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-03-30 23:25:51 +00:00
Hawk Ticehurst
2beac02f6c sessions: polish run task quick input modal (#304652)
* Enhance quick input modal styling and functionality; add close button and improve padding

* Refactor quick input and run script action styles; adjust padding, height, and add new button styles

* Update quick input and run script action styles; adjust border radius, padding, and gap for improved UI consistency

* Refactor task action labels; remove ellipses for improved clarity

* Refactor quick input and run script action styles; adjust padding and add new titlebar styles for improved UI consistency

* Remove background color styles for quick input widget in run script action for improved UI consistency

* Refactor quick input header and run script action padding for improved layout consistency

* Add background color to quick input header and run script action widget for improved UI consistency

* Refactor run script action styles; adjust padding, gap, and background colors for improved UI consistency

* Update background color for quick input header and run script action widget; refine localization strings for clarity

* Update background color for quick input header and run script action widget for improved visual consistency

* Refactor padding in quick input titlebar for improved layout consistency

* Update background color for quick input header and run script action widget for improved visual consistency

* style: update task labels to include ellipsis for consistency

* style: remove unused styles for quick-input-html-widget

* style: add overflow hidden to quick-input-html-widget for better layout

* style: add disabled state styles for run-script-action radio buttons

* style: update disabled state styles for run-script-action radio buttons and improve hint display

* style: add cursor default and focus outline removal for disabled radio buttons

* style: adjust margins for action bars in quick input widget and enhance custom command input functionality

* style: remove left margin for quick input left action bar in run-script-action widget

* style: adjust padding and margins for quick input titlebar and action items in run-script-action widget

* style: adjust padding for quick input titlebar and remove unnecessary margin styles in run-script-action widget

* sessions: remove ellipsis from Configure Task modal title

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* sessions: keep run-task menu open for item actions

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: add refresh functionality for dropdown menu in RunScriptActionViewItem

* Revert "feat: add refresh functionality for dropdown menu in RunScriptActionViewItem"

This reverts commit a7b7a0d935.

* Revert "sessions: keep run-task menu open for item actions"

This reverts commit 0b2e44b745.

* quickinput: revert no-op header padding shorthand

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: add backdrop for run script action modal

* feat: streamline backdrop creation for run script action modal

* fix: increase padding in run script action widget for better spacing

* style: update run script action styles and class names for consistency

* fix: update tabIndex handling for storage options in RunScriptCustomTaskWidget

* fix: simplify storage options handling by enabling/disabling based on target lock state

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 18:40:43 -04:00
Connor Peet
eca37987be agentHost: propagate steering for cli sessions (#306488)
* agentHost: propagate steering for cli sessions

Closes #305323

* comments
2026-03-30 22:38:09 +00:00
Logan Ramos
7836a50b57 Fix over requesting of MCP registry (#306467)
undefined !== '0' is true
2026-03-30 22:31:18 +00:00
Megan Rogge
61e3ba6f04 skip flakey sandbox test for now (#306417)
part of #305722
2026-03-30 21:57:09 +00:00
Rob Lourens
8880ef4f9f chat: clean up per-response maps in disposeElement to reduce memory (#306482)
Clear codeBlocksByResponseId, codeBlocksByEditorUri, fileTreesByResponseId,
and focusedFileTreesByResponseId when elements leave the viewport. These
maps are only read for the focused response which is always visible, so
retaining entries for off-screen elements is unnecessary memory usage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 21:47:09 +00:00
Rob Lourens
cc967ecb55 Optimize CodeBlockPart pool (#306130)
* Simplify codeblock rendering in chat markdown

* Simplify URIs more

Co-authored-by: Copilot <copilot@github.com>

* Simplify

Co-authored-by: Copilot <copilot@github.com>

* Fix error

* Also hold a model reference

Co-authored-by: Copilot <copilot@github.com>

* Optimize CodeBlockPart pool

* Helper

Co-authored-by: Copilot <copilot@github.com>

* Cleanup

Co-authored-by: Copilot <copilot@github.com>

* Fix

---------

Co-authored-by: Copilot <copilot@github.com>
2026-03-30 14:44:04 -07:00
Osvaldo Ortega
4e9e3ab64b Merge pull request #306476 from microsoft/copilot/hurt-peacock
sessions: do not steal focus from quick picks during welcome overlay startup
2026-03-30 14:36:18 -07:00
Megan Rogge
f61619a1b1 Detach background terminal processes so they survive VS Code shutdown (#306406) 2026-03-30 21:29:14 +00:00
Peng Lyu
a4855ab045 agentHost: support --host and print resolved server urls (#306219) 2026-03-30 14:23:52 -07:00
Sandeep Somavarapu
0930f054ee sessions: change session description to IMarkdownString and render markdown (#306468)
* sessions: change description type to IMarkdownString and render it

- Change ISessionData, IChat, and ISession description field types from
  string | undefined to IMarkdownString | undefined
- Update all provider implementations (CopilotCLISession, RemoteNewSession,
  AgentSessionAdapter, RemoteSessionAdapter) to use IMarkdownString
- In AgentSessionAdapter._extractDescription, wrap plain strings in
  MarkdownString; IMarkdownString values are passed through as-is
- In sessionsList.ts, render markdown descriptions using markdownRendererService
  with sanitizerConfig: { replaceWithPlaintext: true } — matching the existing
  agentSessionsViewer.ts pattern; fallback status labels use plain textContent
- Add MutableDisposable to track the markdown render lifecycle so it is
  properly cleared when status changes
- Update CSS to handle paragraph elements inside rendered markdown
- Update SESSIONS_PROVIDER.md documentation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Update src/vs/sessions/contrib/remoteAgentHost/browser/remoteAgentHostSessionsProvider.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* sessions: clear descriptionDisposable on plain-text fallback to avoid leaks

When the status is active (InProgress/NeedsInput/Error) but description
becomes undefined, the previous markdown renderer was left alive even though
its container element had been removed from the DOM by the autorun rebuild.

Fix: call descriptionDisposable.clear() in every else-branch (plain-text
fallback) so any prior IMarkdownRendererService render is disposed before
the new plain-text content is set.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* sessions: fix import of IsNewChatSessionContext after move to common/contextkeys.ts

Upstream commit moved IsNewChatSessionContext from sessionsManagementService.ts
to the centralised common/contextkeys.ts. Update the import in
sessionsTitleBarWidget.ts accordingly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-30 21:16:28 +00:00
Osvaldo Ortega
9b5db8746b Do not steal focus from quick picks during startup
Guard focus calls in NewChatViewPane and SessionsWelcomeOverlay
by checking IQuickInputService.currentQuickInput before focusing.
This prevents the sessions welcome page from closing an already
open quick pick (e.g. Open Recent) and stealing focus to the
chat input box.

Fixes microsoft/vscode#294505

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 14:15:30 -07:00
Osvaldo Ortega
4ebc211cda Merge pull request #306454 from microsoft/copilot/marvellous-marmot
sessions: fix welcome page chat input collapsing on first keystroke
2026-03-30 14:04:59 -07:00
Rob Lourens
abea71e2b7 sessions: centralize context key definitions into common/contextkeys.ts (#306439)
Move RawContextKey definitions for active session state (provider ID, type,
background provider, git repository, chat session provider ID) from
sessionsManagementService.ts and copilotChatSessionsActions.ts into the
shared sessions/common/contextkeys.ts module. Replace hardcoded context
key strings with .key property access in all consumers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 22:47:10 +02:00
Osvaldo Ortega
77822e7b70 sessions: clarify welcome chat height override math
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 13:45:12 -07:00
Lee Murray
dfd3b4dcb3 Merge pull request #306381 from microsoft/mrleemurray/agent-feedback-polish
Enhance agent feedback widget styles and animations
2026-03-30 21:37:59 +01:00
Sandeep Somavarapu
39a50d8d3f sessions: fix Show All Sessions filter out of sync with view on reload (#306435)
* sessions: fix Show All Sessions filter out of sync with view on reload

The IsWorkspaceGroupCappedContext context key was never initialized from
persisted storage on reload, causing the menu checkmark to always show
as checked (default true) regardless of the stored value.

Fix by binding the context key in the constructor and syncing it with
the persisted SessionsList state in renderBody. Also fix the Reset
action which was resetting the internal state but not the context key.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* use sessionsControl as source of truth for reset context key

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 20:30:46 +00:00
Hawk Ticehurst
2924b6cf31 sessions: adjust titlebar container padding based on sidebar visibility (#306444) 2026-03-30 16:27:02 -04:00
Osvaldo Ortega
af3718b721 sessions: fix welcome page chat input collapsing on first keystroke
The chat input on the Agent Sessions welcome page would collapse from
~44px to ~22px after the first character typed, hiding the text.

Root cause: ChatWidget.layout() reserves MIN_LIST_HEIGHT (50px) for the
chat list even when the welcome page hides it via CSS. With a layout
height of 150px, the remaining budget for the input part was only 100px.
Once the input part's non-editor chrome (~128px for toolbars, padding,
attachments) was subtracted, _effectiveInputEditorMaxHeight dropped to 0,
collapsing the editor.

Fix: call setInputPartMaxHeightOverride(272) before layout so the input
part has enough budget independent of the artificially small layout
height. This mirrors what other compact chat surfaces (e.g. stacked chat
view) already do.

Fixes #304544

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 12:51:06 -07:00
Ladislau Szomoru
f8c32042ed Sessions - more actions polish in the Changes view (#306442) 2026-03-30 19:32:10 +00:00
Benjamin Pasero
b15c078a6d sessions - changes view CSS selector scoping (#306436) 2026-03-30 12:21:40 -07:00
Copilot
96b97550f6 Fix empty workspace name in archive sessions confirmation dialog (#306393)
* Initial plan

* fix: treat empty workspace label as "Unknown" in groupByWorkspace

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/4a4e1db0-915c-4a70-98de-10e2ef3ca42a

Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
2026-03-30 19:04:50 +00:00
Sandeep Somavarapu
b7308211d2 sessions: fix title bar context menu and session type icons (#306419)
sessions: fix title bar context menu and session icons

- Fix Unpin action missing from title bar context menu by looking up
  actual pinned state via SessionsView instead of hardcoding false
- Remove context menu for new/unsent sessions where actions like
  delete, pin, and archive don't apply
- Use session type icons (Codicon.copilot, Codicon.cloud) for
  AgentSessionAdapter instead of provider-level icons

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 21:02:14 +02:00
Sandeep Somavarapu
6a7e1b4bd3 fix #305345 (#306429)
Fix #305345
2026-03-30 18:51:01 +00:00
Rob Lourens
590f350b07 quickinput: keep Command Center visible when Quick Pick is dragged away (#306139)
* quickinput: expose alignment observable, keep Command Center visible when Quick Pick is dragged

When the Quick Pick is dragged away from its default top position, the
Command Center in the title bar no longer hides. Previously it always
hid on Quick Pick show, even when the widget was in a custom position
where it wouldn't overlap.

Changes:
- Add QuickInputAlignment type ('top' | 'center' | 'custom') and
  alignment observable to IQuickInputService
- DnD controller tracks alignment via _setAlignmentState() helper that
  updates both the context key and the observable
- Each service layer has a stable observableValue mirrored via autorun
  (avoids breaking subscriptions on lazy controller creation)
- Command Center uses autorun to reactively show/hide based on alignment
- Fix onShowEmitter.fire() timing (moved after layoutContainer so
  alignment is settled before listeners fire)
- Fix top===0 truthiness bugs in layoutContainer and updateLayout
- Fix double-click reset not updating alignment state

Fixes #306138

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* quickinput: handle anchored inputs and partial state in alignment

- Set alignment to 'custom' for anchored quick inputs (positioned near
  a DOM element, not at the top)
- Re-sync alignment from DnD controller on non-anchored show to prevent
  stale 'custom' value after an anchored input closes
- Guard setAlignment() to no-op while an anchored input is visible
- DnD alignment typed as IObservable<QuickInputAlignment> (read-only)
- Require both top and left in persisted state before marking as custom

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 18:43:28 +00:00
Benjamin Pasero
8a20f2fffe sessions: align sticky section headers in sessions list (#306420)
sessions - align sticky section headers in sidebar list

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 18:32:07 +00:00
Rob Lourens
11f363eab7 Simplify codeblock rendering in chat markdown (#305845)
* Simplify codeblock rendering in chat markdown

* Simplify URIs more

Co-authored-by: Copilot <copilot@github.com>

* Simplify

Co-authored-by: Copilot <copilot@github.com>

* Fix error

* Also hold a model reference

Co-authored-by: Copilot <copilot@github.com>

---------

Co-authored-by: Copilot <copilot@github.com>
2026-03-30 20:23:37 +02:00
Benjamin Pasero
3d3ff03a52 sessions - update changes view styles for modal editor (#306395) 2026-03-30 10:33:42 -07:00
Dmitriy Vasyura
00356ebc69 Update UI bug fixes and improvements (#306251) 2026-03-30 17:32:23 +00:00
Yogeshwaran C
4003d390fb fix: scope editor service in window title to own editor groups container (#306226)
* fix: scope editor service in window title to own editor groups container

The main window's WindowTitle used the global IEditorService which
tracks editor groups across all windows including auxiliary windows.
When a terminal was moved to a new window, the auxiliary window's
active editor change propagated to the main window's title, causing
it to incorrectly display the terminal name instead of the open file.

Scope the editor service used by WindowTitle to the window's own
editor groups container so each window title only reflects editors
within that window.

Closes #267538

* scope entire instantiator

* compile

* polish

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2026-03-30 17:18:34 +00:00
Copilot
c2016b08f5 Fix local history commands when resource URI scheme is vscode-local-history (#306147)
* Initial plan

* fix: map vscode-local-history URIs back to original file URI in findLocalHistoryEntry

When the diff editor shows two local history versions, the active editor
URI uses the vscode-local-history scheme. findLocalHistoryEntry now converts
this back to the original file URI before querying workingCopyHistoryService,
matching the existing logic in provideTimeline.

Fixes microsoft/vscode#250469

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/aae53613-4b18-418c-867c-d650153ddbbf

Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
2026-03-30 17:17:52 +00:00
dependabot[bot]
8c61afa367 Bump path-to-regexp from 8.2.0 to 8.4.0 in /test/mcp (#305927)
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) from 8.2.0 to 8.4.0.
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v8.2.0...v8.4.0)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-version: 8.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2026-03-30 17:07:01 +00:00
Benjamin Pasero
33741c2647 Default files.watcherExclude patterns cause CPU stall on large repos due to pathological regex (fix #305923) (#306224) 2026-03-30 19:03:46 +02:00
Matt Bierner
002f2d99e8 Merge pull request #302609 from mjbvz/dev/mjbvz/amused-xerinae
Add ChatSessionInputState
2026-03-30 09:59:17 -07:00
mrleemurray
cb1415cf48 style: update agent feedback input widget border color and adjust textarea font size 2026-03-30 17:34:29 +01:00
Lee Murray
c892221c72 Update src/vs/sessions/contrib/agentFeedback/browser/media/agentFeedbackEditorInput.css
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-30 17:25:53 +01:00
Lee Murray
1efdec3f0c Update src/vs/sessions/contrib/agentFeedback/browser/agentFeedbackEditorWidgetContribution.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-30 17:25:20 +01:00
mrleemurray
ec0ca2c447 style: enhance agent feedback input widget with animation and adjust padding in items 2026-03-30 17:15:24 +01:00
mrleemurray
18dbdd1270 style: adjust padding and dimensions in agent feedback widget header and items
Co-authored-by: Copilot <copilot@github.com>
2026-03-30 17:05:49 +01:00
Ladislau Szomoru
0fab59cfae Sessions - polish changes item action bar (#306366) 2026-03-30 16:00:41 +00:00
xingsy97
d919f292bf comments: fix memory leak when recycling tree items in comment panel (#304666)
* comments: add disposeElement to prevent disposable accumulation on template reuse

* split template vs element disposables per review feedback

* retrigger CI

* Use disposable store

---------

Co-authored-by: Alex Ross <38270282+alexr00@users.noreply.github.com>
2026-03-30 15:45:33 +00:00
Sandeep Somavarapu
9f149cd91b sessions: gate CI rerun button on valid run ID and add tests (#306362)
sessions: gate rerun button on valid run ID and add tests

Only show the Rerun Check action when the check's detailsUrl contains
a parseable GitHub Actions workflow run ID. Export parseWorkflowRunId
for reuse.

Add unit tests for rerunFailedJobs endpoint and parseWorkflowRunId.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-30 17:45:00 +02:00
Copilot
76258864c3 Merge pull request #305995 from microsoft/copilot/fix-model-reference-leak
fix: dispose createModelReference ref on stale element in disassemblyView
2026-03-30 15:33:09 +00:00
dependabot[bot]
fc734bd35b Bump brace-expansion from 1.1.12 to 1.1.13 in /extensions/markdown-language-features (#305820)
Bump brace-expansion in /extensions/markdown-language-features

Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.12 to 1.1.13.
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](https://github.com/juliangruber/brace-expansion/compare/v1.1.12...v1.1.13)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 1.1.13
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-03-30 17:27:59 +02:00
Martin Aeschlimann
cc13977fc4 rename VS Code Dark -> Dark 2026 (#306364) 2026-03-30 15:24:38 +00:00
Ladislau Szomoru
f91019e767 Sessions - set isolation mode when we cannot detect a repository (#306359) 2026-03-30 15:01:06 +00:00
Lee Murray
e231798dee theme: add notification for auto-updated default themes (#306341)
Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
2026-03-30 16:53:14 +02:00