Commit Graph

59452 Commits

Author SHA1 Message Date
Joao Moreno 1420967188 fixes #86848 2020-01-14 12:18:26 +01:00
Martin Aeschlimann f43c3601e5 tokenStyleResolving: fix test 2020-01-14 11:31:34 +01:00
Martin Aeschlimann da5d2781b0 replace console with logService. For #84283 2020-01-14 11:31:34 +01:00
isidor c96aece131 tree: respect isChecked and getRole
#88553
2020-01-14 11:30:55 +01:00
Martin Aeschlimann 585e937ef2 Merge branch 'aeschli/ts-sem' 2020-01-14 11:17:00 +01:00
Alexandru Dima 4e5a05c3fd Don't instrument any test code for coverage (#86608)
Don't instrument any test code for coverage
2020-01-14 11:10:51 +01:00
Alexandru Dima 31ef68ff7c Adopt latest istanbul libraries 2020-01-14 11:09:29 +01:00
Johannes Rieken 160a1c6978 suggest - dont force widget creation 2020-01-14 11:07:57 +01:00
Martin Aeschlimann 926407a8b5 fix semantic token style caching 2020-01-14 10:58:15 +01:00
Benjamin Pasero 7c8b0844ec fix #87330 2020-01-14 10:48:10 +01:00
Benjamin Pasero 611f25cce2 💄 2020-01-14 10:48:09 +01:00
Sandeep Somavarapu 3d6aef8b9f #87461 Small refactorings
- Remove cyclic dependency between view descriptor collection and views service
- use view collection for getting and listening on views given a container
- return view descriptor colleciton always for a container
2020-01-14 10:38:48 +01:00
Martin Aeschlimann 5a01900212 [semantic tokens] Remove "-" minus styles. Fixes #86282 2020-01-14 10:31:11 +01:00
Dima Krasner 76429d2f58 Bump node-native-keymap to 2.1.1 for easier arm64 cross-compil… (#86659)
Bump node-native-keymap to 2.1.1 for easier arm64 cross-compilation
2020-01-14 10:27:15 +01:00
Benjamin Pasero 707061ce17 💄 2020-01-14 10:17:47 +01:00
Alexandru Dima db12b4a1fd Update diff icons to use codicons (#88013)
Update diff icons to use codicons
2020-01-14 10:16:39 +01:00
Benjamin Pasero 5dfa261ced remote - allow to open files from user home with tilde syntax (#83213) 2020-01-14 10:16:04 +01:00
Alexandru Dima d02eb0ecd2 Just apply review feedback 2020-01-14 10:15:08 +01:00
Alexandru Dima 722bc320a9 Merge branch 'master' into misolori/diff-icons 2020-01-14 10:11:26 +01:00
Alexandru Dima 2d1e215598 Enable Shift-Insert to paste primary clipboard on Linux, fixes… (#63374)
Enable Shift-Insert to paste primary clipboard on Linux, fixes #36170.
2020-01-14 10:08:40 +01:00
Martin Aeschlimann 5ee9f6646e add constants 2020-01-14 10:07:40 +01:00
Johannes Rieken 3140b9c99f fix #88561 2020-01-14 10:07:36 +01:00
Alex Dima a4a3e90dc8 Only register PasteSelectionClipboardAction on Linux 2020-01-14 10:07:08 +01:00
Alex Dima ad1500b9db Extract paste selection clipboard code to an action 2020-01-14 10:03:25 +01:00
Sandeep Somavarapu 980d8ef137 #87461 Fix open view. Consider existing views. 2020-01-14 09:37:13 +01:00
Johannes Rieken 7a62151d6a fix https://github.com/microsoft/vscode/issues/88591 2020-01-14 09:27:19 +01:00
Martin Aeschlimann a9b2eb97de Merge branch 'master' into aeschli/ts-sem 2020-01-14 09:24:30 +01:00
Alexandru Dima 476c4fef21 Merge branch 'master' into sameer/36170 2020-01-14 09:20:25 +01:00
Benjamin Pasero 52702da6ef Same editor appears twice in tabs (fix #88551) 2020-01-14 08:34:31 +01:00
Jackson Kearl bf350ef870 remove unused 2020-01-13 22:32:17 -08:00
Jackson Kearl 501085f224 Add basic save functionality to search editor 2020-01-13 21:51:59 -08:00
Matt Bierner c3c54744ab Convert CodeActionTrigger type enum type 2020-01-13 20:55:32 -08:00
Matt Bierner 560f922d6f Add telemetry on which code actions are applied
We are trying to improve the discoverability of code actions. To do this, we need to have a baseline of how often people are applying actions such as refactorings so that we can measure if changes like adding documentation have an impact on their usage rates.

Ref #86788
2020-01-13 20:34:49 -08:00
Matt Bierner c044f090ce Remove unused vars 2020-01-13 20:21:48 -08:00
Matt Bierner 904951e31f Only return documentation code action in refactor menu 2020-01-13 20:18:56 -08:00
Matt Bierner 2bbe9c5330 Only override editor opening for resource that have potential custom editors
For #88525
2020-01-13 12:53:09 -08:00
Johannes Rieken 1ea4d14894 add AriaProvider, #88553 2020-01-13 21:35:51 +01:00
Johannes Rieken 80c6acdf31 fix issue with accessibility provider, #88554 2020-01-13 21:35:51 +01:00
Martin Aeschlimann 7ef5ef6e95 polish html sem highlighting 2020-01-13 21:35:51 +01:00
Connor Peet 1de4563f26 fix(debug): don't insert task boundaries between events (#88459)
* fix(debug): don't insert task boundaries between events

See discussion in https://github.com/microsoft/vscode-js-debug/issues/206.

This PR adjusts logic such that we only assert task boundaries around
requests and responses, rather than around every single event. I believe
this will solve the primary case where misordering can happen, as given
in the existing unit test and described more verbosely in the doc
comment in this PR.

A more conservative approach would be to only omit the boundary between
events of the same type. That would be safer, but I browsing through
the code I didn't see any cases where it looked like we could get
tripped up by bucketing here (e.g. cases where we resolve a deferred
promise in an event handler).

Seems to fix the performance issue for me.

* fixup! add unit tests for ordering
2020-01-13 21:35:51 +01:00
Jackson Kearl 9fa325deec Fix search editor URI malform error 2020-01-13 21:35:51 +01:00
SteVen Batten 85903e849f missed rename for viewsservice 2020-01-13 21:35:51 +01:00
SteVen Batten 16b75e3307 Enhance views service (#87505)
Add view-moving functionality to viewsservice which has been renamed to viewdescriptorservice. also includes outline view moving
2020-01-13 21:35:51 +01:00
Daniel Imms 39af627463 has -> had 2020-01-13 21:35:51 +01:00
jeanp413 1e061ff1d4 💄 2020-01-13 21:35:51 +01:00
jeanp413 fe572bbb59 Fixes #88242 2020-01-13 21:35:51 +01:00
kieferrm 115dde7d65 issue flow configuration 2020-01-13 21:35:51 +01:00
Konstantin Solomatov fb9a7f0398 Fix incorrect negation 2020-01-13 21:35:51 +01:00
Konstantin Solomatov 137c78d711 Code cleanup 2020-01-13 21:35:51 +01:00
Martin Aeschlimann 27546bcb56 fix test failure 2020-01-13 21:35:22 +01:00