Commit Graph
70524 Commits
Author SHA1 Message Date
isidor 44699b0254 Fix Trusted Types violations (round #2) #106395 2020-09-10 11:52:23 +02:00
Johannes Rieken 01f9355f65 debt - simplify metadata edit because we now have CellEditType.DocumentMetadata 2020-09-10 11:48:44 +02:00
Dirk Baeumer 533ca9bf07 Adress #106358: Fix TS 4.1 errors in codebase 2020-09-10 11:36:22 +02:00
Alex Ross 26803cee9b Fix TS 4.1 errors for tasks and remote explorer
Part of #106358
2020-09-10 11:35:13 +02:00
Johannes Rieken 226c417bc6 update trusted types search 2020-09-10 11:30:10 +02:00
Benjamin Pasero 72f468f569 more TS 4.1 fixes (#106358) 2020-09-10 11:29:07 +02:00
João Moreno 41794e5631 trusted types
related to #106395
2020-09-10 11:19:20 +02:00
Vyacheslav Pukhanov 663810e275 Adds commands for --no-verify commit variants (#106335)
* add `{allow,confirm}NoVerifyCommit`  options

* adds commit comands with no verify

* handles no verify command variants

* handle no verify commit option

* only display no verify variants when option is set
2020-09-10 11:14:28 +02:00
Benjamin Pasero 82d953a731 pinned tabs - add a tab.lastPinnedBorder color 2020-09-10 10:51:31 +02:00
Benjamin Pasero 6173cf8a99 pinned tabs - closing pinned tab should open next non-pinned 2020-09-10 10:23:29 +02:00
João Moreno 25081cdb65 fix ts errors
related to #106358
2020-09-10 10:02:07 +02:00
Benjamin Pasero a443309bcf Merge pull request #106385 from microsoft/ben/pinned-tabs-setting
Pinned Tabs Enhancements
2020-09-10 09:30:51 +02:00
Benjamin Pasero 1424f2be8a pinned tabs - flip default to "shrink" 2020-09-10 09:28:16 +02:00
Johannes Rieken c591f8b562 fix TS 4.1 compile errors, https://github.com/microsoft/vscode/issues/106358 2020-09-10 09:20:21 +02:00
Benjamin Pasero c3c812660e Merge branch 'master' into ben/pinned-tabs-setting 2020-09-10 08:54:15 +02:00
Benjamin Pasero 76e7cbb0da fix some TS 4.1 errors (#106358) 2020-09-10 08:53:24 +02:00
Benjamin Pasero 3fb8967173 fix some TS 4.1 errors (#106358) 2020-09-10 08:49:08 +02:00
Matt Bierner ec8016f7d1 Cache webview view title across reloads
Fixes #105867
2020-09-09 21:51:22 -07:00
Matt Bierner cf38af84ff Revert "Fix #106303"
This reverts commit 8e5eed1299.

this is causing a layer check issue
2020-09-09 21:37:16 -07:00
Matt Bierner 3f8f022200 Use destructuring to make code more clear 2020-09-09 21:26:51 -07:00
Rob Lourens 8e5eed1299 Fix #106303 2020-09-09 21:44:43 -05:00
rebornix 03960a5aa1 re #105735. no more udpateMetadata api. 2020-09-09 16:45:00 -07:00
rebornix 73a3c9ded3 re #105735. 2020-09-09 16:45:00 -07:00
Connor Peet 7e62739639 debug: bump js-debug-companion 2020-09-09 16:41:48 -07:00
Rachel Macfarlane cceaf14323 #106358 2020-09-09 15:37:31 -07:00
Matt Bierner 80b1a775d6 Enable webview commands for webview views
Fixes #105670

Previously our webview commands assumed that webviews were always going to be in an editor. This is no longer true with webview views.

To fix this, I've added an `activeWebview` to the `IWebviewService`. This  tracks the currently focused webview.
2020-09-09 14:44:46 -07:00
Matt Bierner 6cf52e3828 Mark property readonly 2020-09-09 14:44:46 -07:00
rebornix 889fe1787b 💄 2020-09-09 14:40:44 -07:00
rebornix 69f26324d4 initialize notebook text model data only through ctor. 2020-09-09 14:40:44 -07:00
Miguel Solorio a037570775 Update Codicons: add 'graph-left'
https://github.com/microsoft/vscode-codicons/commit/dd1edb245d2217efcfb931c293b77b78e634e59a
2020-09-09 13:54:51 -07:00
Daniel Imms 6821292b4b Fix ts 4.1 issues in terminal api tests 2020-09-09 12:43:25 -07:00
Daniel Imms d55efd8041 Fix terminal ts 4.1 compile issues
Part of #106358
2020-09-09 12:43:22 -07:00
Jackson Kearl ebff341de3 Add subscribers action 2020-09-09 12:22:34 -07:00
SteVen Batten 424a2bf17b refs #106285 2020-09-09 12:07:26 -07:00
rebornix ee5ee9e8aa chore, simply notebook text model event emitter 2020-09-09 12:04:21 -07:00
rebornix 8bc3145bc5 move dirty state to NotebookEditorModel. 2020-09-09 12:04:21 -07:00
rebornix 4e70e4a699 fix #105916. expand metadata section if modified. 2020-09-09 12:04:20 -07:00
rebornix e491efbaab replace changeCellLanguage to applyEdit 2020-09-09 12:04:20 -07:00
rebornix eb7f042acf remove selections from nb text model. 2020-09-09 12:04:20 -07:00
rebornix deaf9f2689 💂 polish nb tests. 2020-09-09 12:04:20 -07:00
rebornix eb05b79e9b do not need isUntitled. 2020-09-09 12:04:20 -07:00
Johannes Rieken 9753398da5 debt - invoke resolve notebook when opening a notebook in an editor, not when loading a notebook from source 2020-09-09 20:34:54 +02:00
Johannes Rieken e40d854df6 debt - IMainNotebookController#removeNotebookDocument 2020-09-09 20:01:35 +02:00
Matt Bierner 5cdf679c44 Add explicit undefined parameters / types
These errors come from the new stricter types for Promises in TS 4.1
2020-09-09 10:57:05 -07:00
Miguel Solorio fecec73e53 Update Codicons
- Update 'pinned'
- Add 'export'
- Compress 'merge'
https://github.com/microsoft/vscode-codicons/commit/5bcb1a045413eb5a9737e6e46411e13f9c4e5c9c
2020-09-09 09:29:42 -07:00
Johannes Rieken f3532c9061 chore - use workingCopyService.isDirty instead notebook.isDirty 2020-09-09 18:24:47 +02:00
Matt Bierner 7e0c1aa76e Don't use async on abstract functions 2020-09-09 09:21:56 -07:00
Matt Bierner c348165cc0 Adding more explicit typings for promises
This gets us ready for TS 4.1
2020-09-09 09:21:56 -07:00
Matt Bierner 2a954244f0 Only allow configurePlugin against main TS Server
Fixes #106346

Looks like the TS Server doesn't support this in partial mode at the moment
2020-09-09 09:21:56 -07:00
Benjamin Pasero c1e9502223 Save prompt is shown while saving from settings split json editor (fix #106330) 2020-09-09 16:51:36 +02:00