Commit Graph

107032 Commits

Author SHA1 Message Date
Daniel Imms 4dfdf2adf0 Improve hover behavior when not enough space
This changes the hover's position fallback logic from:

If not enough room on right
  Position left
If not enough room on left
  Position right

To:

If not enough room on right
  If enough room on left
    Position left
  Else
    Position below
If not enough room on left
   If enough room on right
     Position right
   Else
     Position below

A new option showHoverHint is also added as part of this which will show a hint
to the user to hold alt/option in order to mouse over the hover (only when the
evaluated hover is true). This is an explicit setting such that it doesn't show
up on hovers such as the activity bar which looks awkward.

Fixes #176704
2023-03-28 15:04:27 -07:00
Megan Rogge 4a1e2a4a6f Merge pull request #178450 from microsoft/merogge/tidy
tidy accessibleBuffer ctor
2023-03-28 13:06:40 -07:00
Daniel Imms 614752306e Merge pull request #178513 from microsoft/tyriar/178326
Support links with <> on non-Windows
2023-03-28 12:43:54 -07:00
Ladislau Szomoru 9e6a369b13 Action button - disable button during checkout (#178488) 2023-03-28 21:42:18 +02:00
meganrogge d31352815e move listeners back 2023-03-28 12:23:42 -07:00
meganrogge 69c9a267d7 _layout 2023-03-28 12:22:05 -07:00
Matt Bierner 4eb8467961 Remove extra decode while loading webview resources (#177753)
Fixes #154860

The extra decode call messes up installs that have `%` in the path. Tested this change with paths that include spaces, multi-byte characters, and `%`
2023-03-28 11:51:01 -07:00
Matt Bierner 660b8cc1fc Pick up latest TS for building VS Code (#178518)
* Pick up latest TS for building VS Code

* Fix type check error
2023-03-28 20:50:45 +02:00
Daniel Imms e8b9407b12 Merge branch 'main' into tyriar/178326 2023-03-28 11:37:58 -07:00
Matt Bierner 5f328ba75d Markdown language server 0.3.0 (#178512)
0.3.0 for markdown language server
2023-03-28 20:14:46 +02:00
Joyce Er 4415334748 🆙distro (#178511) 2023-03-28 20:04:59 +02:00
Daniel Imms cba1fd0360 Support links with <> on non-Windows
Fixes #178326
2023-03-28 10:51:52 -07:00
Connor Peet f51387bed1 debug: bump js-debug (#178509)
Contains the following changes: https://github.com/microsoft/vscode-js-debug/compare/v1.77.0...v1.77.1

Cherry pick of candidate for https://github.com/microsoft/vscode/issues/178282
2023-03-28 19:50:38 +02:00
Benjamin Pasero b0b69338e8 debt - further reduce electron-browser layer (#178504)
* debt - move more tests out of `electron-browser`

* move more tests

* move preload script as well

* fix
2023-03-28 10:35:58 -07:00
Hermann Loose de3b0db8e8 Allow individual comments to be marked as draft (#173305)
* Allow individual comments to be marked as draft

This is a proposal for #171166.

* Remove `hasDraftComments` from `CommentThread`

* Rename `CommentVisibility` to `CommentState`

* Rename `CommentVisibility` to `CommentState`

* Add api proposal check

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
2023-03-28 19:18:22 +02:00
Joyce Er 0a3470a001 Consolidate Provide Feedback and Report Issue (#178284)
* Consolidate `Provide Feedback` and `Report Issue`

* Update `takeAction`
2023-03-28 09:57:17 -07:00
Ulugbek Abdullaev 4076e93c3c cleanup abstractKeybindingService & keybindingResolver (#178506)
* keybindings: abstractKeybindingService: organize imports

* keybindings: abstractKeybindingService: fix naming of currently active chords

* keybindings: abstractKeybindingService: more renamings

* keybindings: keybindingResolver: renamings

* keybindings: keybindingResolver: doc comment what KeybindingResolver is
2023-03-28 09:48:51 -07:00
dependabot[bot] 29d93918d2 Bump openssl from 0.10.42 to 0.10.48 in /cli (#178296)
Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.42 to 0.10.48.
- [Release notes](https://github.com/sfackler/rust-openssl/releases)
- [Commits](https://github.com/sfackler/rust-openssl/compare/openssl-v0.10.42...openssl-v0.10.48)

---
updated-dependencies:
- dependency-name: openssl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-28 08:20:29 -07:00
Matt Bierner a37f49896f Bump github issue notebook milestones (#178501) 2023-03-28 17:19:35 +02:00
Henning Dieterichs 8103072440 Fixes bug in getLineRangeMapping (#178500) 2023-03-28 17:18:34 +02:00
Henning Dieterichs 8d35ea8c41 Improves timeout handling of diffing algorithm (#178497) 2023-03-28 17:03:46 +02:00
最萌小汐 a90c9d0ab6 Update Lua grammar (#177798) 2023-03-28 14:34:28 +00:00
Christof Marti 226b09243f Update names (#174935) 2023-03-28 16:18:29 +02:00
SteVen Batten 5fede87e33 reduce motion menus (#178492)
related #175990
2023-03-28 16:01:56 +02:00
尹东方 369f0b0793 Fix 'Window' key is treated as 'unknown' in Firefox (#175739) 2023-03-28 14:56:48 +02:00
Alex Ross 22c8efe084 Add file level commenting (#178478) 2023-03-28 13:39:05 +02:00
Benjamin Pasero 3edcfeb381 debt - fix some JS compile errors (#178472)
* debt - fix some JS compile errors

* simplify
2023-03-28 09:52:01 +02:00
Matt Bierner d490dfe9f7 Disable MD server builds on changes (#178464)
We will manually trigger builds instead
2023-03-28 09:00:10 +02:00
Matt Bierner 87a6bda310 Fix opening encoded markdown fragment in preview (#178465)
Fixes #178340
2023-03-28 08:59:30 +02:00
Benjamin Pasero b931935042 debt - explicitly use import type (#178473) 2023-03-28 08:57:21 +02:00
João Moreno 11685d784a bump distro (#178469) 2023-03-28 07:25:10 +02:00
Rob Lourens cbdf7c5e8a Disable find widget in debug console tree (#178459)
See #4338
2023-03-28 01:50:48 +02:00
Raymond Zhao d4885b3f7a Add precondition for focusing Settings control (#178456) 2023-03-28 01:02:53 +02:00
Daniel Imms 60f15ceb40 Merge pull request #178453 from microsoft/tyriar/distroo
Update distro
2023-03-27 14:28:56 -07:00
Daniel Imms 8534736d3e Update distro 2023-03-27 14:12:54 -07:00
Connor Peet dfbea0f578 cli: when attaching, always print the connection link (#178445)
Fixes #178090
2023-03-27 12:52:50 -07:00
Megan Rogge 962c340d4d rm empty line 2023-03-27 12:47:54 -07:00
Megan Rogge 88800795b5 tidy accessibleBuffer ctor 2023-03-27 12:45:06 -07:00
Connor Peet b51e2f3613 cli: only connect to existing tunnel process when quality is the same (#178446)
Fixes #178089
2023-03-27 12:11:18 -07:00
Daniel Imms 0474f7a359 Merge pull request #178443 from microsoft/tyriar/xterm_update_20230327
xterm@5.2.0-beta.33
2023-03-27 11:42:44 -07:00
Megan Rogge 18ff83cbc1 Merge pull request #178444 from microsoft/merogge/focus-acc-if
focus the accessible buffer if active when terminal view is focused
2023-03-27 11:42:03 -07:00
meganrogge 3769e6fa13 fix #178055 2023-03-27 11:15:04 -07:00
Daniel Imms 3cf7f3891f xterm@5.2.0-beta.33
Fixes #177736
2023-03-27 11:10:55 -07:00
Megan Rogge 2bd75260cf Merge pull request #178439 from microsoft/merogge/fix-b
improve logic for when accessible buffer editor should be updated
2023-03-27 11:02:25 -07:00
Connor Peet 80790e6416 testing: fix 'go to test' shortcut not working (#178440)
Fixes #174241
2023-03-27 19:26:00 +02:00
meganrogge 49ca3bbafb fix #178434 2023-03-27 10:02:08 -07:00
meganrogge e813d20c4c fix #178253 2023-03-27 09:27:52 -07:00
Daniel Imms 08cc1938fe Merge pull request #178257 from microsoft/tyriar/175952
Move terminal quick fix into a terminal contrib
2023-03-27 09:08:02 -07:00
Andrea Mah 744cd19a07 sorting for webview matches in search (#178288) 2023-03-27 08:29:12 -07:00
Ulugbek Abdullaev f5e31b736b keyboardEvent: fix translation of a e.keyCode to a virtual keycode 2023-03-27 17:07:49 +02:00