Commit Graph

55353 Commits

Author SHA1 Message Date
Benjamin Pasero e9ee372447 debt - reduce usage of strict null bypass 2019-10-07 10:56:34 +02:00
Alex Ross 06c10cddf0 Strict init for tasks in extHostTypes.ts
Part of #78168
2019-10-07 10:54:27 +02:00
João Moreno d9935e0dfe Merge pull request #81840 from kondratyev-nv/master
Use yarn compile for start scripts
2019-10-07 10:52:45 +02:00
Alex Dima 6c9cf76929 Remove unused styling code 2019-10-07 09:58:03 +02:00
Alex Dima 93cfe48a3f Strict property initialization (#78168) 2019-10-07 09:25:12 +02:00
Johannes Rieken 56c472e185 strict init 2019-10-07 08:36:02 +02:00
Johannes Rieken 999d8f97df Merge branch 'joh/next' 2019-10-07 08:30:19 +02:00
Johannes Rieken 50c2639b86 Merge branch 'joh/strict' 2019-10-07 08:30:19 +02:00
Johannes Rieken d73a2f7a88 debt - less defense 2019-10-07 08:30:18 +02:00
Johannes Rieken 904ab2364e in extension land prefer URI.isUri, fixes #81819 2019-10-07 08:30:18 +02:00
Johannes Rieken e257fad18a deco - some debt, add logging 2019-10-07 08:30:18 +02:00
Benjamin Pasero c617db19b0 debt - some strict function types (#81574) 2019-10-05 16:11:41 +02:00
Benjamin Pasero 875fc151e2 web - store font info properly 2019-10-05 08:18:47 +02:00
Benjamin Pasero ae891b59bc web - do not reload if workspace is equal 2019-10-05 08:18:39 +02:00
Benjamin Pasero fc7727b0d3 debt - move out reload/quit to lifecycle service 2019-10-05 08:17:06 +02:00
Benjamin Pasero a3d77034dc debt - no need for explicit closeWorkspace() 2019-10-05 08:14:07 +02:00
Benjamin Pasero 45856f0eba debt - windows => windowsMainService 2019-10-05 08:12:42 +02:00
Benjamin Pasero 1602957aa2 debt - remove no longer needed code 2019-10-05 08:10:21 +02:00
Benjamin Pasero ffbc48855a debt - add whenClosedOrLoaded into window class 2019-10-05 08:09:56 +02:00
Benjamin Pasero 86a42393b0 debt - handle window errors in window class 2019-10-05 08:03:45 +02:00
Benjamin Pasero c55d704a14 debt - move pick & open into electron main service 2019-10-05 07:58:41 +02:00
Daniel Imms ff09b48de3 Merge pull request #81975 from youngyou/patch-1
Press `space` key on a disabled button should not trig click event.
2019-10-04 21:02:20 -07:00
Matt Bierner 45c4f22894 Fixing more issues related to #81574 2019-10-04 17:57:33 -07:00
Matt Bierner 8e944be15c Support jsonc for code block type with highlightjs 2019-10-04 17:57:33 -07:00
Matt Bierner 36aa903d5a Rewrite how we handle links in the md preview
Try to simplify how we resolve links:

- Move most logic out of the preview itself.
- Simplify the amount of rewriting we do in the markdown engine
2019-10-04 17:57:33 -07:00
Daniel Imms 7f5a4a3f5b Fix strictFunctionTypes errors in terminal proxy
Part of #81574
2019-10-04 17:39:05 -07:00
Daniel Imms a0c6566f87 Fix strictFunctionTypes errors in terminalService
Part of #81574
2019-10-04 16:34:23 -07:00
Daniel Imms 4ddddcfb6d Fix strictFunctionTypes errors in terminalInstance
Part of #81574
2019-10-04 16:34:22 -07:00
Matt Bierner a967c8ada3 Move js/ts json validation to js/ts language features extension
Fixes #73336
2019-10-04 15:31:21 -07:00
Matt Bierner e1011ffcc8 Marking event properties as readonly 2019-10-04 15:24:25 -07:00
Matt Bierner dc0ab50035 Use isEqual for comparing uris in more places vs .toString() 2019-10-04 15:22:42 -07:00
Matt Bierner 7e70b1dda0 Mark that preferredEncoding can be undefined / not initialized
Part of #78168
2019-10-04 14:58:42 -07:00
Matt Bierner a7ddb97e91 Fix strict property init in parameterHintWidget
For #78168
2019-10-04 14:43:18 -07:00
Matt Bierner 92514c469c Fix a few more issues related to #81574 2019-10-04 14:25:55 -07:00
Matt Bierner 30120e4db6 Dont pass undefined as boolean
For #81574
2019-10-04 14:11:52 -07:00
Matt Bierner 831800d6d8 Make sure we also change webview theme data when editor config changes 2019-10-04 13:56:14 -07:00
Matt Bierner b9693027bb Use switch case 2019-10-04 13:43:08 -07:00
Matt Bierner 7f044c7903 Memoize webview theme data
Fixes #81788
2019-10-04 13:42:04 -07:00
Matt Bierner d08130d4d3 Remove some extra not null checks
These checks should not be required now that we have strict null checking enabled
2019-10-04 13:21:51 -07:00
Matt Bierner 41a26f0322 Fixing some TS 3.7 dom typing errors
TS 3.7 changes the many dom style typings to just be `string` instead of `string | null`. Use empty string in place of null for these cases
2019-10-04 13:18:07 -07:00
Matt Bierner 05de12c548 Bump version 2019-10-04 13:08:46 -07:00
Keyon You a46c17e5b9 Update button.ts
Press `space` key on a disabled button should not trig click event
2019-10-05 03:19:13 +08:00
Miguel Solorio 94c9c09627 Update syntax 2019-10-04 09:20:09 -07:00
Christof Marti c310c24e58 Allow labels being triggered by the bot 2019-10-04 13:07:03 +02:00
Johannes Rieken c06c223ee9 more strict init work 2019-10-04 11:52:05 +02:00
Benjamin Pasero c8252b63f5 Revert "fixes #80054" (#81942)
This reverts commit d591cb7e6d.
2019-10-04 10:43:55 +02:00
Miguel Solorio c836d5ae38 Include icons in the extension viewlet 2019-10-03 14:04:51 -07:00
Matt Bierner d3eb24828e Use strict compare for checking if an editor is active/visible
Fixes #81889

Using `.matches` can cause a custom editor to match all custom editors for that resource. Use a strict compare instead.
2019-10-03 13:53:30 -07:00
Matt Bierner eacd477ea9 Only reuse existing custom editor input if we are opening an editor in the same group 2019-10-03 13:46:31 -07:00
Matt Bierner bac36e97c6 Close image preview when file on disk is deleted
Fixes #81884
2019-10-03 13:46:31 -07:00