Commit Graph

55353 Commits

Author SHA1 Message Date
Matt Bierner 4e2caaa646 Use array.find in more places of re-implementing it with for loops 2019-10-07 14:43:53 -07:00
Rachel Macfarlane d1b81e23db Remove applicationinsights-web dependency 2019-10-07 14:34:21 -07:00
Matt Bierner 99dc069a0c Remove another duplicated array equals helper function 2019-10-07 14:18:58 -07:00
Matt Bierner 30dc021bf7 null -> undefined 2019-10-07 14:18:58 -07:00
Matt Bierner 40e0f496f9 Use equals helper function instead of re-implementing it so many places 2019-10-07 14:18:58 -07:00
Matt Bierner 6e593ab812 Converting some search for loops to use .some/.every instead
Prefer using these predicates as they are shorter and make the code easier to understand
2019-10-07 14:18:58 -07:00
Matt Bierner 4a461d267f Converting a few functions in ITokenizationRegistry to return undefined instead of null 2019-10-07 14:18:58 -07:00
Matt Bierner 948af79e49 Markding results from panelService as readonly 2019-10-07 14:18:58 -07:00
Matt Bierner de9a8a67b3 Converting some parts of panel service to return undefined instead of null 2019-10-07 14:18:58 -07:00
Matt Bierner ab3f2e6180 Use find instead of for loop 2019-10-07 14:18:58 -07:00
Matt Bierner 02ae385856 Convert getPanel to return undefined instead of null 2019-10-07 14:18:58 -07:00
Matt Bierner a660620e88 Convert null -> undefined 2019-10-07 14:18:58 -07:00
Rachel Macfarlane 73d2f81d13 Mark that pendingComment can be null, #81574 2019-10-07 13:33:35 -07:00
Benjamin Pasero 3c70da4c8c 🆙 graceful-fs@4.2.2 (#82058) 2019-10-07 20:33:35 +02:00
Benjamin Pasero 6869239fd8 🆙 terser@4.3.8 (#82057) 2019-10-07 20:33:16 +02:00
Matt Bierner 4c4edcefeb Fixing more TS 3.7 related compile errors
- Import aliasing symbol in file
- Missing function calls in conditional
- Missing return statement
2019-10-07 11:04:31 -07:00
Matt Bierner 2b4638e1ac Fix missing function calls in condition 2019-10-07 11:04:31 -07:00
Matt Bierner 9f90a1d69c Fix more TS 3.7 dom typings errors
Use an empty string instead of null for reseting styles
2019-10-07 11:04:31 -07:00
Matt Bierner 1f7e445625 Fixing more issues related to TS 3.7 dom typings changes
Fixes cases where styles value can no longer be null
2019-10-07 11:03:44 -07:00
Matt Bierner e4ec151881 Fixes more issues related to strictFunctionTypes
For #81574
2019-10-07 11:02:28 -07:00
Rachel Macfarlane 61cd8be9e3 Call resolveCommonTelemetryProperties in browser version of telemetry service 2019-10-07 10:48:39 -07:00
isidor 111b4dccff debug: more async / await 2019-10-07 19:05:24 +02:00
Miguel Solorio 0634ecc229 Merge pull request #81923 from microsoft/misolori/icon-font-problems
Adopt icon font in problems and peek error
2019-10-07 09:55:58 -07:00
Miguel Solorio 7d6b20b7d2 Merge branch 'master' into misolori/icon-font-problems 2019-10-07 09:55:30 -07:00
isidor a51693925e fix compile error 2019-10-07 17:02:41 +02:00
Alex Ross e14c86a791 Add a useful message for when background tasks don't have a watching problem matcher
Fixes #81887
2019-10-07 16:56:09 +02:00
isidor 2d713ac3a5 debug: more async await 2019-10-07 16:39:42 +02:00
Daniel Imms f380a8b047 Simplify fix for #12574
Related xtermjs/xterm.js#291
2019-10-07 07:34:55 -07:00
isidor 0d895b5bb8 debug: more async await 2019-10-07 16:19:01 +02:00
Alex Ross 491eb9bbaf Add logic for negative custom tree view highlight numbers
and handle flipped highlight start and end

Fixes #62211
2019-10-07 16:16:42 +02:00
Alex Ross 443f36dd97 Fix broken matches in custom tree 2019-10-07 15:52:17 +02:00
Alex Ross 4fb9d0dbdc Don't show folders with trailing slash in simple file dialog pick
Fixes #81911
2019-10-07 14:52:47 +02:00
isidor bc8346120d fixes #81662 2019-10-07 14:46:29 +02:00
Alex Ross a634057990 Uppercase drive letter on Windows simple file dialog
Fixes #81949
2019-10-07 14:44:13 +02:00
isidor 5847d75aad fixes #81879 2019-10-07 14:35:14 +02:00
Alex Ross c474303556 Remove .txt from save as simple file dialog
Fixes https://github.com/microsoft/vscode/issues/73580
2019-10-07 14:32:40 +02:00
Benjamin Pasero 56087d67e3 debt - strict function 2019-10-07 14:17:59 +02:00
Johannes Rieken 32b2861498 workaround - remove as const to make webpack happy... 2019-10-07 14:17:39 +02:00
Anthony Dresser 28402eb956 Update sql language syntax (#77601)
* update sql language syntax

* Remove changes to sql grammar
2019-10-07 13:58:48 +02:00
isidor 5fe0604806 enable strictFunctionTypes
#81574
2019-10-07 13:06:00 +02:00
Johannes Rieken 511137f876 Merge pull request #79764 from hwhung0111/issue-79428
Fix #79428 - add "$WORKSPACE_FOLDER" for snippet
2019-10-07 12:52:17 +02:00
Alex Ross 2d96b9b616 Fix global tasks again
Fixes https://github.com/microsoft/vscode/issues/78817
2019-10-07 12:41:19 +02:00
Joao Moreno 84786d378c distro
fixes #81919
2019-10-07 12:39:34 +02:00
Ԝеѕ 32b4eb7359 Add .har extension to JSON language (#77300) 2019-10-07 12:08:52 +02:00
Joao Moreno c1e90f3475 more strictPropertyInitialization
related to #78168
2019-10-07 11:50:40 +02:00
Benjamin Pasero 2b0a7df9da strict function types 2019-10-07 11:27:30 +02:00
Alex Ross 3ba1fe28a0 Revert "Fix customView.ts for strictFunctionTypes"
This reverts commit 4fe8b82907.
2019-10-07 11:24:35 +02:00
Alex Ross 4fe8b82907 Fix customView.ts for strictFunctionTypes
Part of #81574
2019-10-07 11:21:14 +02:00
Benjamin Pasero cb0dc7680e debt - more strict init (#78168) 2019-10-07 10:56:34 +02:00
Benjamin Pasero 66eea492f8 debt - introduce and use assertDefined for strict init (#78168) 2019-10-07 10:56:34 +02:00