Commit Graph

57217 Commits

Author SHA1 Message Date
Matt Bierner
4e8ef4cf4d Remove gating for inMemoryResourcePrefix
Some users are setting weird errors related to untitled TS files. In some of these cases (such as https://github.com/microsoft/TypeScript/issues/35091) we see a untitled file being sent to the tsserver without the `inMemoryResourcePrefix`.

I can't figure out how to get into this state but am removing the gating that *could* perhaps cause use not to set `inMemoryResourcePrefix`. This gating targets TS 2.7 or older, which telemetry shows very, very few users are still enabling in their workspaces
2019-11-14 00:17:57 -08:00
Martin Aeschlimann
53210edd79 Merge pull request #84651 from jscombs91/master
Added force-device-scale-factor to command line args
2019-11-14 09:04:53 +01:00
Benjamin Pasero
175b78de96 debt - remove sudo-prompt typings 2019-11-14 09:01:41 +01:00
Martin Aeschlimann
d68524c651 Merge branch 'master' into master 2019-11-14 09:01:07 +01:00
Benjamin Pasero
a73d87acae editor - getName() is required 2019-11-14 08:54:29 +01:00
Benjamin Pasero
929fab1876 dialog - extract confirmSave to file dialog servie 2019-11-14 08:37:18 +01:00
Johannes Rieken
9134f9fddd some mirco optimizations for CodeLensWidget, #84726 2019-11-14 07:58:37 +01:00
Matt Bierner
e1983faa78 Always show the overload count, even if there are more than 10
Fixes #84682

Also switches the use flexboxes to layout the parameter hints widget instead of absolute positioning
2019-11-13 21:28:04 -08:00
Miguel Solorio
b6a486e34f Fix #84765 2019-11-13 19:24:56 -08:00
Rob Lourens
a04563df2c Bump node-debug 2019-11-13 19:07:23 -06:00
Rob Lourens
9e3d81afe9 node2@1.41.0 2019-11-13 18:49:10 -06:00
Eric Amodio
9979d4f252 Fixes a tiny dead zone because of the resizer
AFAICT, the `-webkit-app-region: no-drag` of the resizer seems to only be honored for the first 4px. Any more and it doesn't eat the mouse event and creates a dead zone
2019-11-13 18:32:59 -05:00
Eric Amodio
d2f01a4739 Fixes #84267 - no border when maximized/fullscreen 2019-11-13 18:32:58 -05:00
Eric Amodio
2cd1b8b8e2 Removes calc's 2019-11-13 18:32:58 -05:00
Eric Amodio
4fa83458cf Aligns with bash version 2019-11-13 18:32:57 -05:00
Matt Bierner
84c882df68 Fix extHost crashing due to using vscode as a value (instead of only as types) 2019-11-13 14:51:14 -08:00
Matt Bierner
a77da1b1d8 For #81574 (#84669)
Our code currently uses the `IConstructorSignature` types in a two main ways:

- As argument types in functions that take a service constructor.
- As return types or property types when we expose a service constructor in the API

This first usage is not valid with strict function types. The reason is that the `IConstructorSignature` types takes a rest array of `...services: BrandedService[]` , while the concrete constructors you pass in use actual services. With strict function types, you cannot convert the concrete constructor type to an `IConstructorSignature` because this would drop important type information that the implementation needs. As an example

```ts
class Foo {
    constructor(@ILogService service: ILogService) {}
}

registerFoo(Foo);

// The type of `ctor` inlines `IConstructorSignature0`
function registerFoo(ctor: { new(....serivces: BrandedService[]): Foo}) {
   // When registerFoo(Foo) is called, the implementation here would need to know that
   // ctor needs to be invoked with exactly one `ILogService`. However the type of `IConstructorSignature0`
   // does not express this. Strict function types therefore disallows this conversion
}
```

To fix this, I have converted a few places were we were taking `IConstructorSignature` arguments so that they preserve the full type of the constructor. This fixed over half of our 900 strict function type errors. Unfortunatly I can not figure out a more elegant way to express this besides inlining the types

However, even after this change, we still need to figure out how to deal with:

- Places in the code where `IConstructorSignature` is exposed as a return type or object property
- How to deal with all of our descriptor types (such as `SyncActionDescriptor`)
2019-11-13 14:42:42 -08:00
Pine Wu
92caa97a1a Update distro 2019-11-13 12:33:52 -08:00
Jackson Kearl
607df9880f Add action to toggle search on type 2019-11-13 11:30:46 -08:00
Jackson Kearl
b9ca01d9c2 Only delay progress indicator when triggered on type 2019-11-13 11:09:37 -08:00
Johannes Rieken
8e7877bdc4 Revert "opener service uses IOpener for its built-in openers"
This reverts commit 283c952d3f.
2019-11-13 19:04:14 +01:00
Benjamin Pasero
877f562505 working copy - allow to get dirty copies 2019-11-13 18:21:38 +01:00
Benjamin Pasero
216187d14a textfiles - inline confirmSave 2019-11-13 18:21:38 +01:00
Sandeep Somavarapu
6910af0be9 💄 change labels 2019-11-13 18:20:47 +01:00
Sandeep Somavarapu
60188e277c wordings 2019-11-13 18:20:47 +01:00
Johannes Rieken
283c952d3f opener service uses IOpener for its built-in openers 2019-11-13 18:19:03 +01:00
Andre Weinand
4a61f33994 proposed API for creating debug uri 2019-11-13 18:18:46 +01:00
Martin Aeschlimann
c4a5657ec1 update onigasm. Fixes #82606 2019-11-13 18:06:43 +01:00
Benjamin Pasero
09324ffcf2 files - do not indicate document edited when auto save is on 2019-11-13 18:02:34 +01:00
Benjamin Pasero
7225d02a7c fix tests 2019-11-13 17:59:32 +01:00
Greg Van Liew
be6a689bca Merge pull request #84700 from gregvanl/settingsComments
Another nit in settings comment
2019-11-13 08:10:59 -08:00
Greg Van Liew
cd262f326e Merge branch 'master' into settingsComments 2019-11-13 07:43:27 -08:00
Johannes Rieken
0a0f2bffe5 Merge pull request #84048 from okmttdhr/snippet-choice-builder-method
Add builder-method for snippet choice
2019-11-13 16:30:10 +01:00
Greg Van Liew
93e87cabe5 Another nit in settings comment 2019-11-13 07:29:04 -08:00
Johannes Rieken
bd4f9e8480 update reference view extension 2019-11-13 15:51:19 +01:00
Sandeep Somavarapu
11a213a5c1 Show only one configuration sync action in global activity 2019-11-13 15:45:30 +01:00
Christof Marti
33dd2401f5 fix #83013 2019-11-13 15:36:57 +01:00
Sandeep Somavarapu
49d286b044 Show number for global activity actions that has number badge 2019-11-13 15:27:36 +01:00
Sandeep Somavarapu
3f80872c18 Show turn off action 2019-11-13 15:27:35 +01:00
Sandeep Somavarapu
f654e24f03 proper sign in flow for settings sync 2019-11-13 15:27:35 +01:00
Joao Moreno
65b57bcda2 remove optional argument from iconlabel 2019-11-13 15:25:39 +01:00
Joao Moreno
3440bc01c8 fixes #84658 2019-11-13 15:25:38 +01:00
Benjamin Pasero
4c5dd3bc93 debt - add more configuration related things from textfiles to files config service 2019-11-13 15:20:16 +01:00
Johannes Rieken
27eafea04a Merge pull request #84578 from microsoft/joh/outlineNav
Symbol navigation
2019-11-13 12:33:36 +01:00
Johannes Rieken
2580bacd65 show short highlight 2019-11-13 12:25:27 +01:00
Sandeep Somavarapu
0872b00378 Enable sign in only when sync is initialized 2019-11-13 12:17:13 +01:00
Sandeep Somavarapu
14513cc382 enable auth token service 2019-11-13 12:10:34 +01:00
Alexandru Dima
c6388baf2b Replace layer hinting using will-change: transform with transform: translate3d(0px, 0px, 0px) (#84214) 2019-11-13 12:04:43 +01:00
Johannes Rieken
bf4c91571a simpler navigation 2019-11-13 12:01:08 +01:00
Sandeep Somavarapu
2054549c99 Add isEntryVisible api to statusbar service 2019-11-13 11:49:24 +01:00