Commit Graph

789 Commits

Author SHA1 Message Date
Matt Bierner
4e8ef4cf4d Remove gating for inMemoryResourcePrefix
Some users are setting weird errors related to untitled TS files. In some of these cases (such as https://github.com/microsoft/TypeScript/issues/35091) we see a untitled file being sent to the tsserver without the `inMemoryResourcePrefix`.

I can't figure out how to get into this state but am removing the gating that *could* perhaps cause use not to set `inMemoryResourcePrefix`. This gating targets TS 2.7 or older, which telemetry shows very, very few users are still enabling in their workspaces
2019-11-14 00:17:57 -08:00
Johannes Rieken
27eafea04a Merge pull request #84578 from microsoft/joh/outlineNav
Symbol navigation
2019-11-13 12:33:36 +01:00
Matt Bierner
cf197953d7 Prefer using vscode.workspace.fs over node fs 2019-11-12 21:59:36 -08:00
Matt Bierner
0749b7aca8 Timebox the TSServer request used in the JS/TS task provider
Fixes #84278
2019-11-12 21:59:36 -08:00
Matt Bierner
1f3642a07d Add explicit type on experimental fixAll provider
For #84602
2019-11-12 14:28:43 -08:00
Matt Bierner
a170916295 Highlight a few other types in jsdoc comments
Fixes #84622
2019-11-12 13:31:09 -08:00
Greg Van Liew
8ae2921645 Nits in settings comments 2019-11-12 10:55:04 -08:00
Johannes Rieken
7e333135dd often set selection range for TS document symbols, #84576 2019-11-12 11:28:48 +01:00
Matt Bierner
2ec3bc4fd0 Removed undocumented setting usage 2019-11-11 16:12:52 -08:00
Matt Bierner
8904a3cbce 💄 2019-11-11 16:12:52 -08:00
Matt Bierner
6118d2713e Make sure synchronized buffers are reset when tsserver restarts 2019-11-11 16:12:52 -08:00
Matt Bierner
21fd94b70c Make sure buffer sync reset clears pending diagnostics 2019-11-08 14:47:06 -08:00
Matt Bierner
7218d47251 Make sure we don't try calling a cached getErr on a closed resources that are in the getErr queue 2019-11-08 14:47:06 -08:00
kieferrm
59ba1190b4 fix GDPR annotation 2019-11-08 22:36:55 +00:00
Alex Dima
c9a2de2d9c Improve integration test output on Windows (#84239) 2019-11-08 17:21:35 +01:00
Matt Bierner
fdeb9aa9b8 Use 'as const' instead of readonly class object 2019-11-07 20:31:32 -08:00
Matt Bierner
a8ad448cb0 Aggressively cancel code lens requests when the resource changes
For #84185
2019-11-07 18:47:39 -08:00
Matt Bierner
d83f121f6d Fix spelling 2019-11-07 07:57:04 -08:00
Matt Bierner
bea911842a Fix name and make sure tell VS Code about about specific code actions 2019-11-06 18:21:43 -08:00
Matt Bierner
5b63895862 Docment remaining known js/ts refactorings 2019-11-06 18:13:54 -08:00
Matt Bierner
26c4541c4a Add coalease helper function 2019-11-06 17:47:43 -08:00
Matt Bierner
692630172a Documenting more js/ts refactorings 2019-11-06 17:47:43 -08:00
Matt Bierner
42d53cf373 Document extract constant and extract type alias 2019-11-06 16:51:49 -08:00
Matt Bierner
c3983ca63b Document extract interface for js/ts
Also re-organizes the code action kinds fo better encapsulate mapping of TS kinds to VS Code kinds
2019-11-06 16:51:49 -08:00
Matt Bierner
2510769bf9 Updat codeActions contribtions schema based on https://github.com/microsoft/vscode/issues/82718#issuecomment-550468267
- Adds a description
- Remove schama
- Moves the language to the top level so we don't need to duplicate so much info for each code action
2019-11-06 16:51:49 -08:00
Matt Bierner
c8d64b13e5 Add code actions contributon point
For #82718
Fixes #52846

This adds a newly proposed codeActions contribution point. For details, see #82718

This change also makes the intellisense for the `editor.codeActionsOnSave` property dynamic by using the new contribution point
2019-11-06 10:13:59 -08:00
Andrii Dieiev
a188b905c6 Trigger completions on backticks in JS/TS (#80234) 2019-11-04 14:55:07 -08:00
Matt Bierner
c78edd8668 Pick up TS 3.7-rc 2019-11-04 08:49:47 -08:00
Johannes Rieken
073735c5e1 Merge branch 'master' into joh/willRename 2019-11-04 12:10:18 +01:00
Huáng Jùnliàng
c35b9ba236 add babel.config.json to validation (#83758) 2019-11-01 11:23:04 -07:00
Johannes Rieken
5a4e23fb31 update names 2019-11-01 17:03:56 +01:00
Johannes Rieken
36c3e8756c adjust API proposal to account for N files being created, moved, and deleted 2019-11-01 16:50:56 +01:00
Johannes Rieken
2d71cb4cdf adopt proposed API changes in TS land 2019-11-01 12:38:46 +01:00
Johannes Rieken
14e2178b7f fix #83762 2019-10-31 16:02:34 +01:00
Matt Bierner
c80fb1b771 Be more resilient when checking if we have an opened jts/ts buffer
Fixes #83338

`TextDocument` lifetime may not match that of the the user facing editors. However the JS/TS extension was assuming that it did. Introduce a `ensureHasBuffer` function that can open a buffer if vscode knows about a textdocument but no `onDidOpenTextDocument` has been fired for it yet
2019-10-29 14:26:20 -07:00
Benjamin Pasero
ca22de4b17 debt - bump node.d.ts dependency in extensions to 12.x (part of #82514) 2019-10-28 08:11:47 +01:00
Matt Bierner
ba4a504ffe Use a case-insensitive map for store pending buffer operations
Fixes #82634
2019-10-24 18:12:21 -07:00
Matt Bierner
951f891b23 Extend disposable 2019-10-24 16:58:12 -07:00
Matt Bierner
73fbb9da18 Use proper map 2019-10-24 16:58:12 -07:00
Matt Bierner
b66a2571fd Use Disposable 2019-10-24 16:58:12 -07:00
Matt Bierner
73b3fc4348 Support performing a js/ts workspace symbol search when focused on the left side of a git view
Fixes #75107
2019-10-24 14:55:54 -07:00
Matt Bierner
c4868f4cc8 Use includes 2019-10-24 14:55:54 -07:00
Matt Bierner
520fafc07b Use includes 2019-10-24 14:55:54 -07:00
Matt Bierner
8c0e291789 Make message for update imports better match vscode's message
For #76268
2019-10-23 18:04:22 -07:00
Matt Bierner
639ccb016f Batch renames for js/ts
Fixes #76268
2019-10-23 17:57:41 -07:00
Matt Bierner
e4478d363d Batch renames 2019-10-23 17:57:41 -07:00
Matt Bierner
6290c3ff0b Use file name to determine if we are in a ts file or not
Using a textdocument to know if we are in a typescript vs a javascript document is ideal but comes at a performance cost. In most cases we can use the file name safely
2019-10-23 17:57:40 -07:00
Matt Bierner
645a178353 Use destructured paramters 2019-10-23 17:57:40 -07:00
Matt Bierner
01f429e8c9 Don't show progress indicator when we know for sure we are not doing a js/ts rename 2019-10-23 17:57:40 -07:00
Matt Bierner
46d2224d8b Remove gating for TS versions < 2.4
Telemetry shows that these old TS versions have very low usage (in the tens across the many, many js/ts users). Given this, it now makes sense to remove the extra gating/checks required to support these old versions
2019-10-23 17:57:40 -07:00