JS/TS can return a lot of completions. I noticed that just parsing this was taking a bit of time, so I tried to reduce the message size with the following changes:
- Inline the command properties on `ISuggestDataDto`
- Drop the `title` and `tooltip` from the command since we don't use these
- Shorten the delegate command name
- If using an `$ident` command, don't send over the command arguments since the arguments are always `[$ident]`
- Make commit characters a string instead of an array
Here's an example of a dto for a completion item before:
```
{"x":[2,0],"a":"$","b":4,"e":"15","i":0,"k":[".",",",";","("],"m":{"$ident":867,"id":"_vscode_delegate_cmd_l9g7z48t","title":"","arguments":[867]}}
```
And after:
```
{"x":[1,0],"a":"$","b":4,"e":"15","i":0,"k":".,;(","n":11,"o":"__vsl9g7vfno"}
```
For global completions in a JS/TS file, this makes the completion response a little over 40% smaller.
* Add api to get all mime typed data for an output item
For #163973
This adds an `allOutputItems` to the output item type. This is a list objects with a `mime` property and a `getItem` function. `getItem` returns a `Promise` that resolves to the item or to`undefined` if the item can not be resolved
* Delete _requests on resolve
* Prefix property with _ to mark as experimental
* Remove ill-advised tweak
* Shift cursor back by 1px but leave text in place
* Always use `box-sizing: border-box`
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Put all win and macOS builds on their own machine, since they take a minute.
Build the two GNU ARM builds together on an x64 machine, since they're
faster and can cross-compile in ~5 minutes.
This makes the CompileCLI step take a little less time than the VS Code
"Compile" step.
For https://github.com/microsoft/vscode-internalbacklog/issues/3209
We still need to activate it for every workspace, but since Daniel's
improvements to environment variable application a few months ago, using
onStartupFinished should be pretty safe and seamless.
This ensures flags like `--prof` are passed down to the vs code process so
we can profile everything.
To test this:
1. run `./lib/node --prof .`
2. in another terminal, run `ps -ejww`
You should see `--prof` next to every vs code process.
* Initial horizontal scroll
* Use columns as unit in horizontal scrolling shortcuts
* Horizontal scroll value 2, remove shortcuts
* Unify Horizontal, Vertical scroll Directions and Units, determine the method
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Matt Bierner
Raymond Zhao
Daniel Imms
Peng Lyu
Hugh Lilly
Andrea Mah
Alexandru Dima
SteVen Batten
Connor Peet
Martin Aeschlimann
Logan Ramos
Leonardo Montini
Jacek Kopecký
Don Jayamanne
yamachi
Johannes
Joe Previte
Henning Dieterichs
Sandeep Somavarapu
Omar Brikaa
Henning Dieterichs
易良
Ladislau Szomoru