Commit Graph

147932 Commits

Author SHA1 Message Date
Sandeep Somavarapu
526c24b569 chat: refactor model picker delegate and improve picker UX (#300436)
* refactor: update model management methods to use grouped model picker

* refactor: remove showManageModelsAction parameter from model picker functions

* refactor: streamline model picker item construction and improve readability

* refactor: reorganize model picker logic to support grouped model selection

* refactor: disable showManageModelsAction in NewChatWidget and simplify useGroupedModelPicker logic

* fix: increase viewport max height calculation in ActionList class

* feat: add hover position support to model picker and related components
2026-03-10 10:00:17 -04:00
Alex Ross
54b762dd84 Rerun the failed API version check (#300443)
* Rerun the failed API version check

* CCR comments
2026-03-10 14:59:01 +01:00
Benjamin Christopher Simmonds
c8a2659cb7 Merge pull request #300444 from microsoft/benibenj/proposed-lynx
ci and PR review comments in agent feedback
2026-03-10 14:58:46 +01:00
BeniBenj
7cfab2369d revert copilot suggestion 2026-03-10 14:31:04 +01:00
Benjamin Christopher Simmonds
40e2da7a67 Update src/vs/sessions/contrib/codeReview/browser/codeReviewService.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-10 14:20:08 +01:00
BeniBenj
f316d9db7e ci and PR review comments in agent feedback 2026-03-10 14:11:45 +01:00
Ladislau Szomoru
83e4102717 Sessions - tweak toolbar actions (#300434) 2026-03-10 13:51:18 +01:00
Alex Ross
cba3c7aac7 Add API proposal version check (#300392)
* Add API proposal version check

* CCR feedback

* Test with version bump

* Comment improvements

* Undo test version bump

* More comment improvement
2026-03-10 12:52:52 +01:00
Ladislau Szomoru
35e0427ee2 Sessions - expose session base branch information (#300415)
* Sessions - expose session base branch information

* Pull request feedback
2026-03-10 11:18:21 +00:00
Ladislau Szomoru
950ab0704b Git - adopt the new package to use copy-on-write for the worktree include files (#299583)
* Git - adopt the new package to use copy-on-write for the worktree include files

---------

Co-authored-by: deepak1556 <hop2deep@gmail.com>
2026-03-10 11:51:57 +01:00
Sandeep Somavarapu
11246017b6 Revert "Debug Panel: oTel data source support and Import/export (#299256)" (#300381)
This reverts commit 5c84259481.
2026-03-10 10:09:40 +00:00
Johannes Rieken
5a356d228e Enhance quick suggestions with inline completions (#300371)
* Enhance quick suggestions behavior with inline completions: allow triggering when inline provider returns no results

* Improve inline completions handling: suppress suggestions when inline completions are active

* CCR
2026-03-10 08:25:06 +00:00
Connor Peet
261701ae14 mcp: move to askquestions for elicitations (#300294)
* mcp: move to askquestions for elicitations

This reuses the askquestions UI to make elicitation requests. This is a
nicer UX than the quickpick flow.

It adds data validation to askquestions, as required by MCP, and also
switches the answer types from `unknown` to `IChatQuestionAnswerValue`
which is a bit more predictable to manage.

* fic tests

* pr comments
2026-03-10 19:03:12 +11:00
Matt Bierner
f2b91b9a2f Merge pull request #300353 from mjbvz/dev/mjbvz/romantic-guineafowl
Keep `.md` file extension as default extension
2026-03-10 01:02:58 -07:00
Matt Bierner
e9e3431387 Merge pull request #300352 from mjbvz/dev/mjbvz/disturbed-mule
Reduce `any` usage in a few more tests
2026-03-10 01:02:50 -07:00
Matt Bierner
2ba34ab4c7 Merge pull request #300343 from mjbvz/dev/mjbvz/spicy-wildebeest
Add deprecation message on registerChatSessionItemProvider
2026-03-10 01:02:03 -07:00
Matt Bierner
abe7e4bd49 Merge pull request #300288 from mjbvz/dev/mjbvz/daily-dormouse
Move `registerChatModelChangeListeners` onto chat service
2026-03-10 01:01:41 -07:00
Paul
89508b298e Optimize discovery process (#300317) 2026-03-10 07:09:19 +00:00
Matt Bierner
f2bd744896 Keep .md file extension as default extension
Fixes #300239
2026-03-09 23:19:55 -07:00
Matt Bierner
9ac9ae8a10 Reduce any usage in a few more tests
For #269213
2026-03-09 23:17:36 -07:00
Matt Bierner
a303f977d3 Don't use 'default' 2026-03-09 22:51:06 -07:00
Matt Bierner
b44b56dfa8 Add deprecation message on registerChatSessionItemProvider
Let's see how many callers are out there for this deprecated api
2026-03-09 22:43:39 -07:00
Paul
e2db4495b3 Improve slash command render (#300287) 2026-03-09 22:25:06 -07:00
Matt Bierner
018f88abe8 Remove unused import 2026-03-09 22:24:34 -07:00
Jamie Cansdale
eb7e1c7cb8 fix: chunk multiline PTY writes on macOS to avoid 1024-byte buffer corruption (#298993)
* test: add multiline PTY write test for macOS 1024-byte buffer bug

Adds a test that sends multiline commands of varying sizes (10, 20, 30 lines)
through TerminalProcess.input() and verifies the data arrives intact at the
shell. On macOS, multiline commands exceeding ~1024 bytes corrupt due to PTY
canonical-mode input buffer backpressure.

Reproduces: #296955

* fix: chunk multiline PTY writes on macOS to avoid 1024-byte buffer corruption

macOS PTY has a ~1024-byte canonical-mode input buffer. When multiline data
(containing CR characters) exceeds this threshold, the shell's line editor
echoes characters back, creating backpressure that corrupts the write.

Write multiline PTY input in 512-byte chunks with 5ms pauses between them
to allow the echo buffer to drain. Non-macOS platforms and single-line
writes are unaffected.

Fixes #296955

* test: increase large multiline test to 500 lines (~32KB)
2026-03-09 21:05:33 -07:00
Osvaldo Ortega
0f2bee18cd Merge pull request #300297 from microsoft/copilot/impressed-tiger
Sessions: Add "Group by Repository" toggle for sessions list
2026-03-09 19:03:13 -07:00
Vijay Upadya
5c84259481 Debug Panel: oTel data source support and Import/export (#299256)
* otel data source and Import/export

* Handle chat customization events in import/export

* PR feedback updates

* Fix reopen issue

* Simplify and pass core events for export

* Perf optimizations and label changes

* add session title to export/import
2026-03-09 18:44:34 -07:00
Osvaldo Ortega
cf9e1b99b8 perf: use update() instead of refresh() when toggling grouping
refresh() re-resolves all sessions from providers (network calls).
update() just re-renders the tree with existing data, which is all
that is needed when changing the grouping mode.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-09 18:32:46 -07:00
Osvaldo Ortega
862667adee fix: avoid type assertion for repo section IDs
Add AgentSessionSection.Repository enum value and use it for all repo
group sections. Differentiate repo sections via the identity provider
which now includes the label in the section ID.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-09 18:29:40 -07:00
Osvaldo Ortega
bb069eac1e fix: revert type widening of AgentSessionSection
Keep IAgentSessionSection.section as AgentSessionSection (not string).
Revert all changes to agentSessionsControl.ts and agentSessionsModel.ts.
Use type assertion for dynamic repo section IDs in the viewer instead.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-09 18:27:03 -07:00
Osvaldo Ortega
164d0f59f5 refactor: move grouping state out of AgentSessionsFilter
The filter should work the same regardless of grouping mode. Moved all
grouping state management (storage, context key, toggle) to the sessions
view pane, which owns it. The filter just receives the current grouping
via its existing groupResults option callback.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-09 18:23:37 -07:00
Osvaldo Ortega
0c354be564 fix: use single static grouping storage key
Simplify GROUPING_STORAGE_KEY to a static constant instead of per-instance
scoped key. The grouping override is guarded by supportsGroupingOverride
(only enabled when options.groupResults is configured), which is sufficient
to prevent unintended interference.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-09 18:19:22 -07:00
Paul
21d682f185 Allow local customizations (#300298) 2026-03-10 01:00:21 +00:00
Henning Dieterichs
74c765017e Disable screenshots until time out bug is fixed (#300293) 2026-03-10 00:52:12 +00:00
Justin Chen
7c24905755 bypass approvals and toolbar in cli (#300228)
* bypass approvals and toolbar in cli

* new picker in new chat state for sessions
2026-03-10 00:49:02 +00:00
Josh Spicer
975cdcf8fe policy: DeprecatedEditModeHidden (#300290)
* Add 'DeprecatedEditModeHidden' policy

* Add 'add-policy' skill
2026-03-10 00:38:04 +00:00
Osvaldo Ortega
4536525e00 Merge pull request #300282 from microsoft/copilot/prior-parrotfish
Fix file icon rendering in sessions context attachments
2026-03-09 17:30:42 -07:00
Osvaldo Ortega
35d87bb110 fix: address PR review feedback
- Scope grouping storage key per filter instance (filterMenuId) to avoid
  cross-instance interference; only enable grouping override when a default
  grouping is configured
- Add isStoringGrouping guard to prevent duplicate onDidChange events
  when setGrouping writes to storage
- Use full owner/repo as section ID for unique grouping; display short
  repo name as section label

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-09 17:28:40 -07:00
Kyle Cutler
944b9d37f7 Normalize URLs in browser tool calls (#299891) 2026-03-09 17:10:20 -07:00
Osvaldo Ortega
0da24326a1 feat: implement grouping actions for sessions by repository and date 2026-03-09 17:00:11 -07:00
Osvaldo Ortega
d438554123 feat: enhance repository name extraction in AgentSessionsDataSource 2026-03-09 16:54:38 -07:00
Osvaldo Ortega
3b84d87a3b feat: add repository name extraction and grouping toggle for agent sessions 2026-03-09 16:50:00 -07:00
Benjamin Christopher Simmonds
01669c2233 Agent feedback improvements (#300202)
* agent feedback improvements

* fix test
2026-03-09 23:47:31 +00:00
Osvaldo Ortega
f8c6fd31e9 feat: enhance session grouping by adding archived sessions and repository name extraction 2026-03-09 16:39:45 -07:00
Osvaldo Ortega
fed1cfdff2 Use ResourceLabels for attachment pill icons
Replace plain spans with getIconClasses() with proper ResourceLabels
and label.setFile() for attachment pills, matching how core chat
attachments render file icons via the monaco-icon-label system.

Add CSS for .monaco-icon-label inside pills to ensure correct sizing
and layout of file icon theme ::before pseudo-elements.

Keep getIconClasses for QuickPick file items where the QuickPick's
internal IconLabel handles rendering.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-09 16:37:17 -07:00
Connor Peet
c3788b7bbe plugins/mcp: allow disabling/enabling similar to extensions (#300273)
* plugins/mcp: allow disabling/enabling similar to extensions

Introduces an EnablementModel which is used to allow users to enable and disable both plugins and MCP at both a workspace and global level. Accessible on the mcp/plugins editors, inline within the marketplace view, and in the chat customizations view.

* comments
2026-03-09 23:36:39 +00:00
Matt Bierner
c02f8e3766 Move registerChatModelChangeListeners onto chat service
No sure what this method was doing on the sessions service. Really should be deleted entirely but moving to a better home on the chat service as a first step
2026-03-09 16:15:32 -07:00
Matt Bierner
c3c17667b9 Merge pull request #300266 from mjbvz/dev/mjbvz/characteristic-salamander
Reduce size of `IChatSessionContext`
2026-03-09 15:55:03 -07:00
Josh Spicer
783a493479 Merging copilot/popular-wallaby to main (#300265)
Exclude Claude hook file paths from sessions app

Disable the Claude-specific hook file locations (.claude/settings.json,
.claude/settings.local.json, ~/.claude/settings.json) in the sessions
window by setting them to false in the chat.hookFilesLocations config
default. This uses the existing PromptsConfig mechanism for disabling
individual default paths.

Fixes microsoft/vscode#300138

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-09 22:53:16 +00:00
Osvaldo Ortega
ec99a8f391 feat: add repository grouping option for agent sessions 2026-03-09 15:44:37 -07:00