Johannes Rieken
63c8b91c18
honor window.title/titleSeparator customizations in command center ( #161317 )
...
fixes https://github.com/microsoft/vscode/issues/150789
2022-09-20 15:44:05 +02:00
Johannes Rieken
c1b80f6402
Disable merge-conflict commands for 3wm-editor ( #161304 )
...
fixes https://github.com/microsoft/vscode/issues/159156
2022-09-20 13:50:21 +02:00
Jean Pierre
ba7d2622c6
Fix error while executing contributed menu command in ports/item/context ( #161295 )
2022-09-20 13:23:11 +02:00
Rob Lourens
0e333cd799
Convert NotebookCellStatusBarItem test from integration test to unit test ( #161274 )
...
Fix #157828
2022-09-20 09:55:58 +02:00
Benjamin Pasero
ca745eea7c
tests - do not retryCountOnTaskFailure playwright ( #161299 )
...
* tests - do not `retryCountOnTaskFailure` playwright
* compile
2022-09-20 09:55:06 +02:00
Rob Lourens
a829fbb91c
Revert hiding some notebook toolbars ( #161136 )
...
* Revert "tweak hiddenItemStrategy for run toolbar"
This reverts commit 7c5634e0aa .
* Revert "tweak delete cell toolbar"
This reverts commit 17079b458d .
* Revert "use `WorkbenchToolBar` in codeCellRunToolbar"
This reverts commit 76d65d3772 .
* Revert "use `MenuWorkbenchToolBar` in BetweenCellToolBar"
This reverts commit 517448a4a7 .
* Revert "Use `MenuWorkbenchToolBar` in interactive editor"
This reverts commit 51fb316ed7 .
2022-09-19 18:15:10 -07:00
Rob Lourens
acffac0ec1
Show execution order when it's present, and no kernel is selected ( #161285 )
...
Fix #161283
2022-09-19 16:43:49 -07:00
Peng Lyu
df78782346
Allow grouping of kernel source commands ( #161281 )
2022-09-19 16:07:22 -07:00
Joyce Er
f3fbdc328f
Surface machine name in edit session debug view ( #161279 )
2022-09-19 15:55:23 -07:00
Matt Bierner
f93071d65c
Fix duplicate element in notebook ( #161276 )
2022-09-19 15:36:43 -07:00
Connor Peet
831be46050
testing: fix error when updating test items without URIs ( #161272 )
...
TS allowed me to assign `(u: URI) => string` to `(u: URI | undefined) => string`
which it seems like should not be valid 🤔
Fixes #160318
2022-09-19 13:15:00 -07:00
Benjamin Simmonds
44c1e05eb7
Show view always but collapsed if no updates ( #161251 )
2022-09-19 21:57:44 +02:00
Matt Bierner
ee6c099a5c
Mark a few properties as readonly in proposal ( #161262 )
...
- `checkboxState` can only be updated as an entire object, you can't set individual properties
- Event args should always be immutable
2022-09-19 11:27:01 -07:00
Matt Bierner
bc18cf08e8
Try to unify notebook rendering ( #161261 )
...
There are currently distinct call path for rendering outputs and markup. This change unifies most of these so renderers are invoked in a more consistent way
2022-09-19 11:08:22 -07:00
Sandeep Somavarapu
35c7ee9d02
Support log output channels for extensions ( #161249 )
...
* introduce log api in extension context
* separate registering output vs log channel
* Separate extension log channels in show logs command
* add logging error to embedder logger
* show extension log in the extension editor
* configure log level per extension
* change the order of log entries
* introduce logger
* align with output chanel
* revert changes
* fixes
2022-09-19 09:03:41 -07:00
Alex Ross
82431003f3
Finalize view size proposal ( #161244 )
...
Fixes #122283
2022-09-19 08:35:53 -07:00
Raymond Zhao
0e7735ed70
Enable WCO on OSS in main process ( #161158 )
...
Fixes #161143
2022-09-19 07:48:16 -07:00
Benjamin Pasero
65b6256102
tabs - only update scrollLeft when scrollLeftChanged ( #34745 ) ( #161240 )
2022-09-19 07:15:44 -07:00
Alex Ross
78b7dd8ffd
Make some services delayed ( #161236 )
2022-09-19 15:23:18 +02:00
Johannes Rieken
f2f591639e
Merge pull request #161234 from microsoft/joh/menu-config
...
joh/menu config
2022-09-19 15:00:00 +02:00
Alex Ross
cb1ebb2cd8
Apply recent learnings about array filter ( #161233 )
2022-09-19 05:54:16 -07:00
Johannes
488eb5d8e7
add "Reset Menu" to editor and view/pane menus
2022-09-19 14:38:54 +02:00
Johannes
263ad880ba
add option for an inplace "Reset Menu" command
2022-09-19 14:27:29 +02:00
Johannes
0e0b5991ed
experiement with subtle config-mode animation
2022-09-19 14:15:05 +02:00
Johannes
70f629f997
support to hide/show submenus too
2022-09-19 13:46:12 +02:00
Alex Ross
bf9d94c014
Cannot read properties of null (reading 'getModel') ( #161229 )
...
Fixes #161058
2022-09-19 04:43:17 -07:00
Alex Ross
0b869de3a2
Cannot read properties of undefined (reading 'commentThreads') ( #161227 )
...
Fixes #161057
2022-09-19 13:28:24 +02:00
Sandeep Somavarapu
d0c462b875
Profiles: fix setting install time in metadata ( #161222 )
2022-09-19 03:10:59 -07:00
Matt Bierner
3f92eb60d8
Better handle markup rendering errors in noetebooks ( #161153 )
...
Better handle markup rendering errors
Show an error to users if rendering of markup items fail. Previously when a renderer fails to load or render, we would not show any user facing errors (and would sometimes prevent the entire notebook from loading)
2022-09-19 07:49:02 +02:00
Sandeep Somavarapu
2ae5bc6980
support syncing profiles ( #161208 )
...
- sync profiles while turning on
- simplify turn on experience
- improve handling conflicts
2022-09-19 07:17:20 +02:00
Matt Bierner
d03f015931
Clean up structure of markdown extension ( #161148 )
...
- Move things related to the client under `client`
- Remove extra abstractions that are no longer used
- Add MdLanguageClient type
2022-09-19 07:16:45 +02:00
Matt Bierner
f4bf1f30a2
Skip ul and ol when highlighting selected markdown element ( #161139 )
...
Fixes #155552
For lists, the outer ul/ol always has the same source line as the first element in the list. We should prefer using the first element in the list when highlighting the active line
This also fixes a bug where scroll sync would stop working if you added lines to the doc. This was caused by `lineCount` getting out of sync as the document is being updated. I've removed this state and made the reveal logic more robust instead
2022-09-19 07:16:06 +02:00
Alexandru Dima
bd782eb059
Adopt latest loader ( #161129 )
2022-09-16 21:13:20 -07:00
Peng Lyu
b753d3303f
Avoid tweaking command arguments when they are already provided by extensions ( #161154 )
2022-09-16 20:54:53 -04:00
Matt Bierner
a10bdfb49b
Allow underscores in rendered md headers ( #161149 )
...
Follow up from https://github.com/microsoft/vscode-markdown-languageservice/pull/49
2022-09-16 20:52:50 -04:00
Matt Bierner
4c9c3f628d
Pick up latest markdown language service ( #161142 )
2022-09-16 20:52:16 -04:00
Benjamin Simmonds
42e854463c
checkbox api event naming change ( #161131 )
2022-09-16 14:53:07 -07:00
Peng Lyu
6e8bc02be4
Cell attachment cleanup tool improvement in diff editor ( #161132 )
...
* Move attachment out of custom metadata, prep for attachment clean up in diff editor
* recover attachments from dirty notebook document
* Allow metadata to be restored when content changed/reverted in nb diff editor
2022-09-16 14:12:53 -07:00
Matt Bierner
2d7655cb16
Add Refactor.move and Refactor.inline to code action widget ( #161134 )
...
Fixes #158515
Also aligns the icon to be more consistent with how they are used:
- Surround with snippets use snippet icon
- All refactorings use the wrench icon
- Remove custom color which was added to some refactorings but not others
2022-09-16 13:51:00 -07:00
Matt Bierner
6c3e1f0ff1
Pick up latest notebook renderer API typings ( #161135 )
2022-09-16 13:09:20 -07:00
Matt Bierner
687712b871
Pick up latest TS nightly for building VS Code ( #161127 )
2022-09-16 10:37:58 -07:00
Matt Bierner
7c3ea7ac06
Pick up TS 4.8.3 ( #161126 )
...
Picks up latest TS stable build
2022-09-16 10:22:13 -07:00
Matt Bierner
b12b061b7e
Throw when invalid parameter hint label is passed in ( #161125 )
...
Fixes #161055
I'm fairly sure that our code is correct if everything has the expected types. However extensions may be passing us invalid data so that the types are runtime don't match what we expect
2022-09-16 10:16:40 -07:00
Rob Lourens
f05eb4af4f
Clean up duplicate menu registration in cell run toolbar ( #161124 )
2022-09-16 10:07:22 -07:00
Sandeep Somavarapu
c126d947f6
Introduce Conflicts view ( #161116 )
...
* Introduice Conflicts view
- supports showing conflicts across profiles
* fix tests
2022-09-16 19:04:13 +02:00
Aaron Munger
236e476f01
Merge pull request #158421 from amunger/undoIWCellDelete
...
enabled core cell delete for IW and undo operations
2022-09-16 09:35:44 -07:00
Benjamin Pasero
84c46b71a5
Revert "Use esbuild to bundle some CommonJS main files ( #160957 )" ( #161118 )
...
This reverts commit 2179e52fb9 .
2022-09-16 09:31:44 -07:00
Johannes Rieken
107f6cade5
Merge pull request #161098 from microsoft/joh/notebook-toolbar
...
joh/notebook toolbar
2022-09-16 18:22:35 +02:00
Robo
158949651c
chore: update distro ( #161117 )
2022-09-16 09:01:42 -07:00
Alexandru Dima
fe71b38f5d
Update service registration ( #161115 )
...
Update service registration (for #159178 )
2022-09-16 08:53:20 -07:00