* Initial plan
* Fix Save As to preserve indentation and EOL settings
When using Save As, the target file now preserves the source file's:
- Indentation settings (insertSpaces, tabSize, indentSize)
- End-of-line sequence (LF vs CRLF)
This ensures that user preferences like using tabs instead of spaces
and LF instead of CRLF are maintained when saving to a new file.
Added test to verify the fix works correctly.
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
* Use EndOfLineSequence enum constant instead of magic number
Improved code readability by using EndOfLineSequence.LF instead of 0.
This addresses code review feedback.
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
* Improve test readability by extracting target options
Extract targetOptions to a variable to avoid repetitive getOptions() calls.
This addresses code review feedback.
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
* undo test
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
- Make IChatRequestVariableEntry readonly in the type signatures where
variables are passed/stored to reduce aliasing issues
- Cache the hash result for variables in ChatRequestViewModel.dataId to
avoid recalculating the same hash repeatedly. This improves performance
when the same variables array is queried multiple times.
Fixes https://github.com/microsoft/vscode/issues/286450
(Commit message generated by Copilot)
rm unused import
- Adopt rename viewport->containerDimensions
- Add some code to fix the postMessage.source validation issues
- Fix apps not restoring when chat is remounted
Resolves#283954.
1. Update workbench.action.chat.import to non-interactively accept filepath for import.
2. Accept `target` for location chat will be revived to.
* chat: add confirmation not needed reason to tool invocations
Adds a 'confirmationNotNeededReason' field to tool confirmation messages
to display why a tool didn't require user confirmation. This makes fetch
results more consistent with other tool calls by providing transparency
about auto-approval decisions.
- Adds confirmationNotNeededReason property to IToolConfirmationMessages
- Populates reason in FetchWebPageTool when URL is mentioned in prompt
- Updates ChatToolInvocation to include reason in confirmed state
- Extracts tool part utilities into shared module for reuse
- Improves UI consistency with confirmation status display
Fixes https://github.com/microsoft/vscode/issues/282238
(Commit message generated by Copilot)
* Update src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatCollapsibleContentPart.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
When setContents is called with modified agent edits, we need to ensure
that if the file was already in an accepted state, we restore that state
after applying the edits. This prevents files from unexpectedly becoming
modified again after edit acceptance.
- Check if entry was in Modified state before applying agent edits
- Restore accepted state if the file wasn't already modified
- Ensures files that were explicitly accepted remain in accepted state
Fixes https://github.com/microsoft/vscode/issues/285733
(Commit message generated by Copilot)
* Fix regression package.json task fail to re-run
* Update src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* revert copilot changes
* check for 1 or 127 for command not found
* Check to see if exitCode is none zero when showing warning
* Update to only watch for 1 or 127
* use !success || (success.exitCode !== undefined && success.exitCode !== 0)
* Use typeof success.exitCode number
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Moves the quickTree.hide() call inside the conditional block to ensure it
only hides after the onDidOpen callback has been invoked for 'manage' items.
This prevents the tree from closing prematurely before the manage action
has completed.
Fixes https://github.com/microsoft/vscode/issues/275102
(Commit message generated by Copilot)
