Joao Moreno
6d31c16989
💄
2018-12-20 12:37:04 +01:00
Joao Moreno
cdb8a86fd0
git ignore: save after apply edit
2018-12-20 11:33:01 +01:00
Alex Ross
5adc152eca
Strict null check for terminalTaskSystem and processTaskSystem
...
Part of #63453
2018-12-20 11:11:09 +01:00
Alex Ross
c11b671593
Merge branch 'master' of https://github.com/Microsoft/vscode
2018-12-20 11:10:34 +01:00
Sandeep Somavarapu
ce2987b41e
Merge pull request #65453 from gangachris/strict-null-check
...
Enable strict null check for ./vs/base/test/common/history.test.ts
2018-12-20 11:09:21 +01:00
Alex Ross
da915f8c07
Merge branch 'master' of https://github.com/Microsoft/vscode
2018-12-20 11:08:35 +01:00
Benjamin Pasero
7a97cee1d3
views - introduce event for visibility change and adopt for labels
2018-12-20 11:03:16 +01:00
Benjamin Pasero
c0c15d3f90
labels - enable visibility again
2018-12-20 11:03:16 +01:00
Chris Ganga
d457e508b9
enable strict null check ( #65458 )
2018-12-20 10:59:20 +01:00
Joao Moreno
349b0d454e
fix git.openDiffOnClick scope
2018-12-20 10:17:26 +01:00
Joao Moreno
492e205147
Merge remote-tracking branch 'origin/master'
2018-12-20 10:08:37 +01:00
Joao Moreno
71fbf3dbe0
cleanup snap update service
2018-12-20 10:08:21 +01:00
Johannes Rieken
d3e1055490
no more special listener thresholds, #63655
2018-12-20 10:06:50 +01:00
Joao Moreno
9069fdcfc6
Merge commit 'refs/pull/64392/head' of github.com:Microsoft/vscode into pr/64392
2018-12-20 09:59:18 +01:00
Benjamin Pasero
2803a8655c
labels - disable visibility for now
2018-12-20 09:49:57 +01:00
gangachris
bec9357777
enable strict null check
2018-12-20 11:37:39 +03:00
Alex Ross
ffab77a9f8
Strict null check for some tasks files
...
Part of #63453
2018-12-20 09:28:57 +01:00
Christof Marti
6bbf94c2f1
Remove aeschli
2018-12-20 09:07:14 +01:00
Benjamin Pasero
4149fc4e53
💄
2018-12-20 08:45:24 +01:00
Matt Bierner
5a2363c242
Fix some simple strict null errors in snippet
2018-12-19 22:50:23 -08:00
Matt Bierner
4e45bc2e49
Fix simple strict null errors in window.ts
2018-12-19 22:40:50 -08:00
Matt Bierner
1123caa5cc
Strict null check feedback
2018-12-19 22:32:52 -08:00
Rob Lourens
f903e6d226
Clean up unused settings editor toolbar
2018-12-19 22:12:18 -08:00
Matt Bierner
18d2ff160c
Fix strict null type errors in tests
2018-12-19 22:10:55 -08:00
Matt Bierner
4743190f77
Sort strict null check file
2018-12-19 22:00:51 -08:00
Matt Bierner
d2b050911c
Fixed strict null check in test
2018-12-19 21:58:47 -08:00
Chris Ganga
11b943278a
enable strict null check ( #65444 )
2018-12-19 21:54:24 -08:00
Oleg Voloshin
1da710b9c5
Enable strict null checking for workspaceStats test ( #65429 )
2018-12-19 21:53:08 -08:00
Ashwin Ramaswami
8ca7829768
Strict null checks for windowsKeyboardMapper.test.ts ( #65423 )
2018-12-19 21:52:54 -08:00
Kermit Xuan
48bd6f8b4e
Enable strict null checking for String test ( #65449 )
2018-12-19 21:52:05 -08:00
Chris Ganga
11bbd0569b
enable strict null check for src/vs/base/test/common/async.test.ts ( #65442 )
2018-12-19 21:51:33 -08:00
Matt Bierner
76182e637b
Fix error where cancelled paramter hint request would still count as a retrigger
2018-12-19 21:43:12 -08:00
Matt Bierner
cf9e62d373
Merge update and cancel events to a single change event
2018-12-19 20:37:25 -08:00
Matt Bierner
5e2ec87c62
Don't double fire cancel
2018-12-19 20:32:36 -08:00
Matt Bierner
7854596caf
Use constants for states
2018-12-19 20:31:39 -08:00
Matt Bierner
1310ea6eff
Fix import path casing
2018-12-19 19:26:38 -08:00
Matt Bierner
25cbe685bc
Fix null check
2018-12-19 19:07:38 -08:00
Matt Bierner
48cc02be6e
Extract setIgnoreMenuShortcuts
2018-12-19 18:34:03 -08:00
Matt Bierner
3cdcfa8574
Prevent currentSignature and activeSignature from getting out of state
...
Use modes.SignatureHelp as source of truth for activeSignature
2018-12-19 18:05:49 -08:00
Matt Bierner
6b39891d73
Use less state in parameter hints widget
...
Use the model to track state and active parameter instead of tracking this in the widget itself. This enforces a cleaner boundary between model and view
2018-12-19 17:53:35 -08:00
Matt Bierner
c9735f865c
Use union type to track state
...
This allows us to store additional data on the state, such as the active parameter
2018-12-19 17:36:48 -08:00
Matt Bierner
054eb85bd6
Remove unused triggerCharactersListeners field
2018-12-19 17:23:44 -08:00
Matt Bierner
574e06eb4b
Use a single state value to track parameter hint state
...
The parameter hints model can only be in a single state at a time. Use a single state variable to better track this
2018-12-19 17:21:48 -08:00
Matt Bierner
6422adaffe
Remove redundant type annotations for generic emitter properties
...
Code like:
```
private readonly _onDidEncounterLanguage: Emitter<LanguageId> = new Emitter<LanguageId>();
```
Does not need to repeat the `Emitter<LanguageId>` type annotation
2018-12-19 17:10:39 -08:00
Matt Bierner
60e788cda1
Extract paramterHintsModel to own file
2018-12-19 14:57:37 -08:00
Matt Bierner
5f40bbf67f
Use shorthand instead of extra nesting
2018-12-19 14:51:00 -08:00
Matt Bierner
ac812433df
Remove not null assertions
2018-12-19 14:48:59 -08:00
Matt Bierner
dbeaaa6890
Remove commented out code
2018-12-19 14:42:54 -08:00
Matt Bierner
8a58c3e7a6
Try to disable menu keyboard shortcuts on macos when executing command inside of webview
...
Fixes #64724
Should prevent double dispatch of keyboard events in most cases
2018-12-19 14:20:13 -08:00
Matt Bierner
23508cf1a0
Update markdown dependencies
2018-12-19 13:40:54 -08:00
