Commit Graph

82461 Commits

Author SHA1 Message Date
Matt Bierner 6ee883bfa3 Split href before decoding instead of after
Fixes #123228

This fixes the case where `#` appears in the path
2021-05-21 14:49:46 -07:00
rebornix 6af49913c2 title for notebook label in notebook toolbar 2021-05-21 14:47:53 -07:00
Matt Bierner 77ff6eb03b Add image specific link normalizer (#124400) 2021-05-21 14:42:50 -07:00
Matt Bierner e9b8c12915 Add types 2021-05-21 14:36:19 -07:00
rebornix a03daaf850 Merge branch 'notebook/dev' into main 2021-05-21 14:13:43 -07:00
rebornix 4ba2760274 fix #119214. 2021-05-21 14:12:11 -07:00
rebornix 8afcdfaad8 extract complex options parsing. 2021-05-21 13:51:41 -07:00
Connor Peet 9996e32bc9 testing: improvements when running a previously un-run test 2021-05-21 13:47:00 -07:00
rebornix 6507d05310 freeze layout config. 2021-05-21 13:45:13 -07:00
rebornix 6cda8d2373 extract configuration update 2021-05-21 13:43:51 -07:00
Alexandru Dima f38f3bb8e7 Merge pull request #124044 from microsoft/alex/ghost-text
Add ghost text
2021-05-21 22:39:40 +02:00
Alex Dima 51aa5402d6 Allow single line decorations that are not at the end of the line 2021-05-21 22:21:56 +02:00
Matt Bierner 06a86116b7 Fix firstHostSegment logic 2021-05-21 12:51:22 -07:00
Matt Bierner 827dec3a0d Use better logic for getting scheme and avoid extra decoding for authority
This should better handle cases where the resource authority contains characters  such as `+` and `.`
2021-05-21 12:41:45 -07:00
Connor Peet 44fe867edd fix tests 2021-05-21 12:26:41 -07:00
Rob Lourens c23c9e448e Implement dragAndDrop enable setting 2021-05-21 12:18:33 -07:00
Matt Bierner 021071ff74 Avoid double encoding authority 2021-05-21 12:16:49 -07:00
Matt Bierner 22dc518a21 Remove unused type 2021-05-21 12:16:49 -07:00
Matt Bierner 97bbacd808 Remove extra call to with 2021-05-21 12:16:49 -07:00
Connor Peet 82d18a42fa testing: fix auto run triggering test multiple times
Fixes #124333
2021-05-21 11:57:57 -07:00
Jackson Kearl 17f3a69e24 Allow toSide #119725 2021-05-21 11:57:08 -07:00
Jackson Kearl 86cb6d6b33 Close #119725 2021-05-21 11:53:27 -07:00
Daniel Imms 4d53b45428 Fix local term warning in remote
Fixes #124186
Fixes microsoft/vscode-remote-release#5055
2021-05-21 11:22:28 -07:00
Jackson Kearl 5ac4f5f5be Fix didn't work 2021-05-21 11:21:27 -07:00
Matt Bierner af3fbd968c Make sure we decode uri path
This ends up being re-encoded when the recreate the uri
2021-05-21 11:16:23 -07:00
Alex Dima 84f5040b3d Remove unused member 2021-05-21 20:01:40 +02:00
Alex Dima 91fdd52d17 Merge remote-tracking branch 'origin/main' into alex/ghost-text 2021-05-21 19:57:53 +02:00
Connor Peet 8b709a2f55 testing: provide test IDs in menu contributions, rather than internal elements 2021-05-21 10:44:44 -07:00
Henning Dieterichs 231c155d31 Refactors the inline completion feature. 2021-05-21 19:40:38 +02:00
Jackson Kearl 852b70eafe Try fix (#124384) 2021-05-21 17:36:20 +00:00
Daniel Imms c5da7f33a7 Fix wsl detection in profiles tests
Part of #124257
2021-05-21 10:16:31 -07:00
Rob Lourens b6387e477b Tweak output toolbar position 2021-05-21 10:12:46 -07:00
Mohammad Zainuddin b78754e1e4 fix incorrect links (#124203)
Co-authored-by: Mohammad ZAINUDDIN <mohammad.zainuddin@amadeus.com>
2021-05-21 10:02:47 -07:00
Matt Bierner a0d7f6292e Remove a few instances of 'vs code' in d.ts
For #124361
2021-05-21 09:35:56 -07:00
rebornix b0683f58a5 fix #124360 2021-05-21 09:35:39 -07:00
Matt Bierner 9847783f62 Remove uuid from webview resource uris
This is no longer be needed. We still serve the webview code itself from a unique subdomain

This also removes the need for `serviceWorkerFetchIgnoreSubdomain`
2021-05-21 09:28:43 -07:00
Matt Bierner 79dea51e79 Rewrite webview urls to be more url-ish
## Problem

Webview uris currently have the form:

```
https://uuid.vscode-webview.net/vscode-resource/scheme/authority/path...
```

We have this syntax because we need to be able to recover the original scheme and authority of the resource in order to load it from disk

However this syntax means that absolute urls don't behave as you'd expect. For example, if you have a webview that sets a `<base>` to a document in the workspace, an absolute url `/abs/path.png` ends up being resolved to:

```
https://uuid.vscode-webview.net/abs/path.png
```

This drops the original scheme and authority, which prevents us from loading the resource

## Fix
With this change, I've moved the original scheme and authority into the authority of the webview uri instead of the path:

```
https://scheme+authority.vscode-resource.uuid.vscode-webview.net/path...
```

With this change, absolute paths should correctly be resolved
2021-05-21 09:28:43 -07:00
rebornix 8a4bf3081a update folding on mouse over 2021-05-21 09:26:54 -07:00
Rob Lourens 70c87f0db9 Fix #124240 2021-05-21 09:12:57 -07:00
Benjamin Pasero adf68a52d5 editors - some type 💄 around setInput 2021-05-21 17:54:05 +02:00
Johannes Rieken effac5be7f drop as-prefix for ICreateCellInfo 2021-05-21 17:30:29 +02:00
Benjamin Pasero 8f093359f0 editors - simplify some serialized editor input 2021-05-21 17:03:01 +02:00
Alex Dima 8aff8020da Improve guard against unexpected URI call 2021-05-21 16:59:55 +02:00
Johannes Rieken 82cd4f027a fix leaking of NotebookCellOutputTextModel and NotebookCellOutputTextModel#_onDidChange, fyi @rebornix 2021-05-21 16:56:28 +02:00
Ladislau Szomoru c5b9b6c48c Fix missing async 2021-05-21 16:50:59 +02:00
Johannes Rieken 5807530e3a more jsdoc 2021-05-21 16:48:17 +02:00
Alex Dima 85f518b255 Add RemoteAuthorityResolver.getCanonicalURI 2021-05-21 16:48:14 +02:00
Alex Dima c650993dd3 Add ResolvedOptions.isTrusted 2021-05-21 16:48:14 +02:00
Benjamin Pasero 49e96be2fc 💄 prefer readonly over public readonly 2021-05-21 16:47:37 +02:00
Johannes Rieken 1087876df8 Use vendor-prefix for notebook specific mime-types, e.g application/vnd.code.notebook.stdout 2021-05-21 16:37:29 +02:00