Commit Graph

99168 Commits

Author SHA1 Message Date
Michael Lively
6fbee10cc1 more checking for undefined objects, fixed bug casuing markdown renderer to entirely crash 2022-07-28 11:53:51 -07:00
Tyler James Leonhardt
4017fd126f Show quick pick when redirect fails to complete redirect to be more robust (#156515)
* show quick pick when redirect fails to complete redirect to be more robust

* matt feedback
2022-07-28 10:26:18 -07:00
Aiday Marlen Kyzy
78f402334c Merge pull request #156578 from aiday-mar/aiday/semanticScroll
Filtering the ranges with the hidden ranges from folding. Fixes #156268.
2022-07-28 18:50:59 +02:00
João Moreno
e45b7a5a42 Tree keyboard navigation should not steal keybindings (#156575)
fixes #155571
2022-07-28 17:27:25 +02:00
João Moreno
9c4a29cc58 Make sure tree find widget can be moved using the keyboard (#156583)
fixes #156251
2022-07-28 17:27:00 +02:00
Aiday Marlen Kyzy
bd9ff90a64 Merge branch 'microsoft:main' into aiday/semanticScroll 2022-07-28 17:11:58 +02:00
aiday-mar
5d16a27d45 Rendering the sticky line when one pixel into the line. Fixes #156566. 2022-07-28 17:10:33 +02:00
João Moreno
35042f5316 Merge pull request #156563 from microsoft/joao/inadequate-swan
disable find widget for testing view
2022-07-28 17:08:15 +02:00
João Moreno
f4d4971d75 Existing trees should react to changes to workbench.list.defaultFindMode (#156581)
fixes #156249
2022-07-28 16:37:06 +02:00
João Moreno
fad1b7c7c2 Fine tune tree find widget layout (#156579)
fixes #156247
2022-07-28 16:33:50 +02:00
João Moreno
3bf342b7c4 Adjust tree find widget padding (#156577)
fixes #156244
2022-07-28 16:19:32 +02:00
aiday-mar
589aba9097 Filtering the ranges with the hidden ranges from folding. Fixes #156268. 2022-07-28 16:09:08 +02:00
Martin Aeschlimann
cb7a75ea2d Consider using regular folding icons for manual or preserved folding ranges. Fixes #156279 (#156573) 2022-07-28 15:32:17 +02:00
Alex Ross
1fdade8d07 TreeView reveal fails to scroll to item when focusing and a different selection exists (#156572)
Fixes #152803
2022-07-28 15:26:16 +02:00
Alexandru Dima
e65cf31952 Fix view model event and expose a way to get hidden areas (#156571)
* Fix emitting of wrong event in view model

* Add `IViewModel.getHiddenAreas`
2022-07-28 15:23:14 +02:00
Alexandru Dima
95fd5bf198 Make sure to use view line numbers when fetching data from the view model (#156569)
Fixes #156413: Make sure to use view line numbers when fetching data from the view model

Co-authored-by: aiday-mar <t-aidaym@microsoft.com>

Co-authored-by: aiday-mar <t-aidaym@microsoft.com>
2022-07-28 15:10:19 +02:00
Aiday Marlen Kyzy
0397ca4a48 Merge pull request #156562 from microsoft/alexd/sticky-scroll-improvements
Sticky Scroll Improvements
2022-07-28 13:53:51 +02:00
João Moreno
baa2e394fb disable find widget for testing view 2022-07-28 12:37:10 +01:00
João Moreno
469465b703 fix issue with multiple tree filters
related to #156127
2022-07-28 12:28:43 +01:00
Alex Dima
463d53f24e Fixes #156328: Use editor API to determine the top and bottom for line numbers
Co-authored-by: aiday-mar <t-aidaym@microsoft.com>
2022-07-28 13:12:20 +02:00
Ladislau Szomoru
8ced34cb31 Engineering - unify all Code OSS pipeline jobs (#156552) 2022-07-28 12:38:45 +02:00
Alex Dima
09935be99b Rename getViewLineRenderingData to getViewportViewLineRenderingData 2022-07-28 12:33:14 +02:00
Ladislau Szomoru
96c1ab3fa9 Engineering - Add missing variable to cache maintenance job (#156540)
Add missing variable to cache maintenance job
2022-07-28 09:25:22 +02:00
Sandeep Somavarapu
3f502b2bcf Fix #154485 (#156533) 2022-07-28 09:56:31 +03:00
Ladislau Szomoru
c4d99090fc Engineering - Code OSS pipeline to use generic node modules cache (#156537)
Code OSS pipeline to use generic node modules cache
2022-07-28 08:50:51 +02:00
Sandeep Somavarapu
b4d5b4ed69 Fix #156468 (#156528) 2022-07-28 06:46:36 +02:00
Sandeep Somavarapu
4ee1d1a248 Fix #153942 (#156525) 2022-07-28 06:27:21 +02:00
Sandeep Somavarapu
916f7677fc Fix #156321 (#156524) 2022-07-28 06:23:17 +02:00
Benjamin Pasero
3e26d50f99 Revert "Warn user when they open a file within the install folder tree (#138815) (#155443)" (#156403)
This reverts commit 688c30e498.
2022-07-28 06:11:05 +02:00
Matt Bierner
0e5245ccc7 Revert fix for #150995 (#156516)
Fixes #156352
2022-07-28 05:22:19 +02:00
Matt Bierner
083728eb87 Fix drop indicator showing up even if you have disabled dropIntoEditor (#156506)
This fixes a number of places where we were adding `dropIntoEditor` to the config override, which also overrides the user's configation. Instead we can check if the editor is readonly in `codeEditorWidget`
2022-07-28 00:43:40 +02:00
Connor Peet
99cf19c042 debug: bump js-debug and visualizer for 1.70 (#156508) 2022-07-28 00:30:01 +02:00
Justin Chen
08145fe1e4 Fixed label on Code Action hover
Code Action bug fixes
2022-07-27 14:53:24 -07:00
Matt Bierner
d949bdfb48 Clarify wording in api (#156500)
Clairify wording in api

Fixes #156376
2022-07-27 14:52:17 -07:00
Justin Chen
af67e60687 fix naming on hover 2022-07-27 14:34:48 -07:00
Martin Aeschlimann
89c30e1b86 manual folding ranges: memento does not store all sources (#156273)
use source: fix memento does not store all sources
2022-07-27 14:02:44 -07:00
Joyce Er
d48349a494 Default edit sessions to hidden for 1.70 (#156494) 2022-07-27 22:17:22 +02:00
Matt Bierner
06f8d52e37 Always log on tsserver exits (#156495)
This ensures we also log if the TS Server exits with no code but a valid signal. Useful for figuring out how many users are hitting OOM errors
2022-07-27 12:58:52 -07:00
Martin Aeschlimann
7b376e0704 Remove Manual Folding Range doesn't work (#156493)
Remove Manual Folding Range doesn't work. Fixes #156277
2022-07-27 12:02:35 -07:00
Matt Bierner
4aa9759988 Fix webview providerId not being restored on reload (#156492)
Fixes #156491
2022-07-27 21:02:01 +02:00
Matt Bierner
00bb9bdefc Always log tsserver exit code, even for kill processes (#156378)
We suspect that some exit code info is being dropped since 1.61. Changing this code to always log, even when the user manually restarts the server
2022-07-27 11:54:24 -07:00
Martin Aeschlimann
59afa0a8ee Create and remove manual folding range use the same shortcut. (#156490)
Create and remove manual folding range use the same shortcut. Fixes #156489
2022-07-27 20:53:49 +02:00
Peng Lyu
9db76b0b15 Fix #156477. Interactive Window Restore (#156480)
* Fix #156477. Interactive Window Restore

* Fix #156487. Update description
2022-07-27 14:47:58 -04:00
SteVen Batten
9b44eda62a still allow system context menu in some cases (#156488)
fixes #156222
2022-07-27 20:31:44 +02:00
Martin Aeschlimann
857412ab10 devcontainer schema: handle deprecated properties (#156425) 2022-07-27 20:27:47 +02:00
Matt Bierner
93340ffab9 Log when encountering invalid json in vscode-context (#156485)
Fixes #156416
2022-07-27 20:14:27 +02:00
Henning Dieterichs
c8cf34a36f Fixes #156037 by not highlighting non-conflicting changes. (#156482) 2022-07-27 11:13:13 -07:00
Matt Bierner
be910fd929 Use clearer parameter name (#156479)
Fixes #156431
2022-07-27 11:12:45 -07:00
Henning Dieterichs
562281e08b Merge pull request #156466 from microsoft/hediet/model-disposed-bugfix
Fixes #153961 by checking if models are disposed.
2022-07-27 19:53:58 +02:00
Matt Bierner
ead6a6f34f Revert "Temporarily comment out tuple type annotations (#156213)" (#156478)
This reverts commit 8f10b21033.
2022-07-27 19:52:03 +02:00