Commit Graph
119780 Commits
Author SHA1 Message Date
Ulugbek Abdullaev 74e41997fc rename suggestions: refactor: move stats to a proper object instead of inlining them into result 2024-03-18 23:38:15 +01:00
Michael LivelyandGitHub a3af971b72 Add setting to exclude non-header md cells from notebook outline view (#207771)
* setting to exclude non-header md entries

* fix stickyscroll early return when we lose outlineEntry for non-header md cell

* change setting name and behavior to match

* add toggle non-header menu item
2024-03-18 14:24:02 -07:00
Ulugbek Abdullaev 091ad6b40e rename suggestions: fix: set selection in rename input field to initial selection in editor 2024-03-18 22:20:43 +01:00
Matt BiernerandGitHub 18d118aaf5 Pick up latest TS for building VS Code (#208041) 2024-03-18 22:12:00 +01:00
Daniel ImmsandGitHub b3701a9d89 Merge pull request #208036 from microsoft/tyriar/199611
Enable shell integration in hidden terminals
2024-03-18 12:57:56 -07:00
Michael LivelyandGitHub cf9f2452e7 Add Filter menu to notebook outline view (#208034)
add entry filter menu to notebook outline
2024-03-18 12:55:20 -07:00
Sandeep SomavarapuandGitHub b356bddcac make the setting application scoped (#208035) 2024-03-18 20:01:31 +01:00
Daniel Imms f5f392c2c4 Enable shell integration in hidden terminals
As I understand it, hidden terminals were always exempty from shell
integration because hidden terminals were thought of as private to an
extension in a way, and also since they probably weren't going to be
interacted with. Especially since the introduction of the environment
variable collection API I think we should change this decision, not
doing so will lead to weirdness for extensions where hidden ones (which
may be shown later) aren't fully featured and get inconsistent envs.

Fixes #199611
Part of #197187
2024-03-18 11:58:22 -07:00
Connor PeetandGitHub 7015a87618 cli: avoid adoption of tunnels with existing host connections (#208033)
Fixes https://github.com/microsoft/vscode-remote-release/issues/9655
2024-03-18 19:44:07 +01:00
Bhavya UandGitHub ff15e55781 Clear accounts badge when settings are disabled (#208028) 2024-03-18 19:41:49 +01:00
Daniel ImmsandGitHub 438bfd29c2 Merge pull request #208030 from microsoft/tyriar/xterm_240318
Update xterm.js
2024-03-18 11:15:21 -07:00
Matt BiernerandGitHub 6ab9dd8ff1 Suppress extension diagnostics in code blocks (#207754)
May re-enable in the future. Also we can't simply disable the markers feature as this also turns off a number of useful markers for stuff like go to def
2024-03-18 10:57:25 -07:00
Sandeep SomavarapuandGitHub 1b1b41c41b report extension signature telemetry (#208027) 2024-03-18 10:44:33 -07:00
Daniel Imms 16b2e2d68e Update xterm.js
Fixes a glyph scaling issue among other minor things
2024-03-18 10:30:57 -07:00
Sandeep SomavarapuandGitHub 987d9282e8 make workspace extensions feature experimental and insiders only (#208021)
* make workspace extensions feature experimental and insiders only

* fix tests
2024-03-18 18:13:29 +01:00
Benjamin Christopher SimmondsandGitHub c202946237 Scroll Locking Improvements (#208023)
scroll locking improvements
2024-03-18 17:13:03 +01:00
Henning DieterichsandHenning Dieterichs 484fd56d48 Fixes arrow positioning. 2024-03-18 17:08:21 +01:00
Don JayamanneandGitHub 3242621276 Remove unwanted vscode property when not required (#208014) 2024-03-18 08:50:28 -07:00
b356b209a5 cli: add --server-base-path flag to code serve-web command (#207932)
* feat(cli): add --server-base-path flag to `code serve-web` command

* fix clippy

* fmt

---------

Co-authored-by: navigaid <navigaid@gmail.com>
2024-03-18 08:12:08 -07:00
RoboandGitHub c45557f69b chore: update server detection script for legacy server (#208000)
* chore: update server detection script for legacy server

* chore: address review feedback
2024-03-18 16:09:27 +01:00
Ladislau SzomoruandGitHub 010f4fc3cb SCM - fix input widget height on first render (#208017)
* Source Control - fix commit input height on first render

* Remove debug messaged
2024-03-18 16:00:23 +01:00
Don JayamanneandGitHub 19a78385c7 Remove custom property from nb and cell metadata (#207995) 2024-03-18 15:01:04 +01:00
Benjamin PaseroandGitHub e752296594 aux window - change to an action for when custom editor fails to open (#208004) 2024-03-18 14:49:55 +01:00
Ulugbek Abdullaev 7451929c7e rename suggestions: polish new UX & update telemetry 'source' field to reflect that now the source can be combination of copilot rename suggestion and user edit; should we add similarity check? 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev dda59c2328 rename suggestions: fix: clear focused rename suggestion when input field changes 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 40565ce894 rename suggestions: feat: implement new UX 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 04f0647a59 rename suggestions: fix: arrow up works always 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 3de62000fd rename suggestions: refactor: use a DeferredPromise 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 1fb761447d rename suggestions: refactor: better name 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev f219b35392 rename suggestions: refactor: don't apply editor font to rename input field label because it's 'workbench' font 2024-03-18 14:36:30 +01:00
Ulugbek Abdullaev 84bb33091b rename suggestions: refactor: don't use a setter for a method mutating stuff 2024-03-18 14:36:30 +01:00
Henning DieterichsandHenning Dieterichs 889093bb7a Fixes diff gutter styling issues
Signed-off-by: Henning Dieterichs <hdieterichs@microsoft.com>
2024-03-18 13:16:10 +01:00
RoboandGitHub 7c21685343 fix: legacy server stage dependency for CI builds (#207994) 2024-03-18 12:12:23 +01:00
Don JayamanneandGitHub 1b4e4196b0 Better timeline title for cell metadata changes (#207972) 2024-03-18 12:02:41 +01:00
Benjamin PaseroandGitHub 568fe88e69 aux window - try to mitigate custom editor claim across windows (#207992) 2024-03-18 11:37:18 +01:00
Sandeep SomavarapuandGitHub e1ce54ff03 fix installing and watching workspace extensions (#207983)
* fix installing and watching workspace extensions

* fix tests and debounde listening
2024-03-18 11:11:40 +01:00
RoboandGitHub 1413fc87a7 feat: create and upload legacy remote server (#204139) 2024-03-18 11:09:55 +01:00
c800bf9216 Introduce minimap section headers, a la Xcode (#190759)
* WIP for adding minimap section headers for #74843

* Get section headers rendering

* Fix default value of section header font size

* Fix tests

* Improve section header position

* Fix separator display, update after config change

* Split too-long headers with an ellipsis

* Render section headers on the decorations canvas

* Support MARK with just a separator line

* Calculate minimap section headers asynchronously

* Simplify change

* Avoid font variable duplication

* Fix issue introduced earlier

* Recompute section headers when the language configuration changes

* Fix problem in constructing region header range

* Parse mark headers in the entire file and then filter out the ones not appearing in comments on the UI side, where tokens info is available

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-18 08:49:27 +00:00
Benjamin Christopher SimmondsandGitHub cda53a0627 Add single view pane container title support (#207816)
Chat title
2024-03-18 09:49:23 +01:00
Benjamin PaseroandGitHub 5412743dcb working copy - allow to shutdown even with dirty changes and no backup (#207974) 2024-03-18 08:00:51 +01:00
Don JayamanneandGitHub 9ccb0fa738 Remove dead code (type IOutputRequestDto) (#207971) 2024-03-17 21:16:10 -07:00
Don JayamanneandGitHub 9f25e63114 Re-order Cut/Copy/Paste in the Cell context menu (#207963) 2024-03-18 04:14:04 +01:00
Don JayamanneandGitHub b216b43c2f Shift+PageUp/Down to select NB output contents (#207962) 2024-03-18 00:37:02 +01:00
Don JayamanneandGitHub 8c7cf6a7ad Support Ctrl+A in notebook outputs (#207548)
* Support Ctrl+A in notebook outputs

* Better handling of outputs

* oops

* Better determination of outputId
2024-03-18 00:31:17 +01:00
Daniel ImmsandGitHub aefe7e830c Merge pull request #207952 from microsoft/tyriar/instance_cleanup
Reuse write code in _onProcessData
2024-03-17 13:03:11 -07:00
Daniel Imms 08159ae502 Reuse write code in _onProcessData 2024-03-17 09:55:35 -07:00
Benjamin PaseroandGitHub ca90b8ec28 aux window - drop buggy AuxWindowUnsupported capability
This needs a different approach, likely on the level of custom editors itself. Given custom editors are to implement backups, moving between windows should actually not result in data loss in most cases.

For custom editors that ignore backups, a better approach would be to throw an error or force to save right before a `webview` is about to get disposed because it moved to another window.
2024-03-16 09:44:48 +01:00
997212d6c0 Use indentSize instead of tabSize for LineCommentCommand (#193811)
Tab size and indent size were separated in #155450, but for deciding
where to put "//" or "#" when toggling a line comment tab size was still
used.

Fixes #170393.

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2024-03-16 01:52:14 +01:00
c7578a3366 Do not trim whitespace when part of strings or regexes (#198164)
* Do not trim whitespace when part of strings or regexes

Fixes https://github.com/microsoft/vscode/issues/195010. If the token to be removed is part of a string or a regex, then we do not want to remove the character, as it is very likely semantically important.

* Address initial feedback:

1. Add a new setting to control whether to trim whitespace in multiline strings/regexes. This setting is then piped through to everywhere that is calling trim whitespace, which is file save editing, the trim whitespace command, and notebooks.
2. Force line tokenization to complete when the setting is enabled so that trim is accurate.

* Don't force tokenization; instead, check to see if there are tokens for a given line and do not format if there are none.

* Look for syntactical tokens

* Fix compilation errors

* Add a test

---------

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2024-03-16 00:43:15 +00:00
7caab31bf4 editor paste event result return ClipboardEvent (#192732)
* editor paste event result return ClipboardEvent

* Remove commented out code

* Cleanup `applyDefaultPasteHandler`

---------

Co-authored-by: Matt Bierner <matb@microsoft.com>
2024-03-16 00:42:52 +00:00