Commit Graph

3723 Commits

Author SHA1 Message Date
Gabriel DeBacker
793fc0295c Use correct resolved TDO and task for custom execution 2019-07-22 06:58:16 -07:00
Sandeep Somavarapu
53fe1660c9 Move download command to extension host 2019-07-20 05:17:46 +02:00
Matt Bierner
1ef4a75ff9 Replace IDisposable with DisposableStore in a few more simple cases 2019-07-19 17:36:17 -07:00
Rob Lourens
04c4de6a38 Change remoteEnv extension API to be backwards compatible 2019-07-19 14:56:37 -07:00
Rob Lourens
7ee0e1818a Give remote resolvers a way to set environment variables in the remote EH
Fix #77234, for microsoft/vscode-remote-release#16
2019-07-19 14:56:37 -07:00
Peng Lyu
97ce6669fa toggle reaction should work. 2019-07-18 15:38:44 -07:00
Peng Lyu
f1bad37012 Remove Comment Id 2019-07-18 15:34:05 -07:00
Sandeep Somavarapu
78de125b5f Introduce new enablement states 2019-07-18 22:34:27 +02:00
Martin Aeschlimann
6163b86243 add gotoLineMode to IOpenSettings 2019-07-18 16:56:14 +02:00
Sandeep Somavarapu
034e0a9f99 Use Enablement service to check if an extension is enabled or not 2019-07-18 16:36:52 +02:00
Sandeep Somavarapu
db8cc94a06 Move enablement and servers to workbench 2019-07-18 12:17:15 +02:00
Andre Weinand
fb0e9f7d03 cleanup ExtensionHostDebugService 2019-07-18 11:56:42 +02:00
Matt Bierner
928ae46457 Rewrite how webviews are managed internally
This change attempts to do the following:

- Encapsult most of the logic for handling the webviews used for webview editors into a new WebviewEditorOverlay class
- Greatly simplify WebviewEditorInput and make it take a webview when it is created
- Move the webview creation logic up into the webviewEditorService instead of having it be inside the webviewEditor class itself

This aim of these changes is to make it possible to re-use more of the webview logic for custom editors
2019-07-17 18:14:08 -07:00
Matt Bierner
8b69b981de Simplify state used for webviews
We previously used nested states to store some additional metadata alongside the real webview state. This is overly complicated. This change switches us to using a single top level state field, while also adding some code to handle migration from the old state structure
2019-07-17 18:14:08 -07:00
Matt Bierner
4629479920 Don't require using state to check if we can revive 2019-07-17 18:14:08 -07:00
Matt Bierner
e26db506b7 Mark that state may be undefined 2019-07-17 18:14:08 -07:00
Logan Ramos
f50a0430c3 More strongly typed telemetry (#77412)
* More strongly typed telemetry

* Updated update service to not duplicate typings
2019-07-17 08:29:25 -07:00
Logan Ramos
0a8ca638f1 Resolve Terminal arguments (#76895)
* Resolved terminal argds

* Move location of resolution

* Fix routing of resolver in extHost

* Remove unnecessary comma

* Compilation errors

* some async stuff

* Undo changes

* Variable resolver in constructor

* Load resolver upon construction of extHostTerminalService

* Utilize last active workspace root

* Reevaluate variableReoslver whenever the workspace gets new folder

* Fix types for string shellArgs

* Use async one level higher

* Fix compile issue

* Initialize resolver when exthost is created

* Fix ext host in remote case with no folder open

* Resolve args that an ecxctension passes in

* Remove TODO

* Resolve extension arguments
2019-07-16 09:23:38 -07:00
Matt Bierner
7411e3f341 Convert many simple getters for events into readonly properties
We seem to use the readonly property way of exposing these values more widely. Standardizing this a bit across the codebase
2019-07-15 16:12:25 -07:00
Matt Bierner
20d2018d18 Convert to async 2019-07-15 15:44:16 -07:00
Matt Bierner
be5a4fa940 💄 2019-07-15 15:42:48 -07:00
Matt Bierner
4eb2bf393b Use DisposableStore 2019-07-15 15:03:54 -07:00
Matt Bierner
618da58752 Use map instead of object literals in mainThreadTerminalService
Replaces a few uses of object literals with regular maps, which  better enforce type correctness
2019-07-15 12:00:37 -07:00
Matt Bierner
f729a996c6 Use map to track registrations 2019-07-15 11:47:29 -07:00
Matt Bierner
7ed88bd70c Use set to track synced values instead of object literal 2019-07-15 11:47:29 -07:00
Matt Bierner
afe2da7ed6 Use a map instead of a object to store editors 2019-07-15 11:47:29 -07:00
Howard Hung
1d4dc5dcf9 Fix typos 2019-07-15 23:31:48 +08:00
Daniel Imms
2443cf5037 Merge pull request #77298 from microsoft/tyriar/77228_dimensionss
Improve terminal grid dimensions caching
2019-07-13 13:14:47 -07:00
Matt Bierner
5106b556bd Support loading webviews from wildcard endpoints
Fixes #77132

Add support for loading webviews from and endpoint that looks like:

```
https://{{uuid}}.contoso.com/path/to/some/commit/index.html
```

This lets us serve each webview from a seperate origin
2019-07-12 15:38:12 -07:00
Daniel Imms
c9cfc7c5ed Merge remote-tracking branch 'origin/master' into tyriar/77228_dimensionss 2019-07-12 10:42:34 -07:00
Daniel Imms
fd48fa0d3b Fix dimenisons test and clean up 2019-07-12 10:37:29 -07:00
Sandeep Somavarapu
b3422b98b7 Merge pull request #76377 from microsoft/sandy081/fix74859
trigger workspace contains activation event on new folders
2019-07-12 16:42:56 +02:00
Alex Dima
498f158475 Small style tweaks 2019-07-12 16:13:27 +02:00
Daniel Imms
3092a1023c Remember dimensions from other terminals
Part of #77228
2019-07-11 21:18:06 -07:00
Daniel Imms
5701770f87 Ensure negative exit codes are not used
Fixes #77250
2019-07-11 15:47:15 -07:00
Johannes Rieken
3a47abace1 create instantiation service in api.impl and create extHostDebug with it, #76570
also tweak some names and types
2019-07-11 17:02:01 +02:00
Martin Aeschlimann
4ffdeee2c2 Merge branch 'master' into aeschli/isEqualCaseSensitiveForNonFIle 2019-07-11 14:59:03 +02:00
Johannes Rieken
e9d8aaafcb improve image source extraction for remote cases, https://github.com/kisstkondoros/gutter-preview/issues/57 2019-07-11 11:25:49 +02:00
SteVen Batten
305d5be119 implement browser clipboard service (#75293)
* implement browser clipboard service

* actually register the clipboard service

* update all refs to newly async funcs

* addressing comments

* small fixes

* all asyncs as a result of readText

* fix unit test

* cleanup for writeText refs

* cleanup and reduce diff noise

* qfix

* address feedback
2019-07-11 09:49:28 +02:00
Matt Bierner
ca7605f339 Use a uuid as our webview handles
Avoid having duplicated ids/handles
2019-07-10 11:55:37 -07:00
Matt Bierner
f57ff0b25c Remove webview _onBeforeShutdown
This should no longer be required
2019-07-10 11:55:37 -07:00
Rachel Macfarlane
877235c625 Remove old proposed commenting API 2019-07-10 11:11:14 -07:00
Johannes Rieken
046b66fb8f move workspace.fs to stable, #48034 2019-07-10 16:20:36 +02:00
Alex Ross
e84fc7021b Adopt TerminalVirtualProcess for Custom task execution (#76852)
* Adopt TerminalVirtualProcess for Custom task execution

* Update Custom task execution API to return TerminalVirtualProcess in callback

This also required the addtion of a start on the virtual terminal process

* Clarify start API

Fixes #76492
2019-07-10 09:31:40 +02:00
Matt Bierner
c01a3a718d Use clearer name for csp webview element
#76489
2019-07-09 11:45:20 -07:00
Matt Bierner
f963c9a2a8 Adding tests and changing how toWebviewResource works
- Allow placeholders in the webviewEndpoint. This is required to support serving each webview from its own origin
- Add tests for toWebviewResource
2019-07-09 11:45:10 -07:00
Johannes Rieken
d0fcf07040 debt - better check for reserved schemes 2019-07-09 17:03:39 +02:00
Johannes Rieken
bc00e886a9 make it easier to use options, #48034 2019-07-09 16:27:53 +02:00
Johannes Rieken
65270230af tweak options for delete and write, #48034 2019-07-09 16:23:48 +02:00
Johannes Rieken
a4fc9bb8c4 improved error propagation, #48034 2019-07-09 16:17:02 +02:00