Matt Bierner
869e5921d8
Update more places where we are using an IDispoable[]
...
Either extend `Disposable` or use a readonly `DispoableStore`
2019-06-05 15:41:45 -07:00
Alex Ross
f3086a6e11
Remove sync fs use in tasks
...
Fixes #70577
2019-06-05 17:10:13 +02:00
Waldir Pimenta
f3e4e47164
Fix spelling of the example abbreviation (e.g.)
2019-06-05 16:00:26 +02:00
Christof Marti
3460fb97b0
Avoid __nodeRequire() ( #74398 )
2019-06-05 12:50:43 +02:00
Benjamin Pasero
01423e458d
debt - move status message into notification status
2019-06-05 11:38:54 +02:00
Johannes Rieken
6a4467da59
for completions use CommandsConverter.toInternal2, #74846
2019-06-05 09:38:49 +02:00
Johannes Rieken
a73b4236b0
properly keep resolved code lens command, #74846
2019-06-05 09:38:49 +02:00
Johannes Rieken
35643d80e0
add lifecycle to code lens, #74846
2019-06-05 08:52:31 +02:00
Rachel Macfarlane
83ef31e6a2
Correctly set extensionId on comment threads
2019-06-04 11:50:47 -07:00
Johannes Rieken
6f1da34c2e
debt - decouple webviews from code insets, move things to /browser/-layer, change inset api proposal to push style, re #66418
2019-06-04 12:31:18 +02:00
Peng Lyu
039b3e0a1a
Merge pull request #74688 from microsoft/rebornix/fix#74641
...
Fix #74641 . Update viewzone afterline when position changes.
2019-06-03 13:45:04 -07:00
Johannes Rieken
042efb5696
don't freeze vscode.env when running tests, #74121
2019-06-03 12:07:30 +02:00
Rachel Macfarlane
0284236851
Fix #74668 , old comment API not adding comments
2019-05-31 12:00:24 -07:00
Peng Lyu
c042dabe2b
Fix #74641 . Update viewzone afterline when position changes.
2019-05-31 10:27:56 -07:00
Johannes Rieken
59794815ce
when adding contributed keybindings check if a command with enablement-clause exists
2019-05-31 12:39:40 +02:00
Matt Bierner
483e48d875
Fix sorting of source code actions being reversed
...
Fixes #73344
2019-05-30 11:30:45 -07:00
Rachel Macfarlane
2185280ed5
Update commentThread/context and comment/context contribution descriptions, fixes #74552
2019-05-29 09:59:36 -07:00
Johannes Rieken
5cfeefdaa9
remove vscode.env.remoteAuthority API, #74188
2019-05-29 10:33:48 +02:00
Johannes Rieken
a429fd1356
refine remoteAuthority-api, #74188
2019-05-28 18:00:07 +02:00
Johannes Rieken
034165ac67
don't cache provider results when request was cancelled, #74446
2019-05-28 12:15:53 +02:00
Johannes Rieken
6526507326
💄 remove unused kind-property from SelectionRange
2019-05-27 17:04:40 +02:00
Johannes Rieken
6a1574e21e
add vscode.env.remoteAuthority-api, #74188
2019-05-27 11:51:08 +02:00
Alex Dima
022835ea42
Connect to the remote extension host
2019-05-24 18:33:29 +02:00
Daniel Imms
93f93d0961
Merge remote-tracking branch 'origin/master' into tyriar/72518_runInBackground
2019-05-24 06:16:37 -07:00
Johannes Rieken
b8e68e1ade
use enablement, make it a property of commands, not items, #21131
2019-05-24 15:12:30 +02:00
Benjamin Pasero
1ce1371dc3
debt - distinguish progress services
2019-05-24 15:03:55 +02:00
Sandeep Somavarapu
7b3d95e57e
fix #73441
2019-05-24 13:05:48 +02:00
Alex Dima
9fb9ca51a6
Add transformOutgoingScheme to IURITransformer
2019-05-24 12:46:48 +02:00
Matt Bierner
0f32f0ef5f
Clean up some usages of IDisposable[]
...
Part of #74250
- Extend `Disposable` in classes where it makes sense
- Use `DisposableStore` for lists of disposables
- Make `combinedDisposable` take arguments instead of an array (so that you can't pass in an array and then modify the array after the fact)
2019-05-23 22:58:16 -07:00
Matt Bierner
3d5ce6be5e
Introduce DisposableStore
...
Fixes #74242
Our current usage of dispoable arrays can leak disposables (see #74242 for details). This change introduces a new class called `DisposableStore` that can be used mostly as a drop in replacement for an array of disposables but will not leak disposbles if it is disposed
`DisposableStore` was extracted from the existing `Dispoable` class, which already implements this pattern. However `Disposable` is intended to be used as a base class while `DispoableStore` is a value class.
In addition, this change hides the `toDispose` / `_toDipose` members of `Disposable` as direct write access to the disposable array also allows for leaks (and breaks encapsulation)
2019-05-23 19:25:16 -07:00
Matt Bierner
f3b8d15b0d
Add DocumentLink.tooltip api proposal
...
For #72824
2019-05-23 17:57:04 -07:00
Peng Lyu
346da6b01a
dispose empty comment thread when collapse.
2019-05-23 16:37:42 -07:00
Daniel Imms
b3ab7bd13e
Disallow runInBackground unless proposed is enabled
2019-05-23 12:42:22 -07:00
Daniel Imms
9b3544000e
Merge remote-tracking branch 'origin/master' into tyriar/72518_runInBackground
2019-05-23 12:08:42 -07:00
Peng Lyu
7b078e1165
Merge pull request #74089 from microsoft/rr/comments
...
Comment API
2019-05-23 09:42:56 -07:00
Peng Lyu
48f6cce7e8
change comment/actions to comment/context to keep align
2019-05-23 09:28:05 -07:00
Daniel Imms
f68625b600
Support running terminals in background
...
Part of #72518
2019-05-22 17:22:50 -07:00
Matt Bierner
c2b02df9ab
Allow hidden (but persisted) webviews to recieve messages
...
Fixes #47534
2019-05-22 15:25:48 -07:00
Peng Lyu
e26568b586
Add contextValue support
2019-05-21 16:59:34 -07:00
Peng Lyu
b8c1a34885
thread id is still updatable
2019-05-21 15:08:47 -07:00
Peng Lyu
fd9b74985f
rename namespace for comments
2019-05-21 15:08:47 -07:00
Howard Hung
b04e74819f
Fix typo: menusContribtion -> menusContribution
2019-05-22 01:21:20 +08:00
Andre Weinand
9af6cea057
remove support for running DA in renderer
2019-05-21 18:46:03 +02:00
Peng Lyu
d681615381
Precondition for command and alt command
2019-05-20 12:02:32 -07:00
Peng Lyu
569b36c307
no need to check item.alt
2019-05-20 12:00:00 -07:00
Peng Lyu
e0666b4323
precondition for commands
2019-05-20 11:57:04 -07:00
Peng Lyu
7554ac4387
Edit comment
2019-05-17 18:16:14 -07:00
Matt Bierner
46ff93770f
Encapsulate WebviewContent
2019-05-17 18:14:40 -07:00
Rachel Macfarlane
925426e8b0
Remove activeCommentThread from extHost comments, set context keys on simple comment editor
2019-05-17 16:52:36 -07:00
Peng Lyu
e6152cc29f
icons for menu bar
2019-05-17 16:34:47 -07:00
