Commit Graph

3723 Commits

Author SHA1 Message Date
Matt Bierner
963ddff246 Strict null check extHostLanguageFeatures 2019-03-11 08:49:41 -07:00
Matt Bierner
d37e38b6c3 Revert extract and use null supressions as requested 2019-03-11 08:33:13 -07:00
Matt Bierner
9d503a5481 Naming 2019-03-11 08:29:43 -07:00
Matt Bierner
8ee3c9a484 Allow trackobject to take undefined 2019-03-11 08:29:43 -07:00
Matt Bierner
a92031dc02 Strict null check work in extHost and mainThread language Features
- annotate undefined returned types
- Don't call functions with null or undefined values.
- Refactor _convertCompletionItem so that we don't need to mutate the returned object
- Suppress a type error related to electricCharacters.
2019-03-11 08:29:43 -07:00
Sandeep Somavarapu
ecd66fdf7e take hideIfEmpty parameter while registering of view containers 2019-03-11 16:13:41 +01:00
Martin Aeschlimann
211e7cd1ba 'openFolder': add recentEntryLabel 2019-03-11 13:30:43 +01:00
Andre Weinand
37f689cebc remove paranoia code after fix for #69128 2019-03-11 13:18:40 +01:00
Johannes Rieken
6892cfc90e for now remove SelectionRangeKind #67872 2019-03-11 09:43:34 +01:00
Martin Aeschlimann
aa639490f7 Merge branch 'master' into aeschli/recentWithLabel 2019-03-10 22:11:02 +01:00
Martin Aeschlimann
6b6c4137ef add noRecentEntry for vscode.openFolder 2019-03-10 19:08:05 +01:00
SteVen Batten
bf5e12e923 consolidate search into common (#69614) 2019-03-08 16:43:13 -08:00
Andre Weinand
ac46ca2a5e make caching more robust; fixes #69534 2019-03-08 17:08:08 +01:00
Martin Aeschlimann
9b39b7b1bc Merge branch 'master' into aeschli/recentWithLabel 2019-03-08 15:55:01 +01:00
Peng Lyu
5390f0a899 Delayer for updating commenting ranges. 2019-03-07 16:11:12 -08:00
Martin Aeschlimann
86526f401b Merge branch 'master' into aeschli/recentWithLabel 2019-03-07 22:53:44 +01:00
Martin Aeschlimann
ff8afd07b8 label for recent 2019-03-07 22:52:48 +01:00
Daniel Imms
0d9f226bfe Merge pull request #66819 from GabeDeBacker/user/gabrield/extensionCallbackAsTask
User/gabrield/extension callback as task
2019-03-07 13:00:44 -08:00
Peng Lyu
75e711f8a6 seperate acceptInputCommand and additional commands. 2019-03-07 11:34:43 -08:00
Peng Lyu
87b337a8ad Use unique uuid for comment controller. 2019-03-07 10:29:11 -08:00
Benjamin Pasero
eb12756d0c debt - part service => layout service 2019-03-07 10:16:10 +01:00
Benjamin Pasero
ec10e5b273 debt - partService is really in browser 2019-03-07 09:50:50 +01:00
Rob Lourens
a09e7bd128 Fix #64575 - delete FileIndexProvider 2019-03-07 05:33:35 +00:00
Matt Bierner
03c4f88d7f Strict null check mainThreadWebview 2019-03-06 18:54:36 -08:00
Peng Lyu
b64a7295b2 Merge remote-tracking branch 'upstream/master' into rebornix/commentenhancement 2019-03-06 14:54:42 -08:00
Peng Lyu
ba0f67f828 Fix warnings 2019-03-06 14:39:04 -08:00
Peng Lyu
ce1cb8a9fc replace draft properties with labels in CommentThread and Comment 2019-03-06 14:29:02 -08:00
Gabriel DeBacker
6d665482c8 Put back more of the terminal changes 2019-03-06 14:03:16 -08:00
Sandeep Somavarapu
a4b49166d0 Fix #69110 2019-03-06 22:18:01 +01:00
Peng Lyu
905248fa6e comments panel handle new comment thread registration. 2019-03-06 11:57:30 -08:00
Gabriel DeBacker
d5e4009ae9 Remove need for acquiring dimensions for terminal from main thread 2019-03-06 11:47:57 -08:00
Gabriel DeBacker
99cf5e4881 Merge remote-tracking branch 'upstream/master' into user/gabrield/extensionCallbackAsTask 2019-03-06 10:30:14 -08:00
Peng Lyu
42194d82a1 Callback for creating new comments 2019-03-06 10:15:51 -08:00
Gabriel DeBacker
8b1b0763a3 Merge with master 2019-03-06 07:44:35 -08:00
Johannes Rieken
763ae0943d eng - some extHost strict-null work 2019-03-06 16:44:15 +01:00
Sandeep Somavarapu
cd816afcc9 Take static arguments for the view descriptor ctor 2019-03-06 12:33:18 +01:00
Joao Moreno
e6bc6699a4 strict null checks: extHostSCM 2019-03-06 10:50:07 +01:00
Alex Dima
1d345f0737 URI always needs to be revived after crossing ipc boundaries 2019-03-06 10:19:17 +01:00
Rob Lourens
0710a009f8 Fix #69875 2019-03-05 19:17:54 -08:00
Matt Bierner
52556f9742 Auto converting let -> const where possible in mainthread and extHost
Const provides better type guards and can make logic clearer
2019-03-05 16:53:41 -08:00
Matt Bierner
aef80e8070 Auto marking fields as readonly in mainThread files 2019-03-05 16:53:40 -08:00
Matt Bierner
db9a994ded Strict null check extHostDiagnostics 2019-03-05 16:53:40 -08:00
Matt Bierner
14c4fde6d6 Strict null check extHostQuickOpen 2019-03-05 16:53:40 -08:00
Matt Bierner
8f3cda12e4 Strict null check extHostFileSystem 2019-03-05 16:53:40 -08:00
Matt Bierner
bb64391ec4 Strict null work in exthost 2019-03-05 16:53:40 -08:00
Matt Bierner
733a1cd841 Strict null check extHostDocuments 2019-03-05 16:53:40 -08:00
Matt Bierner
480b838ef2 Strict null check apiCommands 2019-03-05 16:53:40 -08:00
Rob Lourens
10fdea204a Fix #69840 2019-03-05 14:52:09 -08:00
Rob Lourens
f3b73b1abc Fix #69862 - don't split comma-separated globs when expandPatterns is disabled (for findFiles) 2019-03-05 14:52:03 -08:00
Matt Bierner
13e394ff45 Strict null fixes for tests 2019-03-05 11:25:32 -08:00