Commit Graph
123870 Commits
Author SHA1 Message Date
Martin Aeschlimann 89b2f90c3a Improve code mapper telemetry for quality signal (#225602) 2024-08-14 16:39:22 +02:00
Benjamin Pasero f430a63a28 esm - reduce diff in some core pieces (#225599)
* esm - reduce diff in some core pieces

* tests

* tests
2024-08-14 07:19:43 -07:00
Benjamin Pasero 01d7b7a315 esm - reduce diff (bootstrap files) (#225598) 2024-08-14 15:32:09 +02:00
Benjamin Pasero 0dea4804f4 esm - introduce VSCODE_BUILD_ESM variable (#225586) 2024-08-14 14:49:26 +02:00
Henning Dieterichs 7f4969a41e Fixes https://github.com/microsoft/vscode-internalbacklog/issues/5014 2024-08-14 13:30:40 +02:00
Don Jayamanne 391d289c85 Move creation of DiffCellModel to another layer (#225560)
* Move creation of DiffCellModel to another layer

* fixes
2024-08-14 19:43:22 +10:00
Benjamin Pasero 02057b6ec7 "vscode:" URL handler doesn't switch to the file's workspace if it is open (fix #225506) (#225584) 2024-08-14 10:26:54 +02:00
Johannes Rieken 6593979d4c improve action label for making an inline request (#225582)
use "Edit Code" when having a selection to operate on and "Generate" otherwise
2024-08-14 10:03:54 +02:00
Rob Lourens 084c0b3496 Disable broken chat compatibility notification (#225539)
* Disable broken chat compatibility notification

* Fix
2024-08-14 08:08:07 +02:00
Joyce Er 187e5d164d feat: support rendering chat references with just a display name (#225548)
* feat: support rendering references with just a display name

* Fix compile
2024-08-14 07:28:36 +02:00
Don Jayamanne b45f04309f Refactor nb diff viewmodel code to address leaks (#225456) 2024-08-14 10:26:30 +10:00
Tomer Chachamu 1900f9c05e Fix "Open Workspace Settings" when User Settings is open (fixes #148709) (#225311) 2024-08-14 02:05:06 +02:00
Michael Lively 61b6c87152 Shift output resource schema to common (#225536)
shift output panel schema
2024-08-13 16:39:01 -07:00
Andrea Mah feb75cb13a Adopt new search query structure (#225531)
Adopt new search query structure in preparation for new search API shapes. 

Pt 1 of trying to break down https://github.com/microsoft/vscode/pull/214041 into smaller PRs.

This will cause `beforeContext` to be ignored in the `findTextInFiles` API. This is because we will be using `surroundingContext` in the new API.
2024-08-13 16:29:52 -07:00
Connor Peet 676058f5c8 debug: support location references for variable values (#225546)
* debug: support location references for variable values

Adopts https://github.com/microsoft/debug-adapter-protocol/issues/343

Also tackles some debt around debug linkification, resolving an issue
where links had native hovers that conflicted with the rich hovers added
a few iterations ago. It still uses native hovers for links in some
contexts (plain text output in the debug console) because we don't pass
through element disposables there, but it uses workbench hovers when
there's not another rich hover being used (rich debug console output).

![](https://memes.peet.io/img/24-08-8aacba27-0903-4313-b7f6-6b3bbbff6970.png)

Closes #225425

* fix
2024-08-14 01:27:22 +02:00
Joyce Er 884c41615d fix: persist attachments on rerun chat requests (#225544) 2024-08-13 16:20:49 -07:00
Rob Lourens a9046c89b4 Remove obsolete api _version number (#225541) 2024-08-13 16:19:58 -07:00
Rob Lourens 4713458c2d Fix tool activation event (#225540) 2024-08-13 16:19:38 -07:00
Joyce Er 4796b22dd2 feat: support Attach Context in quick chat (#225538) 2024-08-14 00:38:05 +02:00
Devin Valenciano 91efe02e43 Merge pull request #225535 from microsoft/devalenc/remove-ces
Remove CES survey code remnants
2024-08-13 15:20:07 -07:00
Matt Bierner 34d0c50d0d Merge pull request #225534 from mjbvz/prime-baboon
Fix commit character list
2024-08-13 14:53:36 -07:00
Raymond Zhao e8065954d0 fix: mid-search rendering papercut (#225296)
Fixes https://github.com/microsoft/vscode/issues/224946
2024-08-13 14:52:16 -07:00
Devin Valenciano 0d79aac774 Remove import statement for CES survey 2024-08-13 14:38:05 -07:00
Matt Bierner c3fdd34df5 Fix commit character list
We were modifying the default commit character array, which ended up making it thousands of elements long
2024-08-13 14:36:56 -07:00
Megan Rogge cec4d65e7b fix terminalLinkQuickPick and decorationAddon disposable leaks (#225532) 2024-08-13 23:35:47 +02:00
Devin Valenciano 237feb0f81 Delete CES contribution file 2024-08-13 14:35:36 -07:00
Devin Valenciano 303eba4573 Remove reference to CES survey link 2024-08-13 14:33:33 -07:00
Megan Rogge 27dea3ff4b add value to pickOptions, fix abstractTaskService disposable leak (#225530) 2024-08-13 23:25:26 +02:00
Matt Bierner 4a4c36209f Remove old jsdoc link handling (#225529)
This code was used when TS Server didn't have support for `@link`. I think we can remove it now
2024-08-13 14:23:40 -07:00
Joyce Er 90b9cd02e0 fix: pick up intent detection metadata for chat commands (#225519)
* fix: pick up intent detection metadata for chat commands

* Make command disambiguation optional

* Make disambiguation collection more readable
2024-08-13 14:09:04 -07:00
Connor Peet ef72141fd1 testing: finalize test message stack trace API (#225517)
Closes #214488
2024-08-13 13:56:29 -07:00
Alex Ross ffee42566a Merge pull request #225526 from microsoft/alexr00/issue224794
Variable ${file} can not be resolved. Please open an editor.
2024-08-13 22:23:31 +02:00
Alex Ross a21a8d53d9 Variable ${file} can not be resolved. Please open an editor.
Fixes #224794
2024-08-13 22:07:08 +02:00
Connor Peet 4886bb5838 testing: make messages shown without a stacktrace take the whole peek (#225520) 2024-08-13 22:05:24 +02:00
Alex Ross c465946369 Merge pull request #225523 from microsoft/alexr00/issue224809
Cannot read properties of undefined (reading 'name')
2024-08-13 21:42:24 +02:00
Alex Ross 778e8937f2 Cannot read properties of undefined (reading 'name')
Fixes #224809
2024-08-13 20:52:30 +02:00
Matt Bierner f77615c76f Merge pull request #225518 from mjbvz/nuclear-reptile
Remove TS 3.x feature gates
2024-08-13 11:27:14 -07:00
Matt Bierner a116536a91 Remove TS 3.x feature gates
We see very, very low usage of these old TS versions. We also don't actively test them or fix bugs for them
2024-08-13 11:12:10 -07:00
Anthony Kim 37d001cd8b Add NuShell to core and separate out pwsh, python, julia, nu as GeneralShellType (#225335)
* start adding nu shell to core type

* remove unncessary regex attempt for nu

* add nu.exe to getShellType for WindowsShellHelper

* Separate out pwsh, python, julia, nu as GeneralShellType

* clean up to normal

* more cleanup
2024-08-13 10:16:11 -07:00
Matt Bierner 4f772f55eb Merge pull request #225457 from mjbvz/yodelling-flyingfish
Enable copy paste api for readonly editors
2024-08-13 09:59:55 -07:00
Joyce Er 6e2e6d235a refactor: rework chat participant detection invocation (#225511) 2024-08-13 18:55:33 +02:00
Johannes Rieken 018cece620 Merge pull request #225508 from microsoft/joh/real-mouse
store `locationData` on request and use when resending
2024-08-13 18:49:11 +02:00
Johannes c6950c2d87 store locationData on request and use when resending
there is propably more that should be stored on the request and reused like this but this change is deliberatly small so that can be a candidate fix too

https://github.com/microsoft/vscode-copilot/issues/7195
2024-08-13 18:08:59 +02:00
Andrea Mah 1c31e75898 fix focus on closeWidget (#214289)
* fix focus on `closeWidget`

* remove `disposeFromClose`
2024-08-13 09:00:34 -07:00
Johannes 4933da3c20 Revert "fix: resolve location data for rerun requests (#225299)"
This reverts commit 8723e832e6.
2024-08-13 17:45:04 +02:00
Jean Pierre a4f676a510 Fix search results don't automatically update on editor changes, if I move the Search view to another location (#215764)
Fixes #215437
2024-08-13 15:30:59 +00:00
Michael Lively bbd8da1268 Fix usage of editor.action.wordHighlight.trigger (#225447)
Fixes: #225065
2024-08-13 08:25:46 -07:00
Matt Bierner 41c881cb60 Merge branch 'main' into yodelling-flyingfish 2024-08-13 07:58:47 -07:00
Tyler James Leonhardt ca5b1b518f Dispose of listeners in quickPickPin and usages (#225449) 2024-08-13 07:40:21 -07:00
Jean PierreandMartin Aeschlimann dbd9418ff2 Fix explorer greys out any folder/item with the word "cut" (#225455)
* Fix #223791

* Fix build

* Fix build 2

* cleanup

---------

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2024-08-13 16:38:19 +02:00