8a45b1be23
fix: memory leak in menubar ( #198052 )
...
* fix: memory leak in menubar
* Update src/vs/base/browser/ui/menu/menubar.ts
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com >
* Update src/vs/base/browser/ui/menu/menubar.ts
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com >
* Update src/vs/base/browser/ui/menu/menubar.ts
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com >
* fix: potential memory leak when focusing another menu
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com >
Co-authored-by: SteVen Batten <sbatten@microsoft.com >
2023-12-20 16:15:34 -08:00
Tyler James Leonhardt and GitHub
c60da32708
Use the hover delegate in more UI components of Quick Pick ( #201339 )
...
This way we have a consistent hover UI
2023-12-20 16:03:44 -08:00
Tyler James Leonhardt and GitHub
468f6fca77
Don't use disposable Action and use IAction instead ( #201337 )
...
Turns out all of these disposables were not getting cleaned up... but they really don't need to be disposables in this context.
ref #201320
2023-12-20 15:13:18 -08:00
Connor Peet and GitHub
b964ed995a
eng: fix waitServer not working in unit test debug ( #201334 )
...
Fixes #182341
2023-12-20 14:09:46 -08:00
Benjamin Pasero and GitHub
651391e5ad
Aux window: fullscreen windows show custom title bar ( fix #201297 ) ( #201332 )
2023-12-20 22:12:08 +01:00
Daniel Imms and GitHub
86d1a94cca
Merge pull request #201325 from microsoft/tyriar/199845
...
Add move terminal into new window action/menu item
2023-12-20 11:21:50 -08:00
Daniel Imms
5764957b73
Add move terminal into new window action/menu item
...
Fixes #199845
2023-12-20 10:55:36 -08:00
Daniel Imms and GitHub
17e30760a3
Merge pull request #201324 from microsoft/tyriar/199848
...
Update xterm
2023-12-20 10:39:41 -08:00
Daniel Imms and GitHub
fffda8e1fe
Merge pull request #201323 from microsoft/tyriar/201303
...
Fix sticky scroll showing up on first line
2023-12-20 10:16:25 -08:00
Daniel Imms
d4e9b63073
Update xterm
...
Fixes #199848
2023-12-20 10:09:50 -08:00
Daniel Imms
896a06db1e
Fix sticky scroll showing up on first line
...
Fixes #201303
2023-12-20 10:01:21 -08:00
Shubh and GitHub
c9631868cd
Replace the deprecated canceled with Cancellation Error. ( #197605 )
...
Signed-off-by: Shubh <shubhisroking@gmail.com >
2023-12-20 18:23:01 +01:00
3051ae88b0
Fix #193468 - Fix bug with error notification when pressing "l" on non-expandable reference item. ( #199996 )
...
* Fix the bug that pressing l key on non-expandable reference item shows error notification (with vim extension)
* 💄
---------
Co-authored-by: João Moreno <joao.moreno@microsoft.com >
2023-12-20 18:14:09 +01:00
Martin Aeschlimann and GitHub
b7c53afaef
EditorActions don't pass on args ( #201315 )
2023-12-20 17:16:01 +01:00
Aiday Marlen Kyzy and GitHub
16894205b6
Changing from outputEditor to outputView ( #201290 )
...
changing outputEditor to outputView
2023-12-20 17:14:32 +01:00
Jithil P Ponnan and GitHub
01fc3110be
chore: replace deprecated octal escape sequences with hex ( #197518 )
2023-12-20 16:30:32 +01:00
João Moreno and GitHub
d95f2e01ab
undo general focus/selection preservation from lists and trees ( #201309 )
...
fixes #174768
fixes #127622
2023-12-20 16:28:45 +01:00
Daniel Imms and GitHub
199216cd48
Merge pull request #201306 from microsoft/tyriar/xterm_improvements
...
Add script for easy symlinking a local xterm repo
2023-12-20 07:22:13 -08:00
Daniel Imms
e3c70a49ba
Package and explain how to watch
2023-12-20 07:06:23 -08:00
Daniel Imms
48e0844029
Clarify link -> symlink
2023-12-20 06:49:28 -08:00
Daniel Imms
1eded319c6
Prefix all terminal scripts with xterm
2023-12-20 06:49:01 -08:00
Daniel Imms
aa4798b0d3
Add script for easy symlinking a local xterm repo
2023-12-20 06:48:21 -08:00
Daniel Imms and GitHub
75b1639461
Merge pull request #201301 from microsoft/tyriar/200409_2
...
Fix NPE in suggest
2023-12-20 06:18:09 -08:00
Benjamin Pasero and GitHub
80a0d88917
aux window - fix confirm on close ( #201300 )
2023-12-20 15:09:17 +01:00
Daniel Imms
dbe88b62d1
Fix NPE in suggest
...
Fixes #200409
2023-12-20 06:02:52 -08:00
Ladislau Szomoru and GitHub
b21537c2ef
Git - enable commit signing using SSH key ( #201298 )
2023-12-20 14:14:39 +01:00
Benjamin Simmonds and GitHub
d32043d8b8
Update group context keys on reload ( #201277 )
2023-12-20 12:22:45 +01:00
Johannes Rieken and GitHub
ce2710416a
update snippet escaping explainer ( #201274 )
2023-12-20 11:23:33 +01:00
Benjamin Simmonds and GitHub
a8edb8fac9
Support Centered Layout with Maximized Group ( #201229 )
...
* support centered layout with maximize group
* fix and add tests
2023-12-20 09:15:36 +01:00
Justin Chen and GitHub
deebd4f30a
Allow quick fixes to be shown in aux window ( #201262 )
...
* changed from domFocus to getFocus
* removed call to getfocus
2023-12-20 07:35:57 +01:00
Connor Peet and GitHub
68bc4c82c8
cli: update server prereq versions ( #201261 )
...
Fixes #201129
2023-12-20 14:27:09 +09:00
Matt Bierner and GitHub
9621add460
Fix undefined getting printed ( #201250 )
...
Fixes #201244
2023-12-20 00:22:43 +01:00
Raymond Zhao and GitHub
b48a213e0e
fix: parse Settings editor regular expressions more thoroughly ( #201248 )
2023-12-19 15:00:41 -08:00
Megan Rogge and GitHub
b7400557d1
Merge pull request #201242 from microsoft/merogge/disp-map
...
use `DisposableMap`
2023-12-19 16:34:31 -06:00
meganrogge
310aaa5309
fix #199374
2023-12-19 14:59:15 -06:00
b80a1c72f7
Fix race condition with restoration of problems when closing a file ( #183271 )
...
Fixes #47386
This sets the `flushOnListenerRemove` option to true for the call to
Event.debounce. Without this, some `onMarkerChanged` events can get
dropped -- specifically, when an event gets fired more than 100ms after
first listening, in which case the 600ms cleanup setTimeout fires while
the 500ms debounce timeout is still pending.
Co-authored-by: Megan Rogge <merogge@microsoft.com >
2023-12-19 20:55:30 +00:00
Megan Rogge and GitHub
6196ac5633
Merge pull request #201241 from microsoft/merogge/ab
...
check if the text will be executed before firing on did run text
2023-12-19 14:51:02 -06:00
Megan Rogge and GitHub
6833579d97
Merge pull request #201240 from microsoft/merogge/link-qp
...
fix bug with terminal accessible view
2023-12-19 14:38:39 -06:00
meganrogge
fba0b71a83
one more case
2023-12-19 14:35:01 -06:00
meganrogge
292c58a151
improve name
2023-12-19 14:34:03 -06:00
meganrogge
e5b980d17d
fix #199589
2023-12-19 14:31:53 -06:00
meganrogge
3bdc3097f1
fix #196644
2023-12-19 14:22:51 -06:00
Daniel Imms and GitHub
de809ac070
Merge pull request #201234 from microsoft/tyriar/200413
...
Allow pasting terminal text as single line
2023-12-19 11:34:07 -08:00
Robo and GitHub
972172bc98
fix: for message event data can be null ( #201237 )
2023-12-19 20:26:50 +01:00
Daniel Imms
10800648a5
Move clipboard test to use prompt, not confirm
2023-12-19 11:16:22 -08:00
Megan Rogge and GitHub
8ee37dc19a
Merge pull request #201082 from susiwen8/fix-201081
...
fix: `install` in `npm script` shouldn't be opened
2023-12-19 13:12:54 -06:00
Daniel Imms and GitHub
1324426117
Merge pull request #201235 from microsoft/tyriar/201184
...
Don't clobber BASH_REMATCH in SI
2023-12-19 10:22:51 -08:00
Johannes Rieken and GitHub
0603a4682b
allow strategies to control whole range deco, let live not render it ( #201224 )
2023-12-19 19:20:27 +01:00
Daniel Imms
ea5793254a
Don't clobber BASH_REMATCH in SI
...
Fixes #201184
2023-12-19 10:07:59 -08:00
Daniel Imms
bef5224016
Fix replace throwing
2023-12-19 10:00:02 -08:00
Tyler James LeonhardtandGitHub
Connor PeetandGitHub
Benjamin PaseroandGitHub
Daniel ImmsandGitHub
ShubhandGitHub
Martin AeschlimannandGitHub
Aiday Marlen KyzyandGitHub
Jithil P PonnanandGitHub
Ladislau SzomoruandGitHub
Benjamin SimmondsandGitHub
Johannes RiekenandGitHub
Justin ChenandGitHub
Matt BiernerandGitHub
Raymond ZhaoandGitHub
Megan RoggeandGitHub
meganrogge
RoboandGitHub