* check for thinking data before disablingThinking
* remove shouldDisableThinking method and its documentation
* refactor: check only for the most recent thinking content
Two things that we saw a lot of:
* `[createInstance] SemanticSearchTextSearchProvider depends on UNKNOWN service IRerankerService`
* `Error: Tests: either GITHUB_PAT, GITHUB_OAUTH_TOKEN, or GITHUB_OAUTH_TOKEN+VSCODE_COPILOT_CHAT_TOKEN must be set unless running from an IS_SCENARIO_AUTOMATION environment. Run "npm run get_token" to get credentials.
at StaticGitHubAuthenticationService.tokenProvider (/mnt/vss/_work/1/s/dist/test-extension.js:53806:11)`
So I:
* registed the rerankerservice
* registered a null auth service
Fixes https://github.com/microsoft/vscode-copilot/issues/18514
* nes: fix: cancel requestInFlight on cancellation token being set
* nes: joint: fix ghost-text provider returning no-op edits to UI
this would sometimes prevent good NES edits from being shown
* edits: fix hydrated edits from background sessions missing stops
Core merges seqential markdown blocks together. In normal edits they're broken up by (hidden) tool call parts for edits, but this was not the case for background agents. Simplest change is just making background agent edits work the same way as normal edits by emitting the tool call part.
Closes https://github.com/microsoft/vscode/issues/281633
* cloud: validate time stamps returned from gh api
* better
* Bad reference to agentSessionsViewLocation (fix#281752)
---------
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Josh Spicer <23246594+joshspicer@users.noreply.github.com>
Enables the same `no-unexternalized-strings` with have in `vscode` in this repo. This make sure we have a more consistent style across repos and when generating edits
* Run local eslint rules directly as typescript
Remove the need to use `tsx`
* Bump required node version
Matches the version we use in vscode repo
* Align node versions
* Always use `/`
* Try fixing windows
* Try another fix for windows
* Fix new rule after merge
* initial pass at untracked file changes, testing next
* add final trailing \n
* unit tests for function
* fix test execution
* tweak some comments and formattting
* another comment tweak after testing
* small change to handling fully empty files
* copilot PR feedback
---------
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro-2.local>
Co-authored-by: Ian Huff <ianhuff@Mac.home>
* nes: model picker: fix: correct init and model picking order
nes: fetched models should check if they're already known as well
nes: fix: ensure to update undesired models before updating preferred model
this's important because there's code that reacts to preferred model change and needs to know latest undesired models
nes: minimize failure possibility
nes: fix: make sure to init undesiredModelsManager earlier than observables use them
nes: don't memorize if exp-configured model is picked
nes: joint: support model picker
* nes: model picker: support in JointCompletionsProvider
* nes: enable model picker for the team
* nes: fetched models should check if they're already known as well
* nes: fix: ensure to update undesired models before updating preferred model
this's important because there's code that reacts to preferred model change and needs to know latest undesired models
* nes: minimize failure possibility
* nes: fix: make sure to init undesiredModelsManager earlier than observables use them
* nes: don't memorize if exp-configured model is picked