Commit Graph

90403 Commits

Author SHA1 Message Date
Matt Bierner
925807b77d Fix find on web not handling next properly
Fix #138275

Introduced by bbc10afeda

The root problem bbc10afeda fixed is that `window.find` starts after the current selection. If your document consists of `abc abcd` for example, the following happens:

1. Type `a` in the find box
1. The first `a` is correctly highlighted
1. Type `b` to refine the search
1. The search no longer sees the first `a`, so we skip ahead to the second `a`, which is unexpected

To fix this, I added code to collapse the selection before continuing the search. However we were also collapsing the selection when you hit the next button, which just resulted in the same word being re-selected again instead of skipping ahead to the next word.

This fix avoids collapsing the selection when you are simply pressing next
2021-12-06 16:28:24 -08:00
Matt Bierner
e88394000f Fix markdown outline for cases without a space after #
Fixes #138027
2021-12-06 15:58:11 -08:00
Daniel Imms
8bf3e4f34e Only restore terminal process name if source was api
Fixes #138509
2021-12-06 14:55:10 -08:00
Daniel Imms
9fca35e388 Pass locale to exthost for process revive date format
Fixes #136855
2021-12-06 14:39:44 -08:00
Raymond Zhao
e40596a16c Skip flaky updateImageSize suite
Ref #138499
2021-12-06 12:47:38 -08:00
Joyce Er
efd055b8ba Refresh markdown preview on all file changes (#138301)
* Refresh markdown preview on all file changes

* Don't watch `https`, `http`, and `data` uris
2021-12-06 12:36:22 -08:00
Megan Rogge
08fe3f2247 finalize terminal location API (#138530) 2021-12-06 12:03:15 -08:00
Rob Lourens
715754bc20 Remove 10k limit on copying text search results
Fix #138431
2021-12-06 12:02:43 -08:00
Rob Lourens
2fd934ec24 Use markdownDescription 2021-12-06 12:02:41 -08:00
Megan Rogge
33e67129bc fix #138359 (#138532) 2021-12-06 12:00:34 -08:00
Benjamin Pasero
13c0ed811e 🆙 playwright & set trace names (#138539) 2021-12-06 19:42:05 +01:00
Megan Rogge
32c2b3d4ff fix #138224 (#138538) 2021-12-06 10:40:14 -08:00
Johannes Rieken
59e6984ec4 fix https://github.com/microsoft/vscode/issues/138284 2021-12-06 19:31:18 +01:00
Alex Dima
7663e88b07 Fix treeshaking problems 2021-12-06 19:18:30 +01:00
Alex Dima
726f1252b1 Small improvements to types 2021-12-06 19:18:30 +01:00
Logan Ramos
18252333b6 Introduce onDidModelChange to the group (#137388)
* Add aggregate model event

* Switch to aggregate model events

* Use GroupChangeKind instead

* Switch to using GroupChange event

* Introduce an onDidModelChange

* Move group change to belong to the model

* Address comments

* editors - for now keep `GroupChangeKind' accessible via groups service

* one more

* avoid IEditorCloseEvent

* further avoid types

* simplify events

* clean up events

* fix reexport issue

* Address PR feedback

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2021-12-06 13:02:51 -05:00
Matt Bierner
cb1a286fd7 Use a unique authority for desktop webview too
Fixes #138409

This fix changes webviews on desktop to always use a unique authority instead of reusing the id passed in. In practice, this change should only effect internal webviews, such as those on extension pages or in getting started, since those were the only webviews that were using a hardcoded id

This aligns webviews on desktop with web.
2021-12-06 09:09:37 -08:00
Alex Dima
2fc1dac229 ICodeEditor.getContribution can return null 2021-12-06 17:57:09 +01:00
Alex Dima
2f898c4c98 Fixes #138157: Remove option _enableBuiltinExtensions 2021-12-06 17:57:08 +01:00
Megan Rogge
b03cce63f0 when view visibility changes, don't assume the panel should be focused (#138419) 2021-12-06 08:03:29 -08:00
Megan Rogge
e5c76ddbbd set shellType when it changes, fix #138388 (#138418) 2021-12-06 08:02:32 -08:00
Martin Aeschlimann
95a9378519 [json] add 'Clear schema cache' command. Fixes #138524 2021-12-06 16:56:17 +01:00
Johannes Rieken
1d4b413018 Merge pull request #137626 from dnicolson/add-singular-form-to-bispect-message
Add singular form of bisect message
2021-12-06 16:33:18 +01:00
Martin Aeschlimann
c515bf8c5e make sure theme is loaded when restoring it. Fixes #138422 2021-12-06 15:00:15 +01:00
Benjamin Pasero
2085b19a51 smoke - allow 30s max for deleting test path (#137725) 2021-12-06 14:09:02 +01:00
Johannes Rieken
4498f73ed7 fix https://github.com/microsoft/vscode/issues/138502 2021-12-06 13:56:11 +01:00
Benjamin Pasero
e8e0fb874d smoke - disable test that is flaky still 2021-12-06 13:44:01 +01:00
Sandeep Somavarapu
d52b2618a4 Merge pull request #138504 from microsoft/sandy081/ix138503
revert changes to User agent header
2021-12-06 12:55:32 +01:00
Johannes Rieken
22f7085a32 don't trigger suggest when composing characters, fixes https://github.com/microsoft/vscode/issues/132939 and fixes https://github.com/microsoft/vscode/issues/83428 2021-12-06 12:29:51 +01:00
Sandeep Somavarapu
61291e5145 revert changes to User agent header 2021-12-06 12:25:15 +01:00
Sandeep Somavarapu
72d8d114ab revert changes to User agent header 2021-12-06 12:20:11 +01:00
Benjamin Pasero
11d343aef8 storage - add whenInit property to join init phase 2021-12-06 11:19:30 +01:00
Benjamin Pasero
fe227dacb7 lifecycle - introduce and adopt finalVeto for backups (#138055) 2021-12-06 11:16:57 +01:00
Benjamin Pasero
e1caacebce backup - cancel pending operations on shutdown and handle cancellation better (#138055) 2021-12-06 10:55:33 +01:00
Benjamin Pasero
16d0a319b2 watcher - remove vscode-nsfw legacy watcher 2021-12-06 10:50:15 +01:00
Benjamin Pasero
8d61a33e38 editors - remove experimental experimentalDisableClearInputOnSetInput setting 2021-12-06 10:48:05 +01:00
Benjamin Pasero
cd648da82c sandbox - drop support for running file service in renderer 2021-12-06 10:46:51 +01:00
Benjamin Pasero
fb0f3d4f31 backups - prevent redundant backup on startup (fix #138497) 2021-12-06 10:40:22 +01:00
Johannes Rieken
84fce54d28 send file system info with dummy uri, https://github.com/microsoft/vscode-remote-release/issues/5714
this ensures uris undergo transformation and therefore file and vscode-remotes are handled correctlly
2021-12-06 10:35:48 +01:00
Johannes Rieken
96643fc3f5 update mywork milestone 2021-12-06 09:52:41 +01:00
Benjamin Pasero
4c98664778 editors - allow to close a dirty editor that is opened in another group split (fix #138442) 2021-12-06 08:39:39 +01:00
Chris Dias
d09289a2b6 update distro 2021-12-03 11:33:44 -08:00
Tyler Leonhardt
8541d5b225 Improve docs on QuickPickItem.picked. Fixes #138070 2021-12-03 10:50:06 -08:00
Martin Aeschlimann
f6da2394ae Remove browsing for file icon themes for security issues 2021-12-03 17:37:27 +01:00
Tyler Leonhardt
f0f375d7eb add text clarifying when buttons can be used. Fixes #138204 2021-12-03 08:23:00 -08:00
Logan Ramos
f0654a2f62 Fix #138361 2021-12-03 10:00:47 -05:00
Logan Ramos
d931b945a9 Bump distro 2021-12-03 09:13:01 -05:00
Alex Ross
c9aab8fca7 Fix tasks with linux to Windows remote
Fixes microsoft/vscode-remote-release#5989
2021-12-03 11:34:37 +01:00
Henning Dieterichs
39d5332d9b Merge pull request #138042 from microsoft/hediet/allowedCharactersRecord
allowed characters: string -> record
2021-12-03 09:51:31 +01:00
Sandeep Somavarapu
cca3e817a2 Fix #136334 2021-12-03 00:05:45 +01:00