Commit Graph

112239 Commits

Author SHA1 Message Date
Aaron Munger
9f71c049f4 Merge pull request #190440 from microsoft/aamunger/errorHtml
Only create HTML elements for links in notebook error output.
2023-08-14 13:27:30 -07:00
Justin Chen
afc07aa58e Action widget keyboard navigation shortcuts (#190432)
* bugfix on selected list item reverting and added important

* removed !important and added specificity

* added keyboard navigation functionality v1

* cleaning up fuzzy match behavior, added timeout

* cleaned up and added better fuzzymatching

* cleaned up and added better fuzzymatching

* reverting unused code change

* removed node.js timeout

* last bit of code cleanup
2023-08-14 12:59:23 -07:00
Alex Ross
5fd92586b4 Restore autoforwarded ports (#190442) 2023-08-14 12:46:16 -07:00
Joyce Er
0e60fe8d8a Show untitled editor chat hint even if editor has language (#190438) 2023-08-14 12:45:50 -07:00
Tyler James Leonhardt
ad3288d37d Return focus to where it came from (#190433)
The original checks were too shallow. They need to check recursively to handle the widget (chat) correctly. This uses `dom.isAncestor` in some important spots.

Fixes https://github.com/microsoft/vscode/issues/189968
2023-08-14 12:43:39 -07:00
Joyce Er
1edd786323 Merge pull request #190441 from microsoft/dev/joyceerhl/diplomatic-slug
Make file trees in chat responses accessible
2023-08-14 12:36:45 -07:00
Aaron Munger
4a2c8f805a remove unused variable 2023-08-14 12:03:17 -07:00
Joyce Er
0b8ba1e56f Read file tree count in chat response aria label 2023-08-14 12:01:41 -07:00
Joyce Er
d49b39b60e Allow enter to toggle tree collapse state 2023-08-14 12:01:40 -07:00
Joyce Er
d1bde5bd70 Fix focused chat response file tree border color 2023-08-14 12:01:39 -07:00
Joyce Er
ecb24a54a0 Add a11y hint for file tree focus command 2023-08-14 12:01:18 -07:00
Joyce Er
4daa545499 Support navigating to chat response file tree 2023-08-14 12:01:18 -07:00
Aaron Munger
3597d59152 Merge branch 'main' into aamunger/errorHtml 2023-08-14 11:49:27 -07:00
Aaron Munger
b9cd07d8bf move html link creation to linkify function 2023-08-14 11:44:28 -07:00
Tyler James Leonhardt
8ca2aef915 Fix typo in command name (#190428)
`Chat: Open Editor` was opening Quick Chat.
2023-08-14 18:14:35 +01:00
Henning Dieterichs
d72cb889ed Uses inputActiveOptionBackground as default for actionBar.toggledBackground 2023-08-14 18:45:24 +02:00
Henning Dieterichs
04dd69f669 Renders toggle state in action bar. Fixes #186403. 2023-08-14 18:45:24 +02:00
Tyler James Leonhardt
1dcbd07c45 Make QuickChat styles closer to QuickPick (#190101)
* Make QuickChat styles closer to QuickPick

This does two main things:
* introduces a "compact" chat style that generally reduces padding and other small things like makes avatars smaller
* Misc other styles to make quick chat more quick pick-y like using the same border radius and whatnot.

For now, it still has the titlebar, but I'll remove that once I have a better spot for the buttons.

* Rob feedback
2023-08-14 17:26:30 +01:00
Henning Dieterichs
d18b853f96 Fires partial accept event when augmented suggest item is accepted. 2023-08-14 18:00:29 +02:00
Aiday Marlen Kyzy
d6b2ced880 Update sticky scroll widget width on model change (#190410)
* update the widget width also on model change

* removing unecessary new line
2023-08-14 17:32:53 +02:00
Isidor Nikolic
b652d7e583 Merge pull request #190415 from microsoft/isidorn/hollow-antlion
remove file based recommendation - not effective
2023-08-14 17:32:17 +02:00
Henning Dieterichs
50a58a8b65 Use https (#190358) 2023-08-14 17:24:42 +02:00
Raymond Zhao
910aceb48e Make Settings inspect lazier (#190100) 2023-08-14 08:16:57 -07:00
Daniel Imms
6565a8b7ca Merge pull request #190417 from microsoft/tyriar/xterm_230814
xterm@5.3.0-beta.39
2023-08-14 08:01:57 -07:00
Alex Ross
0ea34aed3c Capture the errors that tunnel providers throw (#190282)
and show those errors to the user if the port forward was user initiated.
2023-08-14 08:01:20 -07:00
Daniel Imms
62fcea09f5 Merge pull request #190192 from andyleejordan/andyleejordan/iswindows
Guard `$IsWindows`
2023-08-14 07:58:08 -07:00
Daniel Imms
35e0b75d32 Merge pull request #190351 from Timmmm/sail_lines
Support . as a row:column separator in terminal link detector
2023-08-14 07:57:31 -07:00
Daniel Imms
0c6b510904 xterm@5.3.0-beta.39
Fixes #190374
Fixes #190371
2023-08-14 07:37:54 -07:00
Henning Dieterichs
bda54250c8 Fixes #190413 2023-08-14 16:16:43 +02:00
isidor
63b51768d0 remove file based recommendation - not effective
fixes https://github.com/microsoft/vscode/issues/188467
2023-08-14 16:05:07 +02:00
Henning Dieterichs
538698f1ac Fixes #188470 2023-08-14 15:28:49 +02:00
Daniel Imms
bf5538618f Update src/vs/workbench/contrib/terminal/browser/media/shellIntegration.ps1 2023-08-14 05:37:02 -07:00
Aiday Marlen Kyzy
f7f8fea209 Merge pull request #187698 from microsoft/aiday/limitingWidthOfHover
Limiting the width of the content hover to the content inside
2023-08-14 14:28:14 +02:00
Henning Dieterichs
11c5aa2370 Marks editor.experimental.asyncTokenizationVerification as experimental 2023-08-14 11:44:06 +02:00
Tim Hutt
b7ebbb6990 Update dev container node version (#190346)
VSCode requires version Node version 18-20, however 20 doesn't work because it is incompatible with `eslint-plugin-jsdoc@39.3.2`.

Fixes #190331
2023-08-14 16:47:40 +09:00
Connor Peet
b6b13f9670 up distro (#190376) 2023-08-14 08:37:19 +02:00
Daniel Imms
945442130e Add more test cases for new row.col pattern 2023-08-13 10:55:46 -07:00
Tim Hutt
a029c9576d Support . as a row:column separator in terminal link detector
The motivation here is the Sail language compiler which outputs errors conforming to the GNU style

https://www.gnu.org/prep/standards/html_node/Errors.html

I think they must be the only people in the world actually using the `line0.col0-line1.col1` format. I did have an attempt to capture the ending line/column but it is very difficult with regex, and not that useful anyway so I've opted for the simpler option of just ignoring the `-` part.
2023-08-13 10:37:50 +01:00
Connor Peet
2d9cc42045 testing: menu contribution points around messages (#190298)
- Implements the proposal in #190277 by adding a `contextValue` to
  TestMessages added to test runs.
- Make the `FloatingClickMenu` reusable outside the editor, and uses
  it to implement a `testing/message/content` contribution point.

With this extensions can do things like:

![](https://memes.peet.io/img/23-08-68e2f9db-abc4-4717-9da6-698b002c481c.png)
2023-08-12 08:03:01 -07:00
David Dossett
1b8729178c Remove background color for chat requests (#190297)
Don't use background color for chat requests
2023-08-12 07:58:25 -07:00
David Dossett
9ce4b05916 Align input part content with list content (#190299)
* Remove border top from input

* Bring back border, adjust metrics

* Remove border top
2023-08-12 07:57:49 -07:00
Megan Rogge
6cff4df147 Merge pull request #190279 from microsoft/merogge/hover-hint
fix hovers, make sure content is read before accessible view hint
2023-08-11 14:12:56 -07:00
Daniel Imms
9ba4f3ec5c Merge pull request #190289 from microsoft/tyriar/xterm_230811
Update xterm and fix several issues
2023-08-11 14:06:39 -07:00
meganrogge
98512a70f6 only call status if not '' 2023-08-11 13:55:37 -07:00
Daniel Imms
3ec4d30288 Adopt xterm cursorInactiveStyle and reduce type repetition
Fixes #190246
2023-08-11 13:40:46 -07:00
Daniel Imms
40e49b473f xterm@5.3.0-beta.32
Fixes #187082
Fixes #190270
Part of #190246
2023-08-11 13:39:47 -07:00
meganrogge
a7a8242b70 simplify 2023-08-11 13:22:04 -07:00
Alex Ross
ee88f3f4d2 Update no ports welcome to include local case (#190284) 2023-08-11 21:10:56 +01:00
Aaron Munger
87df237fb7 Merge pull request #190283 from microsoft/aamunger/outputDto
strip object down to dto for event
2023-08-11 13:08:55 -07:00
Aaron Munger
3f769af470 Merge pull request #190273 from microsoft/aamunger/scrollToggleFix
bump the version as part of resetting an output renderer
2023-08-11 12:55:20 -07:00