Commit Graph

109972 Commits

Author SHA1 Message Date
Matt Bierner aa82bd59b2 Limit worker pool size (#185164)
Fixes #185079

Should fix OOM issues on build machines
2023-06-14 23:57:22 +02:00
Daniel Imms e3f0f4a875 Merge pull request #184743 from microsoft/tyriar/183423
Remove deprecated shell/shellArgs/automationShell settings
2023-06-14 12:33:39 -07:00
Tyler James Leonhardt b07469d8e3 First move off of keytar (#185077)
* First move off of keytar

Since keytar is now deprecated, we need a solution going forward. That solution is the electron safeStorage API.

This PR:
* Uses the Electron safeStorage API for encryption
* Since we have encrypted strings we then store them in the StorageService (at the application & machine level)

This PR also refactors things quite a bit... a diagram of the change is going to be in the PR.

It gives embedders the ability to override the behavior of the secret storage similar to the existing Credential Provider embedder API... only with a better API surface since we no longer need to conform to keytar's shape.

More will come after this PR such as:
* Converting all CredentialService usages to SecretStorageService usages

After a while:

* Removing MainThreadKeytar
* Removing all the old code marked in this PR

* Use InMemoryStorageService

* use pausable emitter
2023-06-14 20:09:24 +02:00
Daniel Imms 64a8362d26 Merge branch 'main' into tyriar/183423 2023-06-14 10:43:14 -07:00
John Murray 9e5edb7d9a Allow downloads from pages viewed in Simple Browser (#185117) 2023-06-14 17:23:37 +00:00
Daniel Imms bacda501a4 Merge pull request #185145 from microsoft/tyriar/185033
Ensure pty host only adds --inspect when a port is set
2023-06-14 10:22:54 -07:00
Daniel Imms 9130ebd22a Ensure pty host only adds --inspect when a port is set
Fixes #185033
2023-06-14 10:08:17 -07:00
Johannes Rieken e209a1c94a skip Error.prepareStackTrace unit test for firefox and safari that don't support this (#185134) 2023-06-14 17:40:33 +02:00
Benjamin Pasero e1d89c9e9d 🆙 distro (#185133) 2023-06-14 17:24:15 +02:00
Aiday Marlen Kyzy e51bb8b70f Merge pull request #185129 from microsoft/aiday/makingButtonColorDifferentOnHover
Making the button background color lighter on hover
2023-06-14 16:58:18 +02:00
Benjamin Pasero 8afb685c9b eng - add checksum validation support to nodejs and extensions (#184877)
* eng - add `checksum` validation support to `remote`

* eng - wire in more `checksum` support

* eng - renames for remote fetching

* eng - renames for remote fetching

* eng - disable verbose

* eng - always fetch verbose in CI

* eng - 💄

* eng - add checksums for node

* eng - report checksum matches

* eng - fix build

* eng - warn when not being able to check sum

* eng - support checksums for built in extensions

* eng - clear todo

* eng - add nodejs metadata to product.json

* 🆙 version

* 🆙 distro

* update distro

* eng - switch to checksum file

* cleanup alpine

* fix alpine

* fix bug

* eng - fetch all from remote

* eng - 💄

* eng - print checksums

* eng - fix missing import

* 🆙 distro

* undo version change
2023-06-14 16:57:06 +02:00
Aiday Marlen Kyzy 21952a58bc simplifying the css 2023-06-14 16:41:42 +02:00
Connor Peet 13b1b90a83 tunnel: fix keyring panic on Linux (#185066)
tunnel: fix keyring panic on Linxu

Fixes #184792

Reported on https://github.com/hwchen/keyring-rs/issues/132
2023-06-14 23:34:03 +09:00
Johannes Rieken 9a8c0b6608 Merge pull request #184932 from thecrypticace/fix/no-prepare-rewrapping
Don’t re-wrap `prepareStackTrace` when assigned back to itself
2023-06-14 15:04:45 +02:00
Aiday Marlen Kyzy b4e06efba2 Merge pull request #185036 from microsoft/aiday/indentationOnInitOnly
Setting the margins only on the initial render
2023-06-14 12:59:54 +02:00
Aiday Marlen Kyzy d983c8498a review changes 2023-06-14 12:40:59 +02:00
Johannes 498bf5cc33 run gist test under the actual handler... 2023-06-14 12:10:01 +02:00
Benjamin Pasero 35c1f3e998 notifications - go back to showing toolbar in expanded notifications (#185094)
Otherwise hovering over long notifications can result in ugly flicker.
2023-06-14 12:08:36 +02:00
Johannes 6dc3d6c60e return _wasWrapped symbol but it only for wrapped functions, not the "original" handler, add unit tests 2023-06-14 12:03:16 +02:00
Sandeep Somavarapu f3aa9a201b fix #165202 (#185016) 2023-06-14 10:29:39 +02:00
Benjamin Pasero 04f7885c54 UNC allow list checks cannot be disabled in extension host (#184989) (#185083)
* UNC allow list checks cannot be disabled in extension host (#184989)

* Update src/vs/base/node/unc.js

Co-authored-by: Robo <hop2deep@gmail.com>

---------

Co-authored-by: Robo <hop2deep@gmail.com>
2023-06-14 10:25:30 +02:00
Aiday Marlen Kyzy 79c611d7b7 setting the margins inside of the case of initial render 2023-06-14 09:33:54 +02:00
Aiday Marlen Kyzy a1e93027e4 removing the useless variable 2023-06-14 09:31:48 +02:00
Aiday Marlen Kyzy 36dc6c03f9 Merge branch 'main' into aiday/indentationOnInitOnly 2023-06-14 09:21:53 +02:00
Aiday Marlen Kyzy 1ad238a760 Merge pull request #184598 from microsoft/aiday/positioningInlineChat
Adapt positioning of the inline chat
2023-06-14 09:17:40 +02:00
Benjamin Pasero 8e26c332de Warning message doesn't show up when code-insiders --status is run while no instances are open (#185080)
* Warning message doesn't show up when `code-insiders --status` is run while no instances are open (fix #185069)

* 💄
2023-06-14 08:43:26 +02:00
Peng Lyu bf5419f02d Update execution timer priorty to reserve some room. (#185076) 2023-06-13 21:24:18 -07:00
Peng Lyu 352d2d3934 Fix #184606. Fix updateCellMetadata incremental update. (#184964) 2023-06-13 17:45:22 -07:00
Don Jayamanne df2952cc9b Revert changes to listWidtget (#185071) 2023-06-14 10:25:15 +10:00
Rob Lourens 990d40aad4 Fix highlight on chat thumbs buttons (#185063)
The parent element used to also have the 'checked' class, now it doesn't, bisecting to figure out what happened
Fix microsoft/vscode-copilot-release#242
2023-06-13 15:53:21 -07:00
Megan Rogge 431f72c300 Merge pull request #185062 from microsoft/merogge/copilot-remove
rm copilot term fr help menu
2023-06-13 16:41:47 -05:00
Henning Dieterichs 20d8459c1d Implements simple caching for diff editor v2 (#185060) 2023-06-13 14:38:24 -07:00
cadinsl 34911a262b Edited user and workspace tab to only display the name for accessibility #184530 (#184627) 2023-06-13 14:06:45 -07:00
meganrogge b42cfb963c rm copilot term 2023-06-13 15:38:16 -05:00
Joyce Er 2e335d2df2 Update payload size limit (#185052) 2023-06-13 20:46:04 +02:00
Johannes Rieken f1b2a3a77f Use Lazy for creating diff and preview zone so that they don't block startup (#185041)
https://github.com/microsoft/vscode/issues/185034
2023-06-13 13:16:58 -05:00
Henning Dieterichs 470b6efc0c diff editor v2: sync update (#185039) 2023-06-13 13:16:39 -05:00
Benjamin Pasero 4b939d0a0e unc - fix path traversal bypass (#185048) 2023-06-13 19:56:46 +02:00
Aiday Marlen Kyzy d037fad589 changes from review 2023-06-13 18:29:50 +02:00
Joyce Er 9f70132f21 Fix storing cloud changes with deleted file (#185037) 2023-06-13 18:08:49 +02:00
Aiday Marlen Kyzy d85ee0f6c5 the margins are not set when not an initial render 2023-06-13 17:48:23 +02:00
Aiday Marlen Kyzy eb98edb838 changes from review 2023-06-13 17:23:55 +02:00
Aiday Marlen Kyzy c3275e4dd5 changes from review 2023-06-13 17:23:47 +02:00
Megan Rogge b7fd221daf Merge pull request #184011 from weartist/npm_link_fix
adjust to correct link
2023-06-13 10:06:16 -05:00
Johannes Rieken 00b14b2c62 update list of repos (#185019) 2023-06-13 16:19:30 +02:00
Megan Rogge 8a4ebd71a1 Merge pull request #184739 from max06/max06/issue184659
Restore ShellIntegration for fish (#184659)
2023-06-13 09:19:01 -05:00
Daniel Imms a656c218f0 Merge pull request #184919 from CodinGame/remove-side-effect-in-expected-pure-function
Remove side effect from `array.some` callback
2023-06-13 07:17:55 -07:00
Aiday Marlen Kyzy 0e8491bec7 changing the check to typeof undefined 2023-06-13 16:05:49 +02:00
Aiday Marlen Kyzy 59ef7faef9 adding the changes from the review 2023-06-13 15:59:49 +02:00
Benjamin Pasero ceb15e0fb7 Keyboard: the configure button in the notification pop is not accessible by tab key (fix #184711) (#185013) 2023-06-13 15:13:58 +02:00