Commit Graph

124626 Commits

Author SHA1 Message Date
Johannes Rieken ab2df1ffdc tweak chat file suggestions (#227991)
* mark result as incomplete in all cases
* don't include `#file:` in label
* tweak sorting
2024-09-09 16:52:51 +02:00
Aiday Marlen Kyzy d11799e9d2 Merge pull request #227989 from microsoft/rising-marmot
Reset the focus to the active element prior to the selection change in the EditContext
2024-09-09 16:34:37 +02:00
Robo 746ba5bc68 cli: revert "code server-web when offline" (#227981)
* Revert "Merge pull request #227830 from microsoft/connor4312/cli-offline-serve"

This reverts commit 136a5c6f5f, reversing
changes made to 9d388bbf8b.

* chore: bump distro
2024-09-09 16:21:08 +02:00
Aiday Marlen Kyzy 446a66e071 resetting the selection to what it was before the selection change 2024-09-09 16:15:05 +02:00
Ladislau Szomoru d0b2168a69 SCM Graph - improve picker rendering (#227970) 2024-09-09 14:41:20 +02:00
Ladislau Szomoru 3f0893b273 SCM - cleanup history provider proposed API (#227960) 2024-09-09 14:40:56 +02:00
Aiday Marlen Kyzy 7d6bfad180 Using the model state instead of view state in native edit context (#227965)
using the model state instead of view state in native edit context
2024-09-09 13:22:43 +02:00
hj 88d7b97c93 chore: rm unreached ignore items when build extensions. (#227906)
chore: rm unreached ignore items when compiling extensions.
2024-09-09 10:32:51 +00:00
Sandeep Somavarapu 9b4a6d5e5e fix #227778 (#227958) 2024-09-09 12:32:18 +02:00
Benjamin Pasero 6abee1b852 esm - restore ability to require.resolve with paths (#227934)
* esm - restore ability to `require.resolve` with `paths`

* fill in paths
2024-09-09 12:19:30 +02:00
Ladislau Szomoru 3ab41c2f69 SCM Graph - add branch picker (#227949)
* WIP - saving my work

* Extract HistoryItemRef picker

* Extract Repository picker

* Improve history item ref picker rendering

* Refactor color map

* Refresh the graph when the filter changes

* Push minor fix
2024-09-09 12:02:31 +02:00
Benjamin Christopher Simmonds 884cfb16a3 Reset traits after switching model (#227956)
reset traits after switching model
2024-09-09 11:55:46 +02:00
Johannes Rieken 65e0b66786 dynamic #file completions, fed from history and file search (#227950)
* dynamic #file completions, fed from history and file search

https://github.com/microsoft/vscode/issues/227946

* signal that there are more suggestions
2024-09-09 11:36:39 +02:00
Benjamin Christopher Simmonds b6b5da01c4 No tab bar handle closed editors (#227947) 2024-09-09 11:33:27 +02:00
Sandeep Somavarapu 5c97ba8357 log network requests in the process specific log (#227944) 2024-09-09 10:54:29 +02:00
Sandeep Somavarapu 56d050794d fix #227765 (#227943) 2024-09-09 10:45:46 +02:00
Sandeep Somavarapu 9b569af9a4 fix #226660 (#227920) 2024-09-08 23:53:33 +02:00
Daniel Imms 1b071a84f9 Merge pull request #227857 from microsoft/dependabot/npm_and_yarn/build/multi-f78246cd1a
Bump xml2js and @azure/core-http in /build
2024-09-07 06:56:31 -07:00
Peng Lyu f1f1413d68 Fix cell status bar target check (#227861) 2024-09-07 10:01:58 +02:00
Tyler James Leonhardt 533d8ec6a5 Rework eventing for PCAs and fix a few bugs along the way (#227854)
A big change, but a good one... This addresses some core issues around how we manage multiple PublicClientApplications (which are an object that should be created for each set of clientId,authority). Previously, we were doing some pretty nasty things to detect when a new PCA was created/deleted and as a result it would cause infinite loops and the likes...

Now we've focused on managing that in SecretStorage by looking for a `publicClientApplications` key. This is all encapsulated in the new `PublicClientApplicationsSecretStorage`.

Since we no longer relied on that hack, we still needed some way to have a PCA inform that:
* accounts have changed
* the last account was removed (signaling that this PCA could be disposed of in `PublicClientApplicationsSecretStorage`)

Both of these events have been added to `CachedPublicClientApplication` (now in its own file) and are being used. (replacing the old `_accountChangeHandler` which was hacky... true events are cleaner).

Last thing in the eventing space is that I try to minimize calls to `_storePublicClientApplications` so to not spam events across SecretStorage. You can see this in my usage of `_doCreatePublicClientApplication` over `getOrCreate`.

Couple random other things:
* `changed` accounts are properly bubbled up in `_onDidChangeSessionsEmitter` which is needed when a token is refreshed
* `getSessions` when no scopes are passed in no longer causes new tokens to be minted
* we use to only remove the first account we found but in some cases there may be the same account across different PCAs, so there's a `return` that's removed in `authProvider.ts` that fixes this bug
* Logging is clearer and more verbose (in a good way)
2024-09-06 21:03:25 -07:00
dependabot[bot] baa49e9f9c Bump xml2js and @azure/core-http in /build
Bumps [xml2js](https://github.com/Leonidas-from-XIV/node-xml2js) and [@azure/core-http](https://github.com/Azure/azure-sdk-for-js). These dependencies needed to be updated together.

Updates `xml2js` from 0.4.23 to 0.5.0
- [Commits](https://github.com/Leonidas-from-XIV/node-xml2js/commits/0.5.0)

Updates `@azure/core-http` from 3.0.0 to 3.0.4
- [Release notes](https://github.com/Azure/azure-sdk-for-js/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/Changelog-for-next-generation.md)
- [Commits](https://github.com/Azure/azure-sdk-for-js/compare/@azure/core-http_3.0.0...@azure/core-http_3.0.4)

---
updated-dependencies:
- dependency-name: xml2js
  dependency-type: indirect
- dependency-name: "@azure/core-http"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-07 02:49:29 +00:00
dependabot[bot] bc0764dcb1 Bump ansi-regex (#227785)
Bumps  and [ansi-regex](https://github.com/chalk/ansi-regex). These dependencies needed to be updated together.

Updates `ansi-regex` from 3.0.0 to 5.0.1
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](https://github.com/chalk/ansi-regex/compare/v3.0.0...v5.0.1)

Updates `ansi-regex` from 4.1.0 to 5.0.1
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](https://github.com/chalk/ansi-regex/compare/v3.0.0...v5.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-07 11:48:31 +09:00
dependabot[bot] 2a4d7851ef Bump pathval from 1.1.0 to 1.1.1 in /test/monaco (#227783)
Bumps [pathval](https://github.com/chaijs/pathval) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/chaijs/pathval/releases)
- [Changelog](https://github.com/chaijs/pathval/blob/master/CHANGELOG.md)
- [Commits](https://github.com/chaijs/pathval/compare/v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: pathval
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-07 11:43:31 +09:00
Connor Peet 976e68e620 eng: identify ternary expressions in selfhost runner (#227848)
Fixes #227222
2024-09-06 17:19:05 -07:00
Connor Peet f8785f8021 debug: fix some unsoundness in type convertsions in the ext host (#227846)
Refs #211878
2024-09-06 16:04:32 -07:00
Connor Peet 35676d1921 extensions: allow opening extension host CPU profile in the built-in profile viewer (#227834)
Fixes #227168

Also moves some old Action registrations to Action2 and uses proper
menu registration for context menu display.
2024-09-06 16:03:56 -07:00
Connor Peet 03f6dab0dd chore: bump distro (#227840) 2024-09-07 00:09:47 +02:00
Megan Rogge 2c8764ef26 add missing role to command center (#227824)
fix #227569
2024-09-07 00:03:57 +02:00
Connor Peet f8c0820a97 cli: fix vsda failure in main (#227835)
Fixes #227833
2024-09-06 23:31:52 +02:00
Alex Ross c6f85783f9 Allow @vscode/tree-sitter-wasm type import in more places (#227831)
Part of #227752
2024-09-06 13:45:56 -07:00
Aaron Munger 48dde95787 update code symbols in outline (#227638)
* lower limit for how many cells we can pre-cache symbols for, update cache when out of date

* update tests

* fix tests

* pre-cache symbols for the goto symbols view

* test precaching

* reset cached flag
2024-09-06 13:03:41 -07:00
Connor Peet 136a5c6f5f Merge pull request #227830 from microsoft/connor4312/cli-offline-serve
`code server-web` when offline
2024-09-06 12:53:10 -07:00
Rob Lourens 9d388bbf8b Align verified badge with first line of text (#227829)
For #227682
2024-09-06 21:35:09 +02:00
Connor Peet 077bd2f1b4 fixups
- Don't set a config option for update interval. We don't let the one
  in core be configurable, don't see a huge need for this.
- Don't start the server when the update is available
- Fix some race conditions
- Fix some clippy lints on Rust 1.81
2024-09-06 12:20:13 -07:00
Alex Ross 25f80c94c6 More detailed scopes in typescript.scm (#227828)
Part of #210475
2024-09-06 12:19:28 -07:00
Connor Peet cb285eb438 Merge remote-tracking branch 'RitamM16/cli-serve-web-offline-use-cache' into connor4312/cli-offline-serve 2024-09-06 11:21:45 -07:00
Johannes Rieken d0d802eb7f fix https://github.com/microsoft/vscode/issues/227797 (#227820) 2024-09-06 19:37:34 +02:00
Daniel Imms 768205d117 Merge pull request #227819 from microsoft/tyriar/227752
Fix easy terminal eslint suppressions
2024-09-06 10:28:17 -07:00
Daniel Imms b2c21ec755 Fix easy terminal eslint suppressions
Part of #227752
2024-09-06 10:08:42 -07:00
Tyler James Leonhardt 9d28a232cb Bump MSAL Node (#227815) 2024-09-06 18:39:14 +02:00
Benjamin Christopher Simmonds f621492f66 Fix label wrapping (#227782)
fix label wrapping due to ESM CSS change
2024-09-06 18:38:46 +02:00
Connor Peet 63729c8cbe eng: enable chromium browser debug in selfhost runner (#227814) 2024-09-06 18:34:49 +02:00
Benjamin Pasero eed219db5f ESM: figure out the monaco-standalone ESM build story (fix #227192) (#227536) 2024-09-06 18:26:40 +02:00
Benjamin Pasero cbcf121deb Merge pull request #227784 from microsoft/dependabot/npm_and_yarn/remote/micromatch-4.0.8
Bump micromatch from 4.0.5 to 4.0.8 in /remote
2024-09-06 16:44:39 +02:00
Martin Aeschlimann b4d7663d50 provide conversation as context to the map edit provider (#227790) 2024-09-06 16:40:49 +02:00
Benjamin Pasero 6f1101d812 Ignore tsserver requests for createDirectoryWatcher(~/Library) on macOS (#227788)
* Ignore tsserver requests for createDirectoryWatcher(~/Library) on macOS

* update deps

---------

Co-authored-by: Aman Karmani <aman@tmm1.net>
2024-09-06 16:25:54 +02:00
Henning Dieterichs 51b69d42b8 fixes multi diff editor performance issue (#227787) 2024-09-06 16:00:39 +02:00
dependabot[bot] e22e0f5bea Bump micromatch from 4.0.5 to 4.0.8 in /remote
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](https://github.com/micromatch/micromatch/compare/4.0.5...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-06 13:19:19 +00:00
Robo b5a6aa14a8 feat: switch to npm as default package manager (#226927)
* feat: move from yarn to npm

* chore: skip yarn.lock files

* fix: playwright download

* chore: fix compile and hygiene

* chore: bump vsce@2.17.0

Refs https://github.com/microsoft/vscode-vsce/commit/8b49e9dfdf909ad3af2b9ec9c825f5b501f6d75e

* test: update results for bat and sh colorizer tests

* fix: add missing lock files for windows

* fix: switch to legacy-peer-deps

* chore: update markdown-it@14.1.0

Refs https://github.com/markdown-it/markdown-it/commit/737c95a12976357df99652e4b51d831cac4a75aa

esbuild step in extensions-ci-pr was previously using markdown-it
from root which had userland punycode and was able to compile successfully.

* ci: increase pr timeout for windows integration tests

* chore: fix product build

* build: ignore extension dev dependency for rcedit

* build: fix working directory inside container

* build: fix dependency generation

* npm: update dependencies

* ci: use global npmrc

* ci: update cache

* ci: setup global npmrc for private npm auth

* build: fix extension bundling

* chore: sync npm dependencies

* ci: debug env variables for container

* ci: fix win32 cli pipeline

* build: fix npmrc config usage for build/ and remote/ dirs

* fix: windows build

* fix: container builds

* fix: markdown-language-features tests and bundling

```
[03:58:22] Error: Command failed: /Users/demohan/.nvm/versions/node/v20.15.1/bin/node /Users/demohan/github/vscode/extensions/markdown-language-features/esbuild-notebook.js --outputRoot /Users/demohan/github/vscode/.build/extensions/markdown-language-features
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds userland package based on https://github.com/markdown-it/markdown-it/commit/beed9aee2c1b44819afc25d485e86a6c699b6ef0

* fix: container builds for distro

* chore: update yarn occurrences

* fixup! chore: bump vsce@2.17.0

Uses the closest version to `main` branch that does not
include https://github.com/microsoft/vscode-vsce/commit/d3cc84cdec99b8e9f24be63d1a2a54abe908f68b
while still having the fix https://github.com/microsoft/vscode-vsce/commit/8b49e9dfdf909ad3af2b9ec9c825f5b501f6d75e

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: sync npm dependencies

* chore: throw error when yarn is used for installation

* chore: add review feedback

* chore: switch exec => run where needed

* chore: npm sync dependencies

* fix: markdown-language-features bundling

```
✘ [ERROR] Could not resolve "punycode"

    extensions/markdown-language-features/node_modules/markdown-it/lib/index.js:14:27:
      14 │ var punycode     = require('punycode');
         ╵                            ~~~~~~~~~~

  The package "punycode" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
```

Adds missing userland package based on markdown-it/markdown-it@beed9ae,
can be removed once we update markdown-it >= 14.1.0

* ci: rename no-yarn-lock-changes.yml

* chore: sync npm dependencies

* ci: restore no-yarn-lock-changes.yml

We can disable it in a separate PR to keep the required
checks happy and also need workflow edit perms.

* chore: sync npm dependencies

* ci: rebuild cache

* ci: fix no-package-lock-changes.yml

* chore: bump distro

* chore: rm yarn.lock files

* chore: rm yarn.lock files without dependencies

* chore: add vscode-selfhost-import-aid to postinstall dirs

* chore: bump distro
2024-09-06 22:18:02 +09:00
Ladislau Szomoru 5ae8ffb7e3 SCM Graph - set the groundwork to show all history item groups (#227780) 2024-09-06 15:12:48 +02:00