* Revert "Revert "Stop the cursor from jumping when changing prefix in QuickAcc…"
This reverts commit 348e88dc00.
* Only keep the selection if the value is unchanged
---------
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
* Enable duplicate chat participant names
#208103
* Register participants with an ID
* Update participant history in API
* Changes to dupe chat suggest widget, and fix serialize/deserialize
* Tweaks
* Test fixes
* Fix tests
* Test fixes
* Fix integration test
* add command to open cell error diagnostic quickfix menu
* add keybinding, filter actions
* context key for has cell diagnostics
* clear diagnostics on content change
* Fix for file link with relative path
* Removed redundant comments
* Simplify fix to accomodate Windows paths
---------
Co-authored-by: Sidebail <vova.vatsurin@gmail.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
1. Separator descriptions no longer include opacity so that contrast ratio is satisfied
2. The separators are now a little taller so that they stand out compared to regular items
* Add support for separate primary cursor color when multiple cursors are present
- Does not change the existing behavior when there's a single cursor. editorCursor.foreground and background are still used.
- Add editorCursor.multiple.primary.foreground and background theme colors for the primary cursor. Only used when multiple cursors exist. Fallback to editorCursor.foreground/background when theme colors aren't set.
- Add editorCursor.multiple.secondary.foreground and `background theme colors for non-primary cursors. Only used when multiple cursors exist. Fallback to editorCursor.foreground/background when theme colors aren't set.
Add cursor-primary and cursor-secondary html classes to target with cursor color styles. No new class is introduced in the single-cursor case.
- Currently does not affect overview ruler colors. editorCursor.foreground is still used, even when multiple cursors are present.
* Update overview ruler to use primary and secondary cursor colors
- This maintains the existing handling for colors being undefined. However, each of these colors have defaults do I'm not sure if it's actually possible for them to be undefined
* Fix formatting
* Fix compilation errors
* Fall back to the existing cursor colors (to avoid breaking existing themes)
---------
Co-authored-by: Alex Dima <alexdima@microsoft.com>
This allows the full-length separators to have tooltips and descriptions.
(They had support for tooltips already, but my refactoring to a tree broke that)
so really this just adds descriptions and fixes tooltips. Because of this, we now adopt the description in favor of the tooltip for QuickSearch
* Split CursorControl.revealPrimary and IViewModel.revealPrimaryCursor into "reveal all" and "reveal primary" variants
- The original name was a lie. It wasn't revealing the primary cursor, it was revealing all cursors.
- Some things actually want to reveal the primary cursor specifically, such as editor.action.focusNextCursor. If the set of cursors do not all fit in the view and the primary cursor is not currently visible the primary cursor should be revealed.
- Other things want to reveal all cursors, such as cursorMove. However, there's likely room for improvement here as well: if the set of cursors do not all fit in the view and none of them are visible the closest cursor should probably be revealed.
- All existing locations have been updated to use "reveal all" which maintains the exact same behavior as before. Locations that want to use the primary variant will be updated in a separate commit.
* Update editor.action.focusPreviousCursor and focusNextCursor to reveal the primary cursor
---------
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Aiday Marlen Kyzy
Justin Chen
Anthony Stewart
Rob Lourens
Tyler James Leonhardt
Aaron Munger
Matt Bierner
Fizz
VLADIMIR VATSURIN
Ulugbek Abdullaev
Bhavya U
Adam Byrd
Connor Peet
Hylke Bons
Benjamin Christopher Simmonds
Sandeep Somavarapu
Alex Ross
Marshall Roch