Commit Graph

149639 Commits

Author SHA1 Message Date
Rob Lourens
c065b175fd Add argument parsing, suite filtering, and grep support to integration test scripts (#305837)
* Add argument parsing, suite filtering, and grep support to integration test scripts

- Add --run, --runGlob, --grep, --suite, and --help argument parsing
- --suite selects extension host test suites (comma-separated, glob patterns)
- --grep forwards test name filter to all runners via MOCHA_GREP env var
- Validate --suite filter matches at least one known suite
- Add MOCHA_GREP support to testrunner.js, CSS and HTML test runners
- Seed user settings to suppress dock bounce notifications
- Always apply *.integrationTest.js glob for node.js tests
- Add integration-tests skill documentation

* Address Copilot review feedback

- Quote cd $ROOT, rm -rf $VSCODEUSERDATADIR, rmdir %VSCODEUSERDATADIR%
- Quote --runGlob pattern to prevent premature glob expansion
- Use GREP_ARGS array for safe grep forwarding in .sh
- Use conditional call with proper quoting for grep in .bat
- Deduplicate suite list into KNOWN_SUITES variable
- Remove unused EXTRA_ARGS and ARGS variables from .bat

* Fix Windows CI: remove unnecessary enabledelayedexpansion

The original script used plain 'setlocal'. Adding 'enabledelayedexpansion'
may affect path resolution behavior on Windows CI. Since no delayed
expansion (\!var\!) syntax is used, revert to the original 'setlocal'.

* Fix Windows CI: capture %~dp0 before call :label corrupts it

In Windows batch, 'call :label' can change what %~dp0 resolves to.
Our should_run_suite subroutine uses 'call :should_run_suite', which
caused %~dp0 to resolve to the wrong directory for extension paths
that appear after the subroutine call. Capture the script directory
once at startup into %SCRIPT_DIR% and use it everywhere.
2026-03-28 11:23:37 +11:00
Kyle Cutler
2de60eada5 Better syncing of "share with agent" status (#305854) 2026-03-27 17:11:21 -07:00
Justin Chen
3f19f148dc show a warning when there are more than 20 images in a request (#305817)
* show a warning when there are more than 20 images in a request

* address comments
2026-03-27 16:59:47 -07:00
Rob Lourens
5be9778feb agentHost: Apply default edit auto-approve patterns on AH side (#305859)
* agentHost: Apply default edit auto-approve patterns on AH side
Fix #305308

Co-authored-by: Copilot <copilot@github.com>

* Add integration test

Co-authored-by: Copilot <copilot@github.com>

* Fixes

---------

Co-authored-by: Copilot <copilot@github.com>
2026-03-27 23:59:18 +00:00
Ladislau Szomoru
b8b841a44f Sessions - extract code to enable loading changes async (#305847) 2026-03-27 16:05:58 -07:00
Paul
b98ad1eadb Send extension ID for customizations (#305796) 2026-03-27 22:31:09 +00:00
Ladislau Szomoru
ca0ea977c6 Sessions - add missing context key (#305844) 2026-03-27 22:30:48 +00:00
Kyle Cutler
fe491c0c10 Fix "add element to chat" while debugging (#305831)
* Fix "add element to chat" while debugging

* Update src/vs/platform/browserView/electron-main/browserViewElementInspector.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 22:23:37 +00:00
Matt Bierner
c17175997a Merge pull request #305841 from mjbvz/dev/mjbvz/functional-shark
Make sure main thread chat session models use overrides from live model
2026-03-27 15:16:11 -07:00
Josh Spicer
cb39101990 chat: fix customization provider harness deduplication, grouping, and badges (#305810)
* test: add tests for external harness replacement behavior

* feat: enhance external customization item handling with storage inference and instruction enrichment

* refactor: remove workspaceSubpaths from chat session customization metadata

* Copilot CLI session 6be53c25-3ac3-44c2-97f1-846de07165de changes

* refactor: extract shared buildInstructionListItem and document provider API

Extract the instruction classification logic (applyTo parsing, badge
generation, groupKey assignment) into a shared buildInstructionListItem
method used by both the built-in and provider item paths.

Remove the instruction-specific enrichInstructionItemsFromProvider in
favor of inline logic in fetchItemsFromProvider that delegates to the
shared helper.

Add a section to the chat-customizations-editor skill documenting the
chatSessionCustomizationProvider proposed API flow.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR review — disposal fallback and agent instruction grouping

Fix disposal fallback: when an external harness that overrides a static
one is disposed, keep the active harness on the same id since the static
harness is restored. Only fall back to all[0] when no harness with that
id remains.

Fix agent instruction grouping: buildInstructionListItem now detects
well-known agent instruction files (AGENTS.md, CLAUDE.md, CLAUDE.local.md,
copilot-instructions.md) and assigns groupKey 'agent-instructions' so
they appear under the correct header for both built-in and provider items.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* revert: remove skill file edits to avoid merge conflict

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-27 22:15:33 +00:00
Courtney Webster
8d8e32fe55 Merge pull request #305723 from microsoft/open-wren
Add experiment for sign in button in title bar
2026-03-27 17:08:18 -05:00
Ladislau Szomoru
cbc57242ed Sessions - wire up the discard changes action (#305830) 2026-03-27 22:04:27 +00:00
Matt Bierner
dd1cba9356 Make sure main thread chat session models use overrides from live model 2026-03-27 14:55:31 -07:00
Josh Spicer
7efa1c5c0d chatCustomizations: support grouping and badges for external provider items (#305813)
* feat: enhance AICustomizationListWidget with grouping and badge support for external customization items

* feat: add user data profile service and infer storage from URI in AICustomizationListWidget

* Copilot CLI session 8af2fd4a-10fe-4bba-b408-f1b90cebc8dc changes

* docs: add chatSessionCustomizationProvider API chain to customizations editor skill

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address PR review feedback

- Remove duplicate sectionToIcon, reuse getSectionIcon instance method
- Use Map for O(1) groupKey lookups instead of O(n²) includes/find
- Check active project root in inferStorageFromUri for Sessions window
- Set pluginUri on provider items and use it for storage inference
- Remove redundant plugin check from inferStorageFromUri (handled by caller)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-27 21:48:27 +00:00
vs-code-engineering[bot]
958f822bbe Update distro commit (main) (#305764)
Update distro commit to 3431ef6b

Co-authored-by: vs-code-engineering[bot] <122617954+vs-code-engineering[bot]@users.noreply.github.com>
2026-03-27 21:32:46 +00:00
dependabot[bot]
c7de0877e0 Bump octokit/request-action from 2.4.0 to 3.0.0 (#305135)
Bumps [octokit/request-action](https://github.com/octokit/request-action) from 2.4.0 to 3.0.0.
- [Release notes](https://github.com/octokit/request-action/releases)
- [Commits](dad4362715...b91aabaa86)

---
updated-dependencies:
- dependency-name: octokit/request-action
  dependency-version: 3.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2026-03-27 14:20:43 -07:00
Courtney Webster
48a530373d Merge branch 'main' into open-wren 2026-03-27 16:16:55 -05:00
dependabot[bot]
e49f2d1a54 Bump node-forge from 1.3.2 to 1.4.0 in /extensions/vscode-api-tests (#305343)
Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.3.2 to 1.4.0.
- [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md)
- [Commits](https://github.com/digitalbazaar/forge/compare/v1.3.2...v1.4.0)

---
updated-dependencies:
- dependency-name: node-forge
  dependency-version: 1.4.0
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-03-27 14:15:43 -07:00
dependabot[bot]
fca9a7879f Bump picomatch from 4.0.3 to 4.0.4 in /test/mcp (#304949)
Bumps [picomatch](https://github.com/micromatch/picomatch) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](https://github.com/micromatch/picomatch/compare/4.0.3...4.0.4)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 4.0.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2026-03-27 14:14:17 -07:00
dependabot[bot]
5933225fdb Bump picomatch from 4.0.3 to 4.0.4 in /test/smoke (#304972)
Bumps [picomatch](https://github.com/micromatch/picomatch) from 4.0.3 to 4.0.4.
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](https://github.com/micromatch/picomatch/compare/4.0.3...4.0.4)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 4.0.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2026-03-27 14:14:13 -07:00
Elijah King
44bc7753d6 Merge pull request #305759 from microsoft/eli/chat-export-import-icon
add chat import and export icons to agent debug logs
2026-03-27 14:04:50 -07:00
Pierce Boggan
27505178e3 Merge pull request #294777 from microsoft/pierceboggan/fix-@
@ can be used to reference context, just like #
2026-03-27 14:57:53 -06:00
Ladislau Szomoru
e92b212dac Sessions - more improvements to the changes view (#305797)
* Changes - polish changes filter

* Add some spacing to the picker

* Changes - fix panel rendering when there are no changes
2026-03-27 13:57:29 -07:00
cwebster-99
fea130899c polish 2026-03-27 15:41:55 -05:00
Pierce Boggan
36ab523bba Merge branch 'main' into pierceboggan/fix-@ 2026-03-27 14:36:46 -06:00
Pierce Boggan
8dd3661e5e Merge main, remove duplicate re-export, update notebook import
Resolve merge conflict with origin/main. Remove duplicate re-export
from chatInputCompletions.ts (line 72) per review feedback. Update
notebook.chat.contribution.ts to import directly from
chatInputCompletionUtils.ts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-27 14:04:47 -06:00
Benjamin Pasero
0496f93688 sessions: use plus icon for Add Chat (#305791)
* docs - update command center actions in layout spec

* sessions: drop Add Chat layout docs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-27 20:03:34 +00:00
Rob Lourens
b7be16b645 Fix customization file resolution errors for remote agent host sessions (#305767)
Fix errors about loading customizations in remote agenthost workspaces
2026-03-27 13:02:05 -07:00
Anthony Kim
1d01418cd5 Revert terminal editor regressions #298688 , #302139 (#305782) 2026-03-27 12:56:28 -07:00
cwebster-99
9d6cdc36f7 Polish for experiment gating 2026-03-27 14:53:27 -05:00
Logan Ramos
2056bef1cf Don't use trusted telemetry value on model ids (#305760)
* Don't use trusted telemetry value on model ids

* Update src/vs/workbench/contrib/editTelemetry/browser/telemetry/aiEditTelemetry/aiEditTelemetryServiceImpl.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Regex

* tests

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 12:34:01 -07:00
Kyle Cutler
678825d644 Browser view native "add to chat" features (#305745)
* Browser view native "add to chat" features

* safe parsing, better pseudo handling
2026-03-27 11:50:48 -07:00
Bhavya U
483f2ca1d5 Add telemetry for chat todo list widget interactions (#305747) 2026-03-27 11:49:40 -07:00
Connor Peet
fa311ecf8f Merge pull request #305348 from microsoft/connor4312/edit-metadata
agentHost: add session-specific metadata
2026-03-27 11:44:24 -07:00
Hawk Ticehurst
3fba4f2d00 sessions: adjust workspace picker empty state text segmentation (#305750) 2026-03-27 14:34:22 -04:00
Paul
402ffd2793 Allow intellisense for troubleshoot skill (#305702) 2026-03-27 11:29:07 -07:00
Matt Bierner
0f6c3beea6 Merge pull request #305756 from microsoft/revert-291825-child-process
Revert "Replace child_process.exec with execFile to prevent potential command injection"
2026-03-27 11:18:45 -07:00
Elijah King
53f549514a registered in codicons.ts 2026-03-27 11:16:36 -07:00
Lee Murray
510195d638 Sessions: Update no changed files message and adjust styles in changes view (#305751)
* style: add padding adjustment for action widget list rows

Co-authored-by: Copilot <copilot@github.com>

* style: update welcome message and adjust padding and icon size in changes view

Co-authored-by: Copilot <copilot@github.com>

* Update src/vs/sessions/contrib/changes/browser/changesView.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 18:15:07 +00:00
Elijah King
c53d64b94e Merge branch 'main' into eli/chat-export-import-icon 2026-03-27 11:08:00 -07:00
Elijah King
89569842dc add chat import and export icons to agent debug logs 2026-03-27 11:04:25 -07:00
Kalash Thakare ☯︎
6ef843ff0b fix: remove persistent focus outline on walkthrough step checkbox click (#300872)
When clicking a walkthrough step checkbox in an expanded step, a blue
focus border appeared and persisted until clicking elsewhere. This was
caused by the codicon element receiving tabindex='0' when the step
expands, making it focusable on mouse click with no CSS rule to suppress
the default outline.

Added :focus (outline: none) and :focus-visible (outline with focusBorder)
rules for .getting-started-step .codicon, mirroring the existing pattern
used for button elements in the same file.
2026-03-27 17:59:34 +00:00
Lee Murray
a29c4cf52b Increase minimum width of AuxiliaryBarPart (#305741)
* fix: increase minimum width of AuxiliaryBarPart to improve layout

Co-authored-by: Copilot <copilot@github.com>

* Update src/vs/sessions/browser/parts/auxiliaryBarPart.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 17:57:43 +00:00
Matt Bierner
187a98616b Revert "Replace child_process.exec with execFile to prevent potential command injection" 2026-03-27 10:57:37 -07:00
Rob Lourens
81a487a2a0 Don't show a terminal error when opening remote agent-host sessions (#305744) 2026-03-27 17:56:23 +00:00
Lee Murray
7401c12e7e Adjust padding for secondary action buttons in changes view (#305738)
style: adjust padding for secondary action buttons in changes view

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
2026-03-27 10:55:07 -07:00
Matt Bierner
21dedfa8de Merge pull request #305739 from mjbvz/dev/mjbvz/short-shark
Delete pointless test
2026-03-27 10:54:50 -07:00
Lee Murray
2b75555f55 Increase font weight for session title label (#305736)
style: increase font weight for session title label

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
2026-03-27 10:54:33 -07:00
Lee Murray
b8b0273793 Improve badge visibility with updated styles (#305734)
style: update badge background and text color for improved visibility

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
2026-03-27 10:54:14 -07:00
Yogeshwaran C
7466d76783 fix: modernize HTML sample snippet (#304818)
Update the built-in HTML sample snippet to follow current web standards
and reduce unnecessary boilerplate:

- Add lang attribute to <html> tag as first tab stop (W3C recommended)
- Remove outdated IE compatibility meta tag (IE is no longer supported)
- Remove unnecessary type='text/css' and media='screen' from <link>
  (default values in HTML5)
- Remove <script> tag (modern templates often handle scripts differently)
- Move viewport meta before title (following common convention)

Fixes #272331

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2026-03-27 10:25:15 -07:00