Matt Bierner
c847df3d25
Remove some unused locals and types
2017-11-07 11:23:20 -08:00
Matt Bierner
7ac8e49eb0
Add additional no unused checks for merge-conflict extension
2017-11-07 11:22:08 -08:00
Matt Bierner
52f45af7f0
Add additional no unused checks for php extension
2017-11-07 11:22:07 -08:00
Ramya Achutha Rao
b1747e7b5f
Clear tsignores under suggest folder #37212
2017-11-07 11:19:45 -08:00
Ramya Achutha Rao
583e14c2ec
Add noUnusedLocals to emmet extension #37212
2017-11-07 11:16:38 -08:00
Ramya Achutha Rao
a458da4afb
Clear tsignores under extensions folder #37212
2017-11-07 10:55:02 -08:00
Matt Bierner
ea5d70687b
Fix dom on for TS's strict function mode ( #37748 )
...
**background**
TS 2.6 introduces a new strict function checking mode. This can catch many common mistakes such as patterns like this:
```js
function on(callback: (Base) => void) { ... }
on((e: Sub) => {...});
```
This does an implicit cast in the call to `on`. With strict function checking, this is now flagged as an error
**Change**
This change fixes dom.on so that it works with strict function checking. This done by making it generic so that the type of the event taken in the callback can be inferred from the callback itself.
2017-11-07 10:31:55 -08:00
Benjamin Pasero
7bf5879ce0
tslint input for #37212
2017-11-07 18:55:59 +01:00
Benjamin Pasero
3fbbfabac7
fix compile
2017-11-07 18:14:55 +01:00
Johannes Rieken
6dc7e364d7
debt - remove some ts-ignored things
2017-11-07 17:23:19 +01:00
Johannes Rieken
d2cc96626b
don't unneccessary fire event when calling ContextKey#removeValue
2017-11-07 17:07:24 +01:00
Erich Gamma
c536efdfbc
Enabled the noUnusedLocals and added @tsignore
2017-11-07 13:13:41 +01:00
Benjamin Pasero
c1bfc05014
restore editor first (for #37541 )
2017-11-07 12:58:34 +01:00
Dirk Baeumer
8bf5e26374
Fixes #7353 : Running build task in Code approximately 50% slower than in terminal
2017-11-07 12:44:01 +01:00
Johannes Rieken
ab17bb71f6
add a new lifecycle event Restoring which is set when the editors/viewlets are being restored (start). also in the lifecycle service replace onDidChangePhase with when
2017-11-07 12:24:01 +01:00
Erich Gamma
b94569fe0d
tslint5 adoption - fix semicolon rule
2017-11-07 12:08:22 +01:00
Erich Gamma
56111c9cc6
update to tslint5
2017-11-07 12:08:22 +01:00
Benjamin Pasero
968934c141
Speed up registerTextMime ( fixes #37521 )
2017-11-07 11:59:26 +01:00
Benjamin Pasero
636be803c6
inline electron references ( #37766 )
2017-11-07 11:11:18 +01:00
isidor
32a8a5c2ab
debug: process.session.root can be undefined
...
fixes #37559
2017-11-07 11:11:07 +01:00
Johannes Rieken
479910d9a4
undo late extension host launch, #37751
2017-11-07 10:56:05 +01:00
Benjamin Pasero
1ed949e72a
Explorer: loading progress shows without delay on startup ( fixes #37622 )
2017-11-07 07:53:26 +01:00
Rob Lourens
3f9457a750
Add setting to specify auto-ingesting settings search feedback
2017-11-06 20:46:09 -08:00
Matt Bierner
f11f9aac5f
Enable noImplicitAny and noUnused in js extension
2017-11-06 17:28:34 -08:00
Matt Bierner
7b3929a893
Fix a few callback casts for strictFunctions
...
With TS 2.6's strict functions mode, you cannot use a subclass in place of a parent parameter type in a callback
2017-11-06 16:19:32 -08:00
Matt Bierner
de93fea905
Fix some strict function mode tests in queryBuilder
...
TS cannot properly infer the types in this case
2017-11-06 16:19:32 -08:00
Rob Lourens
6c19ff14a4
Merge pull request #37742 from mjbvz/php-ext-strict
...
Move PHP extension to strict mode
2017-11-06 16:54:27 -07:00
Christof Marti
494be36401
Remove Python for upcoming rename ( #37745 )
2017-11-06 15:47:17 -08:00
Matt Bierner
6bab0e0cc0
Move PHP extension to strict mode
...
Compile the PHP extension with strict mode TS. Mostly adding annotations where values can be null or undefined.
2017-11-06 14:36:56 -08:00
Matt Bierner
e5b9b820ef
Move vscode-api-tests to strict
2017-11-06 14:32:01 -08:00
Matt Bierner
ae0519c17e
Use const where ever possible in JS ext
2017-11-06 14:30:07 -08:00
Matt Bierner
7cba0cd7ee
Move python extension to strict
2017-11-06 14:26:08 -08:00
Matt Bierner
813235c7f7
Move python extension to strict
2017-11-06 14:24:20 -08:00
Matt Bierner
00ca96b766
Fix javascriptmain compile error
2017-11-06 13:32:40 -08:00
Matt Bierner
04ccc517a9
Enable strict mode in JS extension
2017-11-06 11:50:28 -08:00
Matt Bierner
d28123cb60
Split some long function sig lines
2017-11-06 11:46:14 -08:00
Matt Bierner
cd00b590a8
Enable strict in a few more extensions
2017-11-06 11:40:05 -08:00
Rob Lourens
de137dd8b8
Fix #37685 - always select input box contents when search viewlet takes the editor text
2017-11-06 11:16:07 -08:00
Matt Bierner
3f9bc10e81
Set strict mode in a few extensions that already have strictNullChecks
2017-11-06 10:32:24 -08:00
Matt Bierner
6bcfefedb3
Fix a number of calls to on() for strictFunctions
...
WIth strictFunctions, the callback can no longer use implicit casts to a subclass for parameter types. This pattern was widely used with `.on` event callbacks in the dom
2017-11-06 10:32:24 -08:00
Matt Bierner
e5b4bdce2e
Use class for NullTelemetryService
2017-11-06 10:32:23 -08:00
Matt Bierner
ac60e31cdf
Format main.contribution.ts for ts 2.6.1
2017-11-06 10:32:23 -08:00
Matt Bierner
160a826f5e
Use clear on Callback map
2017-11-06 10:32:23 -08:00
Matt Bierner
9ffd38a130
Remove warn form ITypeScriptServiceClient
2017-11-06 10:32:23 -08:00
Matt Bierner
6a6793e6ec
Remove logTelemetry from ITypeScriptServiceClient from
2017-11-06 10:32:23 -08:00
Matt Bierner
accd6faf60
Rename to use standard casing for TypeScript
2017-11-06 10:32:23 -08:00
Matt Bierner
156a0c9178
Use ITypescriptServiceClient in task provider
2017-11-06 10:32:23 -08:00
Daniel Imms
ffc8b19d31
Uplevel xterm.js
2017-11-06 10:07:06 -08:00
Johannes Rieken
b289f0c5e2
rename startupTimer to performance, support mark and measure, drop promise support, add more marks to slowly phase out old timers
2017-11-06 18:51:15 +01:00
Johannes Rieken
10fe0ac994
ticks - don't send timers2 anymore
2017-11-06 18:51:14 +01:00