Commit Graph

149068 Commits

Author SHA1 Message Date
dileepyavan
54be29cea7 Merge pull request #303618 from microsoft/DileepY/303505
Include analyzer messages in background terminal output
2026-03-21 08:14:24 +01:00
Rob Lourens
9d7d0363de When archiving active session, clear it (#303684) 2026-03-20 22:23:12 -07:00
Rob Lourens
55969564bb Enable setting caseInsensitive through search API for agent tools (#303679)
* Enable setting caseInsensitive through search API for agent tools
Fix #303673

* Avoid per-call allocation in isFilePatternMatch for ignoreCase option (#303681)

* Initial plan

* Extract filePatternIgnoreCaseOptions as module-level constant to avoid per-call allocations

Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/a131b260-e6c0-47f6-aa2a-95ac0f24fe10

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>
2026-03-21 04:45:05 +00:00
Peng Lyu
161ff4266e carousel: improve image loading perf (#303662)
* carousel: improve image loading perf

* resolve comments
2026-03-20 19:43:51 -07:00
dileepyavan
36ca95ebaa Show allow-list actions for unsandboxed terminal confirmations (#303660)
* Handle unsandboxed terminal confirmation actions

* test: fix unsandboxed terminal confirmation actions

* Fixing confirmation window issues outside sandbox
2026-03-20 19:41:15 -07:00
Rob Lourens
7503e59fc3 Don't localize markdown icon syntax (#303655)
* Don't localize markdown icon syntax

Co-authored-by: Copilot <copilot@github.com>

* Add eslint rule for localized markdown icons

---------

Co-authored-by: Copilot <copilot@github.com>
2026-03-21 01:19:54 +00:00
Kyle Cutler
7c45bc769a Fix browser focus stealing (#303647) 2026-03-21 00:53:04 +00:00
Matt Bierner
8c3724e8d1 Merge pull request #303644 from mjbvz/dev/mjbvz/fine-dingo
Mark many chat session related types as readonly
2026-03-20 17:49:38 -07:00
dileepyavan
28aaabc31e Option to allow-list command when offering to run outside of sandbox (#303637)
* Handle unsandboxed terminal confirmation actions

* test: fix unsandboxed terminal confirmation actions
2026-03-20 17:40:55 -07:00
Paul
1519062c0f Add missing skills discovery info (#303646) 2026-03-21 00:31:33 +00:00
Josh Spicer
4b8a157d86 Replace gear menu with direct Customizations editor action (#303641)
When chat.customizationsMenu.enabled is true (default):
- Gear icon directly opens the AI Customizations editor
- Tool Sets, Chat Settings, and Show Agent Debug Logs move to the '...' context menu

When the setting is false, the original gear dropdown behavior is preserved.
2026-03-21 00:19:49 +00:00
Rob Lourens
a7fffd156c Enable starting sessions on remote agent hosts in sessions app (#303631)
* Enable starting sessions on remote agent hosts in sessions app

Co-authored-by: Copilot <copilot@github.com>

* Fix

Co-authored-by: Copilot <copilot@github.com>

* fix

Co-authored-by: Copilot <copilot@github.com>

* fix

Co-authored-by: Copilot <copilot@github.com>

* fix test

Co-authored-by: Copilot <copilot@github.com>

---------

Co-authored-by: Copilot <copilot@github.com>
2026-03-20 17:16:33 -07:00
Paul
2a09c1e0d0 Use built-in progress instead of custom shimmer for agent debug panel (#303636) 2026-03-21 00:04:58 +00:00
Matt Bierner
caa7e57116 Also mark array itself as readonly 2026-03-20 17:01:11 -07:00
Matt Bierner
c2b719fb32 Add one more readonly 2026-03-20 17:00:12 -07:00
Matt Bierner
4631c88d06 Update test 2026-03-20 16:59:21 -07:00
Matt Bierner
4b98d2171b Merge pull request #303640 from mjbvz/dev/mjbvz/boring-kingfisher
Use unknown instead of any
2026-03-20 16:55:11 -07:00
Matt Bierner
0697f7d8d3 Mark many chat session related types as readonly
These types are generally expected to be immutable
2026-03-20 16:44:10 -07:00
Matt Bierner
f56eaf4d60 Merge pull request #291825 from jeevaratnamputla/child-process
Replace child_process.exec with execFile to prevent potential command injection
2026-03-20 16:40:06 -07:00
Matt Bierner
5caa080ce3 Merge pull request #297893 from kbhujbal/fix/code-quality-improvements
Fix code quality issues: error logging and JSDoc typo
2026-03-20 16:37:21 -07:00
Matt Bierner
26d39c203c Merge pull request #303619 from mjbvz/dev/mjbvz/useful-narwhal
Remove unused `IChatSessionDto.id` field
2026-03-20 16:35:00 -07:00
Matt Bierner
5fc1bf6b7f Merge pull request #303625 from mjbvz/dev/mjbvz/possible-parakeet
Try to clean up inProgress handling for chat sessions
2026-03-20 16:31:58 -07:00
Matt Bierner
1ec1913b83 Merge pull request #303620 from mjbvz/dev/mjbvz/tender-puffin
Make sure content part disposes of refs
2026-03-20 16:31:43 -07:00
Matt Bierner
231b7e7d76 Use unknown instead of any 2026-03-20 16:30:52 -07:00
Matt Bierner
36ec9dbe69 Merge branch 'main' into child-process 2026-03-20 16:19:08 -07:00
Shehab Sherif
5ce6509b44 Fix missing global flag in sanitizeId regex (#303603)
* Fix missing global flag in sanitizeId regex

The regex in sanitizeId was missing the 'g' flag, so only the first
occurrence of '.' or '/' was replaced with '_'. Since settings IDs
contain multiple dots (e.g. 'editor.font.size'), this meant subsequent
dots were left in the sanitized ID.

* Add regression test for sanitizeId global replacement

Export sanitizeId and add a test verifying that all occurrences of '.'
and '/' are replaced in generated tree element IDs, not just the first.

---------

Co-authored-by: Shehab Sherif <shehabsherif0@users.noreply.github.com>
2026-03-20 23:18:13 +00:00
Tyler James Leonhardt
ba9458c65c refactor: rename image carousel configuration and update related descriptions (#303630)
* refactor: rename image carousel configuration and update related descriptions

also make default true

* update title

* fix: update image carousel title and description to "Images Preview"
2026-03-20 16:17:46 -07:00
Matt Bierner
5f5fb85206 Merge branch 'main' into fix/code-quality-improvements 2026-03-20 16:14:43 -07:00
Tyler James Leonhardt
4c055a03f9 feat: add context key expressions for slash command visibility (#303626)
This is how we should be registering slash commands. Not hard coding targets.

It would be a good exercise to apply when clauses to the rest of these in the future.
2026-03-20 15:55:33 -07:00
Tyler James Leonhardt
a3512f01a6 fix: enhance session resolution in sessionSupportsFork method (#303624)
ref https://github.com/microsoft/vscode/issues/300501
2026-03-20 22:18:17 +00:00
Matt Bierner
cafda08d8f Try to clean up inProgress handling for chat sessions
This api is very strange. Reducing where it's exposed because it really should not exist
2026-03-20 15:02:15 -07:00
Matt Bierner
5f3aba5e00 Make sure content part disposes of refs
Fixes #303547
2026-03-20 14:20:56 -07:00
Matt Bierner
a283594a3f Remove unused IChatSessionDto.id field 2026-03-20 14:15:21 -07:00
Peng Lyu
8f46cf34c3 integrate image carousel support in sessions. (#303615) 2026-03-20 21:12:58 +00:00
Matt Bierner
d50a3ac1ce Merge pull request #303610 from mjbvz/dev/mjbvz/fit-hare
Remove `as sinon.SinonStub` casts
2026-03-20 14:11:33 -07:00
Connor Peet
5396fe38fc agentPlugins: allow paths in github sources (#303599)
* agentPlugins: allow paths in github sources

Though nonstandard, Github CLI plugins have started to do this. So this supports that.

* fixup
2026-03-20 14:05:26 -07:00
Bryan Chen
4db9da0443 Merge pull request #303226 from microsoft/bryanchen-d/fix-notebook-snapshot-too-large
fix: catch notebook snapshot errors in chat editing with log fallback
2026-03-20 14:05:22 -07:00
Raymond Zhao
a4b2a1610d chore: bump flatted (#303340) 2026-03-20 14:04:42 -07:00
Henning Dieterichs
c9335c2873 node_modules is stale -> ignore node-version changes 2026-03-20 22:04:20 +01:00
Josh Spicer
5f094293b4 sessions: prevent welcome overlay flash on transient entitlement state (#303583)
* Enhance regression handling in SessionsWelcomeContribution: delay overlay display to prevent flashing during transient state changes

* Refactor SessionsWelcomeContribution: replace regression watching with entitlement state monitoring to prevent flashing during transient state changes

* Refactor SessionsWelcomeContribution: replace regression timeout with pending overlay timer to prevent flashing during transient state changes

* Refactor SessionsWelcomeContribution: simplify entitlement state monitoring and remove overlay delay to improve responsiveness

* Refactor SessionsWelcomeContribution: change class visibility to export for better accessibility

* Add test for overlay visibility on first launch with no entitlement

* test(sessions): simplify instantiation service ownership in welcome tests

Address PR review: avoid redundant disposables.add() wrapping around
workbenchInstantiationService(), which already registers itself.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-20 13:55:31 -07:00
Josh Spicer
ef1e52a086 Add inline badge to customization list items for context instructions (#303598)
* Add generic badge support to customization list items

Instructions with applyTo patterns now show context info (e.g.
'always added', 'context matching *.ts') as an inline badge next to
the item name instead of baking it into the display name string. The
badge uses the same visual style as the MCP 'Bridged' badge.

The badge field is generic on IAICustomizationListItem so other
customization types can use it in the future. Badge text is also
included in search filtering.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Show pattern directly in badge with explanatory hover tooltip

Badge now shows just the applyTo pattern (e.g. '**/*.ts') or 'always
added', instead of 'context matching ...'. Hovering the badge shows a
tooltip explaining the behavior. Added badgeTooltip field to
IAICustomizationListItem for generic reuse.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Include badge tooltip in item hover

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add blank line before badge tooltip in hover

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address review: shared badge CSS, flex ellipsis fix, update spec

- Extract shared .inline-badge class used by both MCP bridged badge
  and item badges to avoid style drift.
- Add min-width: 0 and flex: 1 1 auto to .item-name so long names
  truncate correctly inside the flex row.
- Update AI_CUSTOMIZATIONS.md to reflect that badges show the raw
  applyTo pattern with tooltip explanation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Keep badge adjacent to name instead of right-aligned

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-20 13:55:09 -07:00
Connor Peet
b7462b4a00 Merge pull request #303597 from microsoft/connor4312/agent-host-server-fixups
agentHost: fixup build for server
2026-03-20 13:54:33 -07:00
Ladislau Szomoru
79d5a79218 Sessions - add prompt for merging changes (#303607)
* Sessions - add prompt for merging changes

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-20 20:48:34 +00:00
Kyle Cutler
71b623764e Move find to browser feature contribution (#303562)
* Move find to browser feature contribution

* feedback
2026-03-20 13:33:10 -07:00
Matt Bierner
bde0340390 Use proper typings 2026-03-20 13:29:43 -07:00
dependabot[bot]
6ee1160198 Bump tar from 0.4.44 to 0.4.45 in /cli (#303573)
Bumps [tar](https://github.com/alexcrichton/tar-rs) from 0.4.44 to 0.4.45.
- [Commits](https://github.com/alexcrichton/tar-rs/compare/0.4.44...0.4.45)

---
updated-dependencies:
- dependency-name: tar
  dependency-version: 0.4.45
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-03-20 13:28:16 -07:00
Matt Bierner
1285a5245d Remove as sinon.SinonStub casts
This is secretly like an any cast as the result isn't typed
2026-03-20 13:22:06 -07:00
Isidor Nikolic
b266620dc6 Merge pull request #303596 from microsoft/isidorn/attractive-goldfish
fixes #303425
2026-03-20 21:13:13 +01:00
Lee Murray
69ca0c3f58 Sessions: Replace badge with inline title count in Changes view (#303482)
* Sessions: Replace Changes view badge with inline title count

Replace the NumberBadge on the Changes view tab with an inline title
that shows the file count directly, e.g. '7 Changes' instead of a
badge overlay.

- Export dynamic changesContainerTitle with a getter-based value
- Add refreshContainerInfo() to IViewContainerModel interface and
  ViewContainerModel implementation
- Remove IActivityService/NumberBadge dependency from ChangesViewPane

* Fix incorrect file count by using topLevelStats

The inline title count was reading from activeSessionChangesObs (raw
session changes only) instead of topLevelStats which accounts for
deduplication and version mode filtering. Move the title update into
onVisible() where topLevelStats is available, and reset the title
when the view is hidden.

* Address review feedback

- Add blank line separator after changesContainerTitle block
- Add constructor-level fallback autorun to keep title in sync when
  the view is hidden and the active session changes
- Reset title to 'Changes' on dispose to avoid stale counts

* Keep inline file count when switching tabs

Remove the updateContainerTitle(0) call from the hide handler so
the count persists when the user switches to another tab. The
fallback autorun in the constructor still handles session switches
while the view is hidden.

* Fix grammar: use singular '1 Change' instead of '1 Changes'

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
2026-03-20 13:04:51 -07:00
Lee Murray
877aceccc2 Sessions: Adjust auxiliary bar margins for improved layout (#303501)
Sessions - adjust auxiliary bar margins for improved layout

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
2026-03-20 20:56:09 +01:00