Commit Graph

28277 Commits

Author SHA1 Message Date
Matt Bierner cbf9ae23ed Allow loading webview outside of file: origin (#41698)
* Allow loading webview outside of file: origin

**Problem**
Webviews are currently always loaded from a file on the disk. This results in the webview running in the file origin, potentially allowing it to access any file on disk. If a webview fails to sanitize workspace or remote input, untrusted code could potentially access files on the user's system.

**Fix**
Add a new option to serve the webview out of a "data:" uri instead. This prevents access to `file://` resources.

In order to allow webviews to still load resources from disk, add a new protocol called `vscode-core-resource://` that only allows access to resources inside of the vscode directory.

Moves extension pages and our release notes to use this new option. These already are pretty locked down. We cannot move the htmlpreview command to use this option as it would break a huge number of existing extensions, however the new webview API will always have this new option enabled.

* Shorted protocol name
2018-01-16 12:50:14 -08:00
Johannes Rieken 42de6cc82f add TextSearchOptions, only search in folder contributed by provider, #41536 2018-01-16 12:31:40 -08:00
Rob Lourens 205c49a94c Fix settings search telemetry metadata for settings edited from editable side of settings editor 2018-01-16 11:04:40 -08:00
Johannes Rieken 4b5c0ec9d1 remote - a few more todo-tags after a 'file'-scheme search 2018-01-16 10:59:37 -08:00
Johannes Rieken 688f853578 use extfs#watch, #41700 2018-01-16 10:42:27 -08:00
Johannes Rieken f17d0bcc82 set problems.decorations.enabled to true, #782 2018-01-16 10:20:08 -08:00
Johannes Rieken 4a45d92f04 slight follow up on #38636 2018-01-16 10:19:20 -08:00
Sandeep Somavarapu e48281d14b #35462 Store the hidden views in global storage 2018-01-16 19:03:26 +01:00
Benjamin Pasero c0cfc0e20d 💄 2018-01-16 18:25:41 +01:00
Benjamin Pasero 48628fb65e log editorGroupMoved 2018-01-16 18:20:51 +01:00
isidor d53bb74cce fix cmd+w not working 2018-01-16 18:18:44 +01:00
Benjamin Pasero b939d90808 fix #40224 2018-01-16 18:04:46 +01:00
Sandeep Somavarapu b5bf2f90db #41071 Show the view on selected if hidden 2018-01-16 17:24:42 +01:00
Sandeep Somavarapu e22eb95064 #41071 Add view category to the commands 2018-01-16 17:15:25 +01:00
Sandeep Somavarapu 543bcec6ef Fix #41071 2018-01-16 17:06:48 +01:00
Sandeep Somavarapu f86c0f9a91 Remove the handle from the system when handle changes 2018-01-16 17:06:47 +01:00
Sandeep Somavarapu c66517cf0d Fix #40018 2018-01-16 17:06:47 +01:00
Sandeep Somavarapu dc13183cdb Merge pull request #41413 from Microsoft/sandy081/40018
Add optional id property to the tree item
2018-01-16 17:06:22 +01:00
Sandeep Somavarapu ee287dda6d Merge branch 'master' into sandy081/40018 2018-01-16 17:05:48 +01:00
isidor 49c5b17dc7 todo@isidor 2018-01-16 16:55:15 +01:00
isidor b6e0f97f97 open editors: multi select dnd 2018-01-16 16:51:49 +01:00
isidor 3f38333b9b getMultiSelectedEditorContexts 2018-01-16 15:53:21 +01:00
isidor f9237aa2e9 udpate explorer.openEditors.visible docs 2018-01-16 15:39:27 +01:00
isidor bc0450fe44 get rid of IEditorContext, use IEditorIdentifier instead 2018-01-16 15:16:30 +01:00
isidor c74f95d1dc close editors and close other editors multi select aware 2018-01-16 12:57:39 +01:00
isidor 45dccb50be close editors multi select aware 2018-01-16 11:50:16 +01:00
isidor 592e8761a3 open editors view: remove unused actions 2018-01-16 11:50:06 +01:00
isidor 16bcbe1907 close all unmodified multi select aware 2018-01-16 11:19:30 +01:00
Christof Marti ec1924769c Add alias for commands (#39778) 2018-01-16 11:05:00 +01:00
isidor 8a545292d8 open editors multi select: save all 2018-01-16 10:49:19 +01:00
isidor 748f176321 open editors: need to pass an {} when there is no uri to keep the order of arguments 2018-01-16 10:49:19 +01:00
isidor 43e1d0917f getMultiSelectedEditorContexts 2018-01-16 10:49:19 +01:00
Benjamin Pasero adefb517f6 💄 2018-01-16 10:41:40 +01:00
Sandeep Somavarapu aa0bcc80a1 Doc feedback for id attribute 2018-01-16 10:32:43 +01:00
Christof Marti fffbae872e Increase timeout for search tests (fixes #40013) 2018-01-16 10:21:58 +01:00
Christof Marti 079b3090e1 Updgrade markdown-it (fixes #40099) 2018-01-16 10:17:23 +01:00
isidor fe92d1e983 explorer: do not make file assumptions in shouldRefreshFromEvent
#36946
2018-01-16 10:04:32 +01:00
Isidor Nikolic 7d34e22d3f Merge pull request #41496 from usernamehw/zebra_for_running
Remove hard-coded zebra in running extensions Fixes #40432
2018-01-16 09:57:30 +01:00
Benjamin Pasero 1eca6b9817 polish closeEditors API more 2018-01-16 07:45:30 +01:00
Johannes Rieken c0278341ed link detection for remote file systems, #41482 2018-01-15 17:36:00 -08:00
Johannes Rieken c677bf31e2 write meta.json file #41408 2018-01-15 15:18:13 -08:00
Johannes Rieken b4ee65d1e3 limit suggestions that can be remembered, #41060only items from the top bucket will be remembered and pre-selected the next time suggestion happens 2018-01-15 14:49:24 -08:00
Johannes Rieken 1038c4bff5 don't encode special character for labels, #40662 2018-01-15 11:31:28 -08:00
Benjamin Pasero a54050a58e 💄 2018-01-15 20:26:46 +01:00
Johannes Rieken 9401875dfc more type fixes for #36946 2018-01-15 11:25:27 -08:00
Benjamin Pasero 09e36c7d00 allow to closeAllEditors across multiple groups 2018-01-15 20:20:44 +01:00
Johannes Rieken d1ec084353 tackle, #41637 2018-01-15 11:12:00 -08:00
Johannes Rieken 97a199d02c wire up types, #36946 2018-01-15 11:12:00 -08:00
Benjamin Pasero e2de39efb2 provide cross-position closeEditors methods 2018-01-15 20:06:25 +01:00
Johannes Rieken 788486ccc8 Merge pull request #41561 from Microsoft/incomplete
When trigger suggest for incomplete completions, use new kind
2018-01-15 10:04:40 -08:00