Commit Graph
125801 Commits
Author SHA1 Message Date
Alex Ross ce7b68b48d Typing in a comment, switching editors and switching back will not restore the cursor position in the comment box (#230466)
Fixes #229214
2024-10-04 10:40:52 +02:00
Aiday Marlen Kyzy 83e44613e4 Adding check that EditContext is supported before using it (#230400)
* add check against edit context

* adding code

* choosing dom node of the overflow guard container

* DebugEditContext no longer implements EditContext
2024-10-04 10:25:18 +02:00
Martin Aeschlimann 2fb92a5659 waitThrottleDelayBetweenWorkUnits is flaky, commenting out (#230464) 2024-10-04 09:54:05 +02:00
Joyce Er de44f0c7e3 fix: disable followups in editing view (#230457) 2024-10-03 22:21:22 -07:00
Joyce Er c33745f66c feat: render progress in chat editing widget while response is streaming (#230456) 2024-10-04 06:23:48 +02:00
Connor Peet 1b1d5d62c7 debug: fix contrast of colored output in list rows (#230452)
Fixes #230442
2024-10-03 20:11:41 -07:00
Rob Lourens 7ed2d964ff De-contribify the chat attachments (#230451)
* De-contribify the chat attachments
It was done this way originally to match "dynamic variables" and fit the flow of how extra metadata is attached to chat history. But it didn't really make sense for attachments to be considered a contribution given how they're rendered and used now. And I might change this for dynamic variables too anyway. So now we can add some input state that comes directly from the input part and not a contrib.
Fix microsoft/vscode-copilot#8678

* Simplify
2024-10-04 04:34:16 +02:00
Andrea Mah 9aa06fa1ab fix collapse states (#230444) 2024-10-03 17:39:23 -07:00
Don Jayamanne b89d825ccc Ignore transient keys in notebook metadata when diffing of nb metadata (#230281)
* Ignore transient keys in notebook metadata when diffing of nb metadata

* Fixes

* Fixes
2024-10-04 10:30:12 +10:00
Don Jayamanne c1ff45f806 Ignore metadata/outputs during initial nb height computation (#230279)
* Ignore metadata/outputs during initial nb height computation

* Ignore metadata/outputs during initial nb height computation

* Fixes

* Fixes

* oops
2024-10-04 10:29:10 +10:00
Don Jayamanne c78f5c1685 Log failure to save ipynb with setting enabled on remote (#230188)
* Enable experimental notebook worker serialization

* Track failures to save on remote with ipynb serializer

* Revert
2024-10-04 10:28:42 +10:00
Joyce Er 6a7915ce25 fix: reduce codeblock pill flickering in chat editing response 2024-10-03 17:20:20 -07:00
Joyce Er eac8a441c7 fix: bold unactioned edited files 2024-10-03 17:20:20 -07:00
Joyce Er 8207524705 fix: Add Files should only list file attachments 2024-10-03 17:20:20 -07:00
Rob Lourens c623dcfaeb Remove old implicitContext setting (#230439) 2024-10-04 00:52:27 +02:00
Raymond Zhao b0d688cda1 Suppress safe generic type assertions, ref #211878 (#230435) 2024-10-03 15:23:00 -07:00
Connor Peet 1b2a4174f7 testing: fix markdown output not being removed from DOM on switch (#230433)
Fixes #230429
2024-10-03 23:45:48 +02:00
Matt Bierner f6c1c6d08a Move css specific code to own file (#230427)
Planning to add some additional css helpers. `dom` is getting fairly large and unfocused so I think we should start a new file just for helping write css
2024-10-03 14:36:27 -07:00
Connor Peet 03dbe6750b testing: fix can't run a runnable test item with a single non-runnable child (#230428)
Fixes #229120
2024-10-03 14:21:17 -07:00
Michael Lively c7ef4f6f58 Add configurable delay to wh (#230414)
* add configurable delay to wh

* simplify cursorChange listener. unnecessary complication, this still feels the intended snappy

* editing the right file this time...
2024-10-03 14:17:58 -07:00
Matt Bierner a1c1c56b4f Don't allow bold inline anchors (#230421)
Fixes #230395
2024-10-03 13:34:43 -07:00
Andrea Mah 9e32d9e0c5 make fully collapsed state up to under Text Results or AI Results (#230420) 2024-10-03 12:29:57 -07:00
Connor Peet 14d02fe26e testing: fix double scrollbars on long output (#230417)
* testing: fix double scrollbars on long output

Previously we limited the editor height to 10,000 pixels for performance, but this could show a double scrollbar on long output. In this change, we instead maintain the editor size to be the size of the output peek / view and move the editor as scroll in the list moves to take advantage of the editor's virtualization capabilities.

Fixes #228991

* hygenie
2024-10-03 20:51:02 +02:00
Aaron Munger 7b4be7d437 don't put REPL variable view behind a notebook setting (#230349)
* enable variables for REPL despite setting

* handle closing notebook with variables
2024-10-03 11:15:13 -07:00
Rob Lourens 00b294a732 Fix extension-contributed commands in the chat view title menu (#230354)
* Fix extension-contributed commands in the chat view title menu
We were trying to serialize the ChatViewPane and send it to the EH
Fix microsoft/vscode-copilot#8923

* Fix
2024-10-03 10:03:16 -07:00
Connor Peet 96bc3568af events: correctly trigger the onDidAddListener event in emitter options (#230259)
* Correctly trigger the `onDidAddListener` event in emitter options

* Add test for `Emitter.onDidAddListener`
2024-10-03 09:19:50 -07:00
Alex Ross 2e461da921 create-comment: monaco editor should disable line-number manipulating API for extensions? (#230407)
Fixes #229521
2024-10-03 18:19:34 +02:00
Connor Peet c6db17f796 events: fix event listener not called delivery queue is adjusted (#230405)
Fixes #230401
2024-10-03 17:49:23 +02:00
Logan Ramos 5763fe9446 Attempt to make throttler test case less flaky (#230335)
* Attempt to make throttler test case less flaky

* Switch away from timeouts
2024-10-03 17:27:16 +02:00
Daniel Imms 36c78f0f39 Merge pull request #230390 from microsoft/tyriar/a11y_contrib_cleanup__contrib_cleanup
Improve consistency across terminal/ and terminalContrib/
2024-10-03 08:21:37 -07:00
Sandeep Somavarapu 7159df6133 show ai fix code action in problem hover (#230402) 2024-10-03 17:03:07 +02:00
Daniel Imms 03ea7ffeb5 Merge branch 'main' into tyriar/a11y_contrib_cleanup__contrib_cleanup 2024-10-03 06:55:23 -07:00
Daniel Imms d661252b20 Merge pull request #230387 from microsoft/tyriar/a11y_contrib_cleanup
Clean up a11y terminalContrib/
2024-10-03 06:33:22 -07:00
Daniel Imms 02b78e955a Merge pull request #230392 from microsoft/tyriar/230246
Don't instantiate addons if terminal is disposed
2024-10-03 06:17:46 -07:00
Daniel Imms 966aacf4bb Merge pull request #230391 from microsoft/tyriar/230237
Don't throw when terminal is disposed before xterm is created
2024-10-03 06:17:16 -07:00
Daniel Imms 62bd82385e Don't instantiate addons if terminal is disposed
Fixes #230246
2024-10-03 05:20:50 -07:00
Daniel Imms 5bbf4919cd Don't throw when terminal is disposed before xterm is created
Fixes #230237
2024-10-03 05:13:44 -07:00
Ladislau Szomoru 289056d976 Git Editor - create document link provider (#230389) 2024-10-03 13:58:27 +02:00
Daniel Imms 6f37db8ab3 Add comma-dangle rule to terminal/ too 2024-10-03 04:54:44 -07:00
Daniel Imms be18175f14 Add comma-dangle rule 2024-10-03 04:51:14 -07:00
Martin Aeschlimann fc6d94b806 [css/json/html] adopt latest lsp, update to module: node16 (#230371)
* adopt latest language-server/client

* update package-locks

* transpiler to support Node16
2024-10-03 13:49:56 +02:00
Daniel Imms bfa8c6695a Clean up contrib ctors 2024-10-03 04:46:04 -07:00
Daniel Imms aa34846b37 Clean up a11y terminalContrib/
- Removes unneeded injected services
- Removes _ from non-privates
- Sort ctor injected services
2024-10-03 04:29:10 -07:00
Alex Ross 52b181c2ce Changing checkbox state on tree item (rather than UI checkbox) doesn't propagate (#230376)
Fixesmicrosoft/vscode-pull-request-github#6248
2024-10-03 13:10:04 +02:00
Martin Aeschlimann f8e51fe82d integration tests: colorization test are run 6 times (#230380)
* integration tests: colorization test are run 6 times

* adding missing --
2024-10-03 12:34:14 +02:00
Benjamin Pasero 2b30a40013 esm - restore --esm for web test runner (#230379) 2024-10-03 03:07:04 -07:00
Aiday Marlen Kyzy 60d850e1a8 Add EditContext support when on chrome, edge or on desktop (#230373)
add the setting when on chrome edge or on desktop
2024-10-03 11:20:03 +02:00
Aiday Marlen Kyzy 3305293ba2 EditContext: Setting the edit context when current window id does not correspond to previous window id (#230368)
setting the edit context within nativeeditcontext
2024-10-03 11:12:17 +02:00
Martin Aeschlimann 3d4417e71b commenting out waitThrottleDelayBetweenWorkUnits (#230367) 2024-10-03 10:39:53 +02:00
Kk Shinkai 2e48a0fe05 Add test for Emitter.onDidAddListener 2024-10-03 14:20:35 +08:00