Commit Graph

129473 Commits

Author SHA1 Message Date
Benjamin Christopher Simmonds
d76069d643 Fix tab border issues (#239915)
fix tab border
2025-02-07 11:13:41 +01:00
Johannes Rieken
b3481536d3 storing and restoring should consider multiple editing sessions (#239913)
https://github.com/microsoft/vscode-copilot/issues/12820
2025-02-07 11:04:38 +01:00
Matt Bierner
18edce9355 Merge pull request #239899 from mjbvz/rich-angelfish
Optimistically show `paste with imports` if TS server takes to long when computing imports to add
2025-02-07 01:49:30 -08:00
Benjamin Pasero
86b64aa4bc files - abandon watcher correlation API proposal (#239906)
* files - abandon watcher correlation API proposal

* fix compile
2025-02-07 10:43:11 +01:00
Alex Ross
bb2def3db4 Have a button in the simple file picker to show/hide hidden files (#239910)
Fixes #136307
2025-02-07 10:40:10 +01:00
Robo
a9dd4d35a6 feat: enable wco on macOS (#239666) 2025-02-07 10:33:44 +01:00
Sandeep Somavarapu
99bb19470d do not collide with common properties (#239908) 2025-02-07 10:29:46 +01:00
Alex Ross
a1d56fd8a2 Revert "workspaceFolder variable substitution in launch.json or tasks.json should use URI for virtual filesystems (#235954)" (#239905)
This reverts commit d3145c5087.

Fixes https://github.com/microsoft/vscode/issues/239903
2025-02-07 09:59:07 +01:00
Matt Bierner
569d6942e8 Use clearer reference 2025-02-07 00:31:33 -08:00
Matt Bierner
ae77c3ff42 Optimistically show paste with imports if TS server takes to long when computing imports to add
Fixes #235959

When pasting across files, sometimes users can see a spinner while we wait to see if TS has a `paste with imports` edit. This needs to be done even if we insert plain text by default so that we can then show the paste widget and user can select `paste with imports`

This change makes it so that if TS takes over 200ms, we assume that a paste operation may be available and return an unresolved edit for it. Only when the edit then actually needs to be applied, we wait for TS to respond

In most cases we won't need to wait because plain text will be pasted by default. Users will then only see the spinner after selecting `paste with imports`
2025-02-07 00:01:46 -08:00
Oleg Solomko
86bc5fa3b5 improve typeCheck utility (#239890) 2025-02-07 07:02:13 +00:00
Benjamin Pasero
ea1cad71f2 debt - fix leak with "Manage Extension" action in progress (#239893) 2025-02-06 23:01:53 -08:00
Oleg Solomko
e4c1babf22 use createUri() test utility in unit tests for Windows support 2025-02-06 21:34:48 -08:00
Oleg Solomko
a8f0ee5a50 cleanup commented out code, improve test utility and unit test results output 2025-02-06 21:34:48 -08:00
Oleg Solomko
41e4b55308 add unit tests for multi-root workspaces 2025-02-06 21:34:48 -08:00
Oleg Solomko
132ac27517 add object/array/string config unit tests for the single-root workspace case 2025-02-06 21:34:48 -08:00
Oleg Solomko
cd84a47370 add unit tests with mocked filesystem structure 2025-02-06 21:34:48 -08:00
Oleg Solomko
af183d6e4d refactor the mockFolder utility into Mockfilesystem class 2025-02-06 21:34:48 -08:00
Oleg Solomko
94a0316d6e move createFolder test utility to a common place 2025-02-06 21:34:48 -08:00
Oleg Solomko
467216e171 implement basic unit tests for the ChatInstructionsFileLocator class 2025-02-06 21:34:48 -08:00
Don Jayamanne
fe4d6a831a Enable Accept/Disard buttons in inline notebook chat (#239884) 2025-02-07 04:55:44 +01:00
Megan Rogge
7995280c58 indicate code block index in chat toolbar aria label (#239876)
fix #237794
2025-02-06 19:12:03 -08:00
Rob Lourens
94da87e5c9 Remove vscode-dts-region-comments (#239868)
This is from how the old vscode.proposed.d.ts was managed, and is no longer relevant
2025-02-06 17:45:08 -08:00
Megan Rogge
245b24a958 do not deal with single tab in disposable (#239865) 2025-02-07 01:11:16 +01:00
Osvaldo Ortega
c659faf5d8 Merge pull request #239863 from microsoft/osortega/ai-results-requested-context
Context for ai results requested
2025-02-06 16:09:33 -08:00
Justin Chen
fac0371425 fix error message when image not sent to model (#239861)
fix error message when image sent to model
2025-02-07 00:32:55 +01:00
Osvaldo Ortega
2b037b3802 Context for ai results requested 2025-02-06 15:30:59 -08:00
Michael Lively
1552a63e47 Fix nb stickyscroll not having outline if outline pane is closed (#239859)
fix stickyscroll not appearing because outline is closed -- not computed yet + some better error handling
2025-02-07 00:05:46 +01:00
Megan Rogge
02b0887072 Fix build, use mutable disposable (#239858) 2025-02-06 23:28:53 +01:00
Tyler James Leonhardt
c74ab84590 Remove aria-activedescendant when typing & remove clearFocus code (#239857)
This applies some good feedback from @rperez030 in here:
https://github.com/microsoft/vscode/issues/237324#issuecomment-2640728149

which gave me the idea to just remove `aria-activedescendant` whenever you type in the input box. This allows arrow keys and selections to read out.

Because of that, we can remove this SHIFT+TAB behavior I introduced a while back since that isn't needed to get the screen reader to read out the arrow keys.

Note: deletions in certain quick picks remain a challenge. Since deletion leads to a changed filter, which triggers the list to highlight something new, often deletions are overriden by the list changes. Honestly, even the SHIFT+TAB behavior before didn't improve the deletions... sometimes the screen reader read them, sometimes it didn't.

Fixes https://github.com/microsoft/vscode/issues/180862
2025-02-06 14:27:07 -08:00
Daniel Imms
3108f002b0 Merge pull request #239830 from microsoft/tyriar/238986__item__dirfile__pwsh
Enable pwsh-script-integration provider by default and remove parts of it
2025-02-06 14:12:47 -08:00
Benjamin Christopher Simmonds
54d01095dc Add keybinding to show workbench hover for active element (#239827) 2025-02-06 12:59:19 -08:00
Daniel Imms
0373713e75 Merge branch 'main' into tyriar/238986__item__dirfile__pwsh 2025-02-06 12:57:05 -08:00
Megan Rogge
e6c77857a7 define pathSeparator in ext host for terminal suggest (#239540) 2025-02-06 20:39:25 +00:00
Ladislau Szomoru
b968336efa Git - do not show origin/HEAD ref in the graph (#239842) 2025-02-06 12:00:24 -08:00
Michael Lively
abeaa31040 Fix some notebook leaks (#239843)
* fix leaks

* don't dispose element -- would throw on reuse
2025-02-06 11:59:37 -08:00
Tyler James Leonhardt
1f19cd9af1 Searching dropdown menus breaks navigation with arrow keys (#239841)
Fixes #214053
2025-02-06 20:22:27 +01:00
Oleg Solomko
f9b30a4ffc refactor to avoid double string trim call 2025-02-06 11:07:21 -08:00
Oleg Solomko
b5328ffa56 add unit tests for the object and array config value cases 2025-02-06 11:07:21 -08:00
Oleg Solomko
d81e87d16d respect provided string value register 2025-02-06 11:07:21 -08:00
Tyler James Leonhardt
d86b5013c1 Move hardcoded hoverToggle keybinding to a Command (#239839)
* Move hardcoded hoverToggle keybinding to a Command

So it can be rebound and whatnot.

* comments
2025-02-06 19:52:15 +01:00
Daniel Imms
1d454b7c49 Merge pull request #239825 from microsoft/tyriar/238986__item__dirfile
Remove terminal completion isDirectory property and change isFile to isFileOverride
2025-02-06 10:14:19 -08:00
Megan Rogge
1f81a442e8 fix more terminal disposable leaks (#239742) 2025-02-06 18:03:44 +00:00
Daniel Imms
62d8094cea Merge branch 'main' into tyriar/238986__item__dirfile 2025-02-06 09:59:25 -08:00
Daniel Imms
1e1607d7f9 Merge pull request #239813 from microsoft/tyriar/238986__item
Move terminal bits out of simpleCompletionItem
2025-02-06 09:56:41 -08:00
Daniel Imms
b883a42da1 Enable pwsh-shell-integration completions again by default 2025-02-06 09:29:52 -08:00
Daniel Imms
da4ba91d78 Remove built-in completions for pwsh
These were too slow in practice, while the git one is useful now it will be
replaced soon in #239519

Part of #239822
2025-02-06 09:29:23 -08:00
Daniel Imms
0493ae6723 Remove pwsh scripts completions except for non file/folder args
Part of #239822
2025-02-06 09:25:41 -08:00
Daniel Imms
c952321de7 Merge branch 'main' into tyriar/238986__item 2025-02-06 09:25:38 -08:00
Daniel Imms
ba1fadd141 Merge pull request #239811 from microsoft/tyriar/238986
Move terminal bits out of simpleCompletionModel
2025-02-06 09:25:15 -08:00