Commit Graph

61520 Commits

Author SHA1 Message Date
Jackson Kearl d9eaddaee1 Add command to rerun search editor query 2020-02-21 16:35:19 -08:00
Jackson Kearl 2402d70ae9 Take search editor out of preview.
Closes #23931. Closes #16488.
2020-02-21 16:35:19 -08:00
Matt Bierner 99d5733e5f New iteration of webview editor API proposal
For #77131

**Motivation**
While our existing webview editor API proposal more or less works, building an editable webview editor is fairly tricky using it! This is especially true for simple text based editors.

It'd also be nice if we could get bi-directional live editing for text files. For example, if I open the same file in a webview editor and in VS Code's normal editor, edits on either side should be reflected in the other. While this can sort of be implemented using the existing API, it has some big limitations

**Overview of changes**
To address these problems, we've decided have two types of webview editors:

- Text based webview editors. These editors used a `TextDocument` as their data model, which considerably simplifies implementing an editable webview. In almost all cases, this should be what you use for text files

- Complex webview editors. This is basically the existing proposed API. This gives extension hooks into all the VS Code events, such as `save`, `undo`, and so on. These should be used for binary files or in very complex text editor cases.

Both editor types now have an explicit model layer based on documents. Text editor use `TextDocument` for this, while custom editors use `WebviewEditorCustomDocument`. This replaces the delegate based approach previously used.
2020-02-21 16:26:01 -08:00
Alex Dima 1a6b2ea39a Improve the discoverability of column selection 2020-02-22 00:21:01 +01:00
Jackson Kearl 0c369e2591 Tentatively fix #90962 by requiring enter 2020-02-21 14:58:17 -08:00
Jackson Kearl b77192b4a7 Fix #91121. 2020-02-21 14:24:28 -08:00
Alex Dima 50e742c42e Always prompt when splitting a workspace stack element 2020-02-21 23:10:01 +01:00
Alex Dima 58aa111492 Remove TextModel.createFromString 2020-02-21 22:24:44 +01:00
Alex Dima 147f417a9e Avoid using TextModel.createFromString 2020-02-21 22:12:22 +01:00
Alex Dima 691c4b1591 Cross-file undo/redo 2020-02-21 21:37:24 +01:00
Alex Dima 4ae83d0a4b First cut at supporting undo across files 2020-02-21 21:36:38 +01:00
Alex Dima 985eea10b1 Relax method signature 2020-02-21 21:36:38 +01:00
Alex Dima 94fe174275 Allow EOL changes to be mergeable with other edits 2020-02-21 21:36:38 +01:00
Alex Dima ed698aa9b1 Scaffold MultiEditStackElement 2020-02-21 21:36:38 +01:00
Benjamin Pasero 7d71562140 untitled - fix title for labels (#89921) 2020-02-21 18:53:04 +01:00
Sandeep Somavarapu 0b02e61f42 💄 2020-02-21 18:25:27 +01:00
Sandeep Somavarapu 6874ecc189 fix #90218 2020-02-21 18:22:04 +01:00
Sandeep Somavarapu 5225915278 #90218 Handle local errors 2020-02-21 18:20:31 +01:00
isidor 194dae557c start view: use preconditions for button enablement
fixes #91141
2020-02-21 17:10:25 +01:00
Joao Moreno 0c1c8f2760 welcome view: add internal precondition 2020-02-21 17:04:39 +01:00
Sandeep Somavarapu f9a90e4ec8 fix error handling in tests 2020-02-21 16:57:55 +01:00
Sandeep Somavarapu 66cd1d8e5b Fix #90624 2020-02-21 16:54:09 +01:00
Sandeep Somavarapu 86abd4e95d Show account identity instead of activity 2020-02-21 16:40:22 +01:00
Joao Moreno a1f61fd0fe welcome views: telemetry events for buttons 2020-02-21 16:38:42 +01:00
Sandeep Somavarapu 487db98feb tweaks to message 2020-02-21 16:21:55 +01:00
Sandeep Somavarapu 51fb67b182 Fix #86917 2020-02-21 16:07:36 +01:00
Benjamin Pasero 6cea9545d2 Notifications: indicate progress notification if hidden in notification center (fix #90274) 2020-02-21 15:58:01 +01:00
Johannes Rieken 8b95561098 show names of formatting edits and code actions providers when they block save. also add links that links that open the settings editor for each feature, #90851 2020-02-21 15:35:30 +01:00
Johannes Rieken df403aa082 show the name of the formatter that's running long, #90851 2020-02-21 15:35:30 +01:00
Martin Aeschlimann b2e0925ba1 update jsonc-parser 2020-02-21 15:03:33 +01:00
isidor f4eab75554 debug start language: store the value of the context key per workspace storage
#85548
2020-02-21 13:05:02 +01:00
Benjamin Pasero 7d10b5a8fa notifications - progress prevents close (#90274) 2020-02-21 12:58:13 +01:00
isidor 5f7ec944de debug start label
#85548
2020-02-21 12:36:31 +01:00
isidor 49ef020fb9 debug start view: debugStartLanguage context key
fixes #85548
2020-02-21 12:31:18 +01:00
Benjamin Pasero 68a1013668 Explore replacing notification count with alternate icon (fix #91130) 2020-02-21 12:29:13 +01:00
Benjamin Pasero 9c31bce0c7 untitled - prevent slash as description only 2020-02-21 12:20:10 +01:00
Benjamin Pasero b90641f8c9 💄 wording 2020-02-21 12:09:44 +01:00
Benjamin Pasero d29788c0bc Config to limit/disable the new Untitled tab auto-naming (fix #90378) 2020-02-21 12:07:06 +01:00
isidor aeda438ac0 Debug groups: only return if the end event does not have additional output in it 2020-02-21 12:06:31 +01:00
Alex Ross af1310a9bf Depends on for user tasks should work
Fixes #90286
2020-02-21 11:50:40 +01:00
Alex Ross 1f86149904 Allow user tasks to be passed as parameters to Run Task
Fixes #90344
2020-02-21 11:40:38 +01:00
Benjamin Pasero a30ddfa505 editors - remove ugly cast 2020-02-21 11:29:35 +01:00
Alex Ross 43076ce316 Command of root task with sequence dependsOn shouldn't execute
Fixes #90352
2020-02-21 11:18:20 +01:00
Benjamin Pasero 4aa7935e32 tests - reduce code duplication 2020-02-21 11:08:02 +01:00
Benjamin Pasero 11fd274e2e tests - add test for out of workspace watchers 2020-02-21 11:08:02 +01:00
Sandeep Somavarapu c6d4c7e25e improve backup
- retain atleast 10 entries
- do not fail when writing to backup fails
2020-02-21 11:06:39 +01:00
Alex Ross 2c1ad8e921 Fix task user task exeuction through AP.
Fixes #90820
2020-02-21 10:58:54 +01:00
Martin Aeschlimann d3d3e8c311 [json] update dependencies 2020-02-21 10:49:58 +01:00
Alex Ross e96f1f0a92 Remove slow task provider warning (#90081)
* Remove slow task provider warning
2020-02-21 10:29:25 +01:00
Alex Ross d33663fac9 Revert commits for task quick pick changes. This fixes #90474
This reverts commit 5f7dd08886 and 68f2ab6134.
2020-02-21 10:29:25 +01:00