Commit Graph
111995 Commits
Author SHA1 Message Date
Tyler James LeonhardtandGitHub dcc719dfca Make Account Menu even lazier (#189860)
ref #189481
2023-08-07 12:32:53 -07:00
Remco HaszingandGitHub e0485e9d8f Mark all .tsbuildinfo files as json (#189811)
TypeScript emits a `.tsbuildinfo` file whose file base name matches the
TypeScript configuration file. Typically this configuration file is
named `tsconfig.json`, meaning TypeScript will generate
`tsconfig.tsbuildinfo`. However, if the config file is named
differently, TypeScript will generate another `.tsbuildinfo` file.
2023-08-07 19:32:21 +00:00
Balaji SivasakthiandGitHub 28af490a6e Resolved conflicts between System High Contrast (HC) and VS Code High Contrast in ExtensionEditor (#189773)
fix: system hc with vscode hc in extension editor
2023-08-07 19:32:08 +00:00
Logan RamosandGitHub d42a3918e6 Set icon label's aria label (#189856)
Set icon aria label
2023-08-07 19:50:55 +01:00
Connor PeetandGitHub 6004a9f716 debug: put user data dir in home dir, update versions of things (#189855) 2023-08-07 19:46:38 +01:00
Joyce ErandGitHub 4083eeefc1 Preserve ref in desktop remote -> local clone (#189852) 2023-08-07 19:34:17 +01:00
Raymond ZhaoandGitHub 39e5dafcd6 Revert "Add Settings editor smoke tests" (#189848)
Revert "Add Settings editor smoke tests (#189687)"

This reverts commit e1dfb2a559.
2023-08-07 18:40:37 +01:00
hsfzxjyandGitHub 24e689132d Ensure the concurrency safety of TestResultsViewContent.reveal (#189756)
Ensure the concurrent safety of TestResultsViewContent.reveal
2023-08-07 17:19:51 +00:00
Joyce ErandGitHub f69859cd30 Revive markdown strings in serialized chat data (#189842)
* Revive markdown strings in serialized chat data

* Also account for string response data
2023-08-07 18:16:53 +01:00
Johannes RiekenandGitHub 8afba70227 finalize the format ranges API (#189841)
fixes https://github.com/microsoft/vscode/issues/158776
2023-08-07 18:14:12 +01:00
Daniel ImmsandGitHub 02e90ed9c6 Merge pull request #189840 from microsoft/tyriar/78502
Add note to onDidWriteTerminalData API that it's not going to stable
2023-08-07 09:54:32 -07:00
Megan RoggeandGitHub bf2db64337 Merge pull request #189838 from microsoft/merogge/terminal-buffer-label
add aria label to terminal accessible buffer
2023-08-07 09:41:35 -07:00
a31f703941 Making sticky scroll scrollable (#189466)
* work in progress make it scrollabel

* adding changes

* adding changes

* cleaning the code

* cleaning the code

* not usnig a vertical scrollbar

* scanning the dom node only on mouse over

* requires tweaking

* now the scrollbar can be used alongside the hovering on the sticky scroll

* setting handle mouse wheel to false in order not to scroll vertically inside of the scrollable element with wheel

* separated the line numbers and the actual line in order to be able to just move one of the scrollbars, the editor one and the line numbers remain the same

* cleanin the code

* we are able to make the full line appear

* the width is correctly updated on the width layout change of the editor

* only rendering when top scroll changed, not when horizontal scroll changed

* using the correct editor layout info, not the one saved in the constructor

* setting the linehtml node style width to 100% so that the whole line is covered, but still not covered after the end of the viewport

* changing the total width after rendering

* placing the color into sticky line number

* removing the direct setting of the colors

* adding the background color inside of sticky line number

* using the view zone in order to increase the scroll width of the editor

* placing the view zone at the very bottom of the file

* limiting the scrollable dom height to the height of the sticky widget lines node inside, so now the sticky widget works as before

* cleaning the code

* cleaning the code

* removing useless variable

* adding 100 pixels in order to see the end of the line

* removing the console logs

* putting back the check to what it was

* using the same string convention

* adding inheritance properties in order for the background color to be propagated

* cleaning the code

* cleaning the code

* using or instead of and in the zone accessos

* cleaning the code

* cleaning the code

* cleaning the CSS

* chaning the order of the CSS properties

* cleaning the code

* Improve rendering

* No need to resize the widget from the outside, the widget resizes itself

* placing the focus method inside of the sticky widget

* céeanig the code

* Minor tweaks

* Also update widget width when the scroll width changes

* Allow overlay widgets to pass in a minimum content width

* Also update the min content width if the position doesn't change

* defining method for mi content width in px

* updating the minimum content width

* adding setting in order to be able to control whether sticky scroll scrolling should be influenced by editor horizontal scrolling

* removing redundant new line

* Fix typo

* Extract code in a function

---------

Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
2023-08-07 17:35:57 +01:00
RoboandGitHub 143eb0f5ad chore: bump distro (#189835) 2023-08-07 17:35:03 +01:00
Daniel Imms 91acb9551b Add note to onDidWriteTerminalData API that it's not going to stable
Part of #78502
2023-08-07 09:33:29 -07:00
meganrogge 3dd0b931c0 fix 2023-08-07 09:23:46 -07:00
Joyce ErandGitHub 4989674a04 Executing slash command should not select command (#188995) 2023-08-07 08:54:06 -07:00
Daniel ImmsandGitHub adda48889b Merge pull request #189827 from microsoft/tyriar/162950_2
Add link to API proposal
2023-08-07 08:44:42 -07:00
Connor PeetandGitHub 2d2797bba6 debug: let js-debug store the oss profile in workspace storage (default behavior) (#189828)
Fixes #177664
2023-08-07 16:24:07 +01:00
Raymond ZhaoandGitHub e1dfb2a559 Add Settings editor smoke tests (#189687)
Fixes #141054
2023-08-07 08:22:07 -07:00
Johannes RiekenandGitHub 278d86e9ca Merge pull request #189825 from microsoft/joh/wilful-wallaby
emit event when unregistering menu items
2023-08-07 17:11:41 +02:00
Daniel Imms 29d8134419 Add link to API proposal
Part of #162950
2023-08-07 07:56:10 -07:00
Johannes 7ea1f38465 emit event when unregistering menu items
https://github.com/microsoft/vscode/issues/184756
2023-08-07 16:53:34 +02:00
ea490e5545 chore: update to Electron 25 (#188268)
* chore: update electron@25.3.0

* ci: update NodeTool version

* chore: update @types/node

* add more common types to layers checker

* chore: update debian dependencies

* chore: update rpm dependencies

* fix: use legacy dns result order of Node.js

* ci: remove deprecated always-auth npm config

Refs npm/cli@72a7eeb

* chore: update deb and rpm dependencies

* chore: update armhf rpm dependencies

* chore: update x64 debian dependencies

* chore: update x64 rpm dependencies

* chore: update electron@25.3.1

* chore: update electron@25.4.0

* chore: bump distro

* chore: bump distro

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-08-07 21:46:27 +09:00
Johannes RiekenandGitHub dd4c9da859 Merge pull request #189607 from SevenOutman/issue186399
Add "Peek Call Hierarchy" and "Peek Type Hierarchy" actions to Command Palette
2023-08-07 11:16:48 +02:00
Johannes RiekenandGitHub 4bb9f7f4f8 Merge pull request #189181 from jjaeggli/suggest-notify
Suggest should notify with aria.status when "Loading" or "No suggestions" is displayed
2023-08-07 11:11:00 +02:00
Daniel ImmsandGitHub 850c1dd045 Merge pull request #188693 from timar07/fix-xterm-quickfix-position
fix: xterm quick fix appears in wrong spot #169162
2023-08-06 23:57:05 -07:00
Daniel ImmsandGitHub c5ccc30caf Merge branch 'main' into fix-xterm-quickfix-position 2023-08-05 06:35:50 -07:00
Megan RoggeandGitHub 1606401f5b Merge pull request #189681 from microsoft/merogge/fix-hover-hint
add accessible view hint to hover aria labels instead of using `status`, provide way to disable the hint
2023-08-04 15:10:20 -07:00
Daniel ImmsandGitHub 90fb257ebd Merge pull request #189685 from microsoft/tyriar/type_remote
Use const enum values instead of strings for remote calls
2023-08-04 14:56:17 -07:00
Daniel ImmsandGitHub 24cfddac51 Merge pull request #189683 from microsoft/tyriar/187075_2
Fix passing of reviveTerminalProcesses args to remote
2023-08-04 14:56:06 -07:00
meganrogge 659356ff9c fix issues 2023-08-04 14:53:30 -07:00
Daniel Imms 89598468e3 Use const enum values instead of strings for remote calls 2023-08-04 14:35:40 -07:00
meganrogge bc1404e5db fix issues, describe disable action when the view is opened not on the prior element 2023-08-04 14:35:09 -07:00
Daniel Imms e089a44787 Fix passing of reviveTerminalProcesses args to remote
Fixes #187075
2023-08-04 14:24:24 -07:00
meganrogge deb3011d37 move it elsewhere, add other code 2023-08-04 13:59:24 -07:00
meganrogge 39809e9ecc share 2023-08-04 13:15:10 -07:00
meganrogge 016d7901ce fix in the editor hover 2023-08-04 13:07:22 -07:00
meganrogge 4a786f3500 get hint to work for workbench hovers 2023-08-04 12:56:50 -07:00
Megan RoggeandGitHub dfe27a1e3e Merge pull request #189616 from weartist/fix_extension_view_focus_next
Fix: #188751
2023-08-04 12:02:10 -07:00
Daniel ImmsandGitHub 6a025483bd Merge pull request #189670 from microsoft/tyriar/186785
Fix reviving terminals after remote pty host restart
2023-08-04 11:28:24 -07:00
David DossettandGitHub 2b9b59fde5 Fix missing border on simple find widget (#189667) 2023-08-04 10:55:01 -07:00
Joyce ErandGitHub d3adf9ce12 Render filetrees in panel chat responses (#188710)
* API interface

* API plumbing

* Migrate most consumers of `response.value` to use `asString()`

Some of these e.g. a11y may need to be updated to read the tree data once that is added

* Update interfaces to reflect that responses may contain tree data (stubbed)

* Update test

* Actually fix test

* Add doc

* Render filetrees in chat response

* Fix tree data passthrough & accessibility impl

* Layout tree after setting input

* Fix one more `asString()` case

* Render file icons 🎉

* Also revive URIs in serialized chat state

* Dispose of listeners

* Add hover background color

* Remove unnecessary code

* Fix non-child elements disappearing on toggle

* Reuse trees for rendering

* Fix extra content height in response

* Cleanup
2023-08-04 10:53:18 -07:00
Daniel Imms b2d1dfe302 Fix reviving terminals after remote pty host restart
Fixes #186785
2023-08-04 10:43:04 -07:00
SteVen BattenandGitHub 162a1b03bc Prevent side bar snapping interference with scroll (#189666)
fixes #170534
2023-08-04 10:21:08 -07:00
Daniel ImmsandGitHub def44cedc7 Merge pull request #189661 from microsoft/tyriar/188951
Clear old direct proxy on pty host restart
2023-08-04 10:13:02 -07:00
SteVen BattenandGitHub fd190f2ead update titlebar visibility when cc updates (#189662)
fixes #189532
2023-08-04 09:46:32 -07:00
Daniel Imms d2f88fdc75 Clear old direct proxy on pty host restart
Fixes #188951
2023-08-04 09:12:42 -07:00
Megan RoggeandGitHub cd1af5b060 Merge pull request #189659 from microsoft/merogge/fix-bug
focus the accessible view on escape of the symbol quickpick
2023-08-04 08:56:17 -07:00
Daniel ImmsandGitHub 23305b2677 Merge pull request #189656 from microsoft/tyriar/187283
Don't enable smooth scroll when trackpad is used
2023-08-04 08:41:10 -07:00