Commit Graph

99442 Commits

Author SHA1 Message Date
isidor df1b57cdb4 react to @bpasero feedback 2022-08-08 10:59:45 +02:00
Rob Lourens f1c5243126 "input" variables prevent compound configuration from launching more than one session (#157355)
Fixes #141514
2022-08-08 09:20:55 +02:00
Megan Rogge b0895f9fcc wait for terminal reconnection to restore tasks (#157307) 2022-08-07 20:06:36 -07:00
Daniel Imms afbe9605e5 Merge pull request #156486 from gjsjohnmurray/fix-156481
Don't link to deprecated `terminal.integrated.automationShell.*` settings (#156481)
2022-08-07 16:43:59 -07:00
John Murray 66aef7979d Merge branch 'main' into fix-156481 2022-08-06 21:55:58 +01:00
Benjamin Pasero e58c66c819 Issue reporter fails to report when sandbox is enabled (#157368)
issue repoter misses data
2022-08-06 10:37:34 -07:00
Daniel Imms 60f1e28df6 Merge pull request #157330 from microsoft/tyriar/reattach
Improved reconnection logging and throw when attaching to orphan processes
2022-08-06 08:01:03 -07:00
Daniel Imms cb79d01555 Merge pull request #157350 from microsoft/tyriar/fix_ps1_tests
Fix pwsh shell integration tests
2022-08-05 16:48:00 -07:00
Daniel Imms 938ad8b418 Merge pull request #157272 from microsoft/tyriar/157226
Escape % in bash shell integration
2022-08-05 16:42:03 -07:00
Daniel Imms b01f24b6f9 Merge pull request #157348 from microsoft/merogge/z
reset `ZDOTDIR` to user's for non-login shells
2022-08-05 16:41:20 -07:00
Daniel Imms 8eeac1fb29 Fix pwsh shell integration tests
Part of #157083
2022-08-05 16:33:19 -07:00
meganrogge 8cfae763ea fix #157128 2022-08-05 16:08:26 -07:00
Peng Lyu 4a0555d948 Fix #149606. Refresh notebook editor focus on tab switching. (#157333) 2022-08-05 14:38:03 -07:00
Daniel Imms b134ea9ec2 Always throw when attaching to orphan processes
Part of #133542
2022-08-05 14:02:46 -07:00
Daniel Imms 49dfe32df2 Change log level for reconnect related logs
Part of #133542
2022-08-05 13:55:26 -07:00
Daniel Imms 7745a4595f Merge pull request #157270 from microsoft/tyriar/157083
Ignore pwsh shell integration script errors on Windows
2022-08-05 13:29:38 -07:00
Peng Lyu 0df35483c2 Align Cell Markup/Markdown (#157289) 2022-08-05 13:25:34 -07:00
Connor Peet 24547bcd8e labels: fix caching of unintended formatters (#157313)
* labels: fix caching of unintended formatters

`this.formatters` was the same list instance stored in the memo, so we
could cache things we didn't want to. I believe this caused #156135,
since things we _intend_ to cache from the extension host are parsed
from JSON and cannot be circular.

Fixes #156135

* labels: rev label storage to avoid previous bugs

Fixes #155844

* fixup! tets
2022-08-05 22:13:58 +02:00
Rob Lourens b3a5653de7 Don't show unbound breakpoint indicator for disabled breakpoints (#157319)
Fixes #157317
2022-08-05 13:01:46 -07:00
Connor Peet fbda011715 build: do proper hashing for built-in dependencies (#157295)
Fixes #157244
2022-08-05 13:00:33 -07:00
Rob Lourens 81978e984b Don't try to reveal an element that doesn't exist in the tree (#157309) 2022-08-05 15:34:40 -04:00
Andrea Mah 97d94fc23b Add delete and undo support for get most recently failed cell (#157032)
* "Go To" last failing cell should disappear when deleting that cell
Fixes #156299
2022-08-05 12:20:53 -07:00
Peng Lyu 60c53f18dd fix #155222. Adjust focus gutter indicator for markup cell. (#157286)
* fix #155222. Adjust focus gutter indicator for markup cell.

* 💄
2022-08-05 15:00:13 -04:00
Matt Bierner a97d84d375 Don't re-render markdown cells on initializeWebViewState (#157173)
Fixes #156914

I don't really understand what `initializeWebViewState` is doing here but there are two things:

- I've removed a list of renderers it creates and then never uses
- I've removed the part where it calls back into `initializeMarkup`. This should have already been called during `_warmupViewport`
2022-08-05 11:58:54 -07:00
Peng Lyu 0f9323e411 Fix #157301. Fix process explorer scrolling (#157305) 2022-08-05 11:48:01 -07:00
Logan Ramos 46b6f3eb64 Better telemetry adblock check (#157279)
Dynamic adblock check based on telemetry setting
2022-08-05 11:20:48 -07:00
Connor Peet f314f642da testing: ensure tests run in multiple profiles are in the same task (#157302) 2022-08-05 11:08:06 -07:00
Rob Lourens 8671778f8d Fix notebook execution test failures (#157290)
* Fix notebook execution test failures
An error thrown in an event handler did not cause the test to fail, using DeferredPromise. Adjusting the api event to account for Unconfirmed vs Pending states. And accounting for onDidChangeNotebookDocument being fired multiple times during a test, causing the test to complete early while execution was still happening.
Fixes #157067

* Remove log
2022-08-05 11:07:20 -07:00
Matt Bierner 6d24a019d8 Remove dom.createEventEmitter (#157296)
As far as I can tell this class has the same functionality as `DomEmitter`
2022-08-05 19:24:40 +02:00
Matt Bierner 427530e884 Remove event.ts stopEvent (#157182)
Remove event.stopEvent

This function has the same function as EventHelper.stop but is only used in one place
2022-08-05 19:16:45 +02:00
FantasqueX 02505d3499 Fix typos in files.ts (#157280)
Fix typo in files.ts

Signed-off-by: Letu Ren <fantasquex@gmail.com>
2022-08-05 09:52:55 -07:00
Daniel Imms 408fa026da Also escape % in zsh 2022-08-05 09:30:59 -07:00
Connor Peet 39e77d74ca fix: parse errors in coverage command (#156837)
Fixes #155615
2022-08-05 18:27:40 +02:00
David Dossett 31cc3b8987 Fix suggestEnabledInput text selection contrast (#157172) 2022-08-05 09:05:12 -07:00
Alexandru Dima b524d80d9c Send a disconnection message via the management connection before killing the local extension host (#157269)
Fixes #156690: Send a disconnection message via the management connection before killing the local extension host
2022-08-05 17:37:45 +02:00
Daniel Imms 5b23b086ff Escape % in bash shell integration
Part of #157226
2022-08-05 07:29:12 -07:00
Daniel Imms 4cc23f1ecb Ignore shell integration script errors
Part of #157083
2022-08-05 07:05:28 -07:00
Isidor Nikolic 7888ff3a6b Merge pull request #157256 from microsoft/isidorn/distinctive-bovid
actionViewItem - make sure to also set the aira-label on the label element
2022-08-05 15:16:07 +02:00
Alexandru Dima c0560907e9 Merge pull request #157171 from mjbvz/able-rooster
Try using AbortController for disposable dom listeners
2022-08-05 15:06:16 +02:00
zhuowei 0fa4923c85 simpleFileDialog: ask user if we should create directory if it doesn't exist when saving (#152536)
When saving a file using the SimpleFileDialog (for example, when editing a file over SSH), if the directory doesn't exist, the user currently has to cancel saving, create the directory, then try saving again.

This adds a prompt to allow the user to create any missing directories from the save dialog directly.

Tested with the TestResolver in Code - OSS.

I wasn't able to get the Remote - SSH extension working in Code - OSS, but it should work there, since FileService.writeFile calls mkdirp to create missing folders, so this should work with all remote providers.

Fixes #71425.

Co-authored-by: Alex Ross <alros@microsoft.com>
2022-08-05 14:53:35 +02:00
isidor e60f7a9d8a actionViewItem - make sure to also set the aira-label on the label element
fixes #155880
2022-08-05 13:40:01 +02:00
Benjamin Pasero ce5685e34f themes - disable window border on windows (#157223) 2022-08-05 13:30:32 +02:00
Benjamin Pasero cc068ee992 sandbox - log if sandboxed in telemetry (#157221)
* sandbox - log if sandboxed in telemetry

* add todo
2022-08-05 12:06:07 +02:00
Benjamin Pasero 73fd3f1103 fix build (#157217)
* fix build

* fix compile

* flaky

* .
2022-08-05 09:16:20 +02:00
Aiday Marlen Kyzy 0af9e099c9 Merge pull request #157101 from microsoft/aiday/issue156999
Make sticky scroll disappear on the line before the end of the scope. Fixes #156999.
2022-08-05 09:15:59 +02:00
Matt Bierner 07e45c5a71 Fix package version (#157202)
Not sure why this was not caught by earlier builds
2022-08-04 21:40:06 -07:00
Matt Bierner 7b5e82ebcf Rename context to align with other webview context keys (#157174)
For #30066
2022-08-05 06:32:02 +02:00
Matt Bierner b012216211 Fix markdown images having duplicate ids (#157177)
Fixes #153144
2022-08-05 06:31:42 +02:00
Matt Bierner 5589b81019 Remove IStandardWindow (#157181)
This was added to support old IE versions which we no longer support https://github.com/microsoft/monaco-editor/issues/26
2022-08-05 06:22:28 +02:00
Matt Bierner 5908f17750 Remove a few IE8 conditions (#157179)
These should no longer be needed
2022-08-05 06:21:59 +02:00