Commit Graph

102716 Commits

Author SHA1 Message Date
Ladislau Szomoru dff6f568a1 GitHub - fix dialog when user does not have permissions to commit (#166595) 2022-11-17 07:36:54 -08:00
João Moreno a24677d00e fixes #166552 (#166594) 2022-11-17 07:27:04 -08:00
Logan Ramos c20c7d5adb Update getting-started assignment (#166592)
* Remove i18n causing classifier to fail due to missing label

* 🎁 Add `killOnServerStop` to debug configuration (#163779)

* 🎁 Add `killOnServerStop` to schema

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 📜 Add description for `killOnServerStop`

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Stop created debug session on server stop

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Push kill listeners into another disposable container

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🐛 Prevent leak when new debug session fails to start

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Use more verbose name for debug session tracker ID

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* assign bhayva to getting started

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Co-authored-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2022-11-17 07:21:29 -08:00
Martin Aeschlimann 4759e0b928 refactor styling of toggle, dialog, inputbox & checkbox (#166542)
* refactor styling of toggle, dialog, inputbox & checkbox

* simplify abstract tree styling

Co-authored-by: Joao Moreno <joao.moreno@microsoft.com>
2022-11-17 07:20:33 -08:00
Johannes Rieken f8c9ae79ea Merge pull request #166461 from babakks/add-focus-breadcrumb-to-cmd-palette
🔨 Add "Focus Breadcrumb" to command palette
2022-11-17 15:55:24 +01:00
Logan Ramos 10ae860842 Remove i18n causing classifier to fail due to missing label (#166587) 2022-11-17 06:42:55 -08:00
Babak K. Shandiz 9f56e365d7 🎁 Add killOnServerStop to debug configuration (#163779)
* 🎁 Add `killOnServerStop` to schema

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 📜 Add description for `killOnServerStop`

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Stop created debug session on server stop

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Push kill listeners into another disposable container

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🐛 Prevent leak when new debug session fails to start

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Use more verbose name for debug session tracker ID

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2022-11-17 06:20:08 -08:00
Alex Ross 328ed10651 Git drop stash commands should use modal dialog (#166573)
Since the warning is initiated through user action, and the user is required to interact with the warning to finish their intended action we should use a modal dialog here.
2022-11-17 12:49:56 +01:00
Sandeep Somavarapu 54e3652042 fix #166350 (#166572) 2022-11-17 03:35:36 -08:00
Alex Ross 6ce31d9e1c Remove split button from comments additional actions (#166568)
and add a max number of 4 actions
Part of #163281
2022-11-17 03:13:33 -08:00
Marcus Revaj aaac6f9a99 Add additional actions to CommentThread (#162750)
* # Add additional actions to CommentThread

* Add in forgotten property

* # missing declaration

* type change

* Fix merge conflict errors

* # add proposed changes + fix styling

* # Allow "secondary action only" buttons

* # Add dropdown button styling fixes

* # add default button styling

* # add better styling to the dropdown button

* Remove duplicate css rule

Co-authored-by: Alex Ross <alros@microsoft.com>
2022-11-17 11:16:06 +01:00
Babak K. Shandiz f6c8436c21 💄 Include breadcrumbs.focusAndSelect in command palette
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2022-11-17 09:53:13 +00:00
Babak K. Shandiz 4bfa86cdbf Remove unnecessary code
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
2022-11-17 09:51:43 +00:00
Johannes Rieken f675b2bfab remove some any casts that aren't needed (anymore) (#166557) 2022-11-17 09:58:12 +01:00
Daniel Martinez Olivas 562b3dbd54 moves css rules (#166532) 2022-11-17 09:50:56 +01:00
Han e109887634 Adapter css variables (#166279)
* move css variables from markersViewActions.ts to markersViewActions.css

* move css variables from testingOutputPeek.ts to testingOutputPeek.css

* move css variables from linkedEditing.ts to linkedEditing.css

* move css variables from interactiveEditor.ts to interactiveEditor.css

* add editor linked editing color to color registry

* 💄

* add css import

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-11-17 08:53:56 +01:00
Rob Lourens d9a70c4236 Wait for disconnect response before terminating DA (#166137)
Fix #165138
2022-11-16 20:07:56 -08:00
Megan Rogge 8cae5f6bfe use correct icons, remove ellipsis (#166493) 2022-11-16 19:16:04 -08:00
Peng Lyu 0182a4bf39 Kernel picker type: all/mru. (#166523) 2022-11-16 16:41:54 -08:00
Sandeep Somavarapu 126fd696da implement import/export profiles (#166517)
* implement import/export profiles
- include all resources
- include all user profile storage
- show import/export preview view

* fix compilation
2022-11-16 18:57:31 -05:00
Peng Lyu 8007c63981 Kernel mru picker preparation (#166513)
* MRU skeleton

* Kernel Source Provider

* filter

* register provider in exthost

* Misc changes

* Revert to suggestions

* non jupyter controllers

* Add ability to select a kernel

* show extension name in detail.

* 💄

* Move strategies out.

* Back button

* First arg be the notebook document

* 💄

* Update kernel status

* Show progress in MRU

* remove separator header

* Allow selecting 3rd party controllers

* Misc

* Fix spinner

* Add separators in kernel picker

* Update kernel select title.

* Prep for MRU.

Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
2022-11-16 15:42:41 -08:00
Joyce Er 94a1ec7999 Merge pull request #165783 from microsoft/dev/joyceerhl/gothic-wallaby
Generate implicit activation events from declared extension contributions
2022-11-16 15:20:42 -08:00
Megan Rogge 91c7eaf973 add audio cues for reviewing a diff editor (#166413) 2022-11-16 15:10:45 -08:00
Aaron Munger 5588a85039 Merge pull request #166512 from amunger/integrationTest
Don't rely on notebook focus when adding cells
2022-11-16 14:58:30 -08:00
Matt Bierner 0b32e51db3 💄 (#166414)
- Remove extra types
- Fix class name in message
2022-11-16 14:50:07 -08:00
Matt Bierner 18cf7911c1 Make copy paste and drop into editor idle contributions (#166510)
These are not needed the very instant the editor starts up
2022-11-16 14:48:01 -08:00
Andrea Mah 9318bcc518 Search Contributions Cleanup (#165538)
Major cleanup on search contribs/actions, namely:
- converting all `Action` and related registrations to `Action2`
- Converting the `Actionbar` that appears on hover of a search result to `MenuWorkbenchToolBar`
- Overall organization
- Converting any `ICommandHandler` to functions if they don't need to be `ICommandHandler`
- Adding titles to all search commands
2022-11-16 14:37:44 -08:00
Matt Bierner 838b48504c Pick up TS 4.9 final (#166509) 2022-11-16 14:16:36 -08:00
Connor Peet 707f91aaa6 cli: fix 'failed to lookup tunnel' with a name given (#166507)
Fixes https://github.com/microsoft/vscode-cli/issues/563

If a new tunnel `--name` was provided but the existing tunnel was deleted,
the CLI would error out with a lookup failed message. Instead it now
recreates it like it normally would.
2022-11-16 14:10:49 -08:00
Logan Ramos a1d42637be Exempt perf markers from telemetry cleaning (#166508) 2022-11-16 14:07:38 -08:00
aamunger 2deaa43aa6 specify notebook document 2022-11-16 14:01:31 -08:00
Daniel Imms 1f50215e1f Merge pull request #166497 from microsoft/tyriar/166496
Fix casing of action widget hover
2022-11-16 11:59:21 -08:00
SteVen Batten a60b513c45 fix cleaning on windows (#166498) 2022-11-16 11:44:45 -08:00
Logan Ramos 8deed65f64 Allow the ability to opt out of cleaning (#166136)
* Add the ability to opt out of data cleaning

* Comment

* Update to Joh's suggested solution
2022-11-16 11:41:04 -08:00
Logan Ramos 6e3dbd4a91 Bump distro (#166494) 2022-11-16 11:20:12 -08:00
Daniel Imms a61a96ba49 Fix casing of action widget hover
Fixes #166496
2022-11-16 11:13:48 -08:00
Johannes Rieken 544f1cab66 Merge pull request #166486 from microsoft/joh/yielding-marten
don't use any-cast to access private or protected members
2022-11-16 19:22:03 +01:00
Johannes 76cdb404d8 update all re-declarations of the model-property 2022-11-16 19:06:09 +01:00
Johannes 9b42db9fcb don't use any-cast to access private or protected members
fixes https://github.com/microsoft/vscode/issues/166478
2022-11-16 19:03:39 +01:00
Joyce Er e6a50551ff 🆙 distro (#166482) 2022-11-16 18:50:50 +01:00
Connor Peet 02b5cca0ae Merge pull request #166411 from microsoft/cli/macos-service-monitoring
cli: add service integration for macos, observability
2022-11-16 09:38:17 -08:00
Greg Van Liew 816f31f691 More settings description tuning (#166429) 2022-11-16 09:33:33 -08:00
Connor Peet 4c251676ef clippy fixes 2022-11-16 08:51:47 -08:00
bhavyaus 5f11d2f9a3 Set group size to half width on toSide (#166421) 2022-11-16 08:36:23 -08:00
Han d34224b85f Move css rules from inPlaceReplace.ts into inPlaceReplace.css (#166098)
* #165169 Move css rules from inPlaceReplace.ts into inPlaceReplace.css

* #165169 Move css rules from ghostTextWidget.ts into ghostTextWidget.css

* #165169 Move css rules from links.ts into links.css

* #165169 Move css rules from findOptionsWidget.ts into findOptionsWidget.css

* 💄

* supplement missing attributes for findOptionsWidget.css

* 💄

* 💄

* 💄

* Revert "💄"

This reverts commit 776684dc95.

* 💄

* rm the wrong assignment

Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2022-11-16 16:12:54 +01:00
João Moreno ee763408fb remove codeql gh action (#166468) 2022-11-16 07:12:36 -08:00
João Moreno aa461e19a6 add trace logging to NativePolicyService (#166462)
related to #163418
2022-11-16 06:19:57 -08:00
bhavyaus 3813f98692 Import gettingStartedColors (#166402) 2022-11-16 09:06:29 -05:00
Logan Ramos 39ff7eb93b Bump distro (#166459) 2022-11-16 05:43:29 -08:00
Johannes Rieken 72def61fae Merge pull request #166126 from microsoft/joh/rewrite-privates
TS - mangle private and protected props
2022-11-16 14:42:11 +01:00