João Moreno
e2aa12d977
ensureNoDisposablesAreLeakedInTestSuite: paging ( #192477 )
...
* ensureNoDisposablesAreLeakedInTestSuite: paging
related to #190503
* fix hygiene
2023-09-08 14:16:40 +02:00
Henning Dieterichs
758b4561b2
Improves error reporting. FYI @jrieken
2023-09-08 14:16:07 +02:00
Alex Ross
91fa749999
Fix local port error message ( #192552 )
...
Fixes #191929
2023-09-08 14:15:36 +02:00
Benjamin Pasero
9238c19bf1
debt - fix more unit test disposables ( #192538 )
...
* debt - fix more unit test disposables
* input
* input
* input
* input
* input
* input
* input
2023-09-08 14:15:04 +02:00
Johannes Rieken
1a3cfcf0ae
Merge pull request #192528 from microsoft/joh/breakable-mule
...
Joh/breakable-mule
2023-09-08 11:57:21 +02:00
Sandeep Somavarapu
734f92af9e
#190503 adopt to ensureNoDisposablesAreLeakedInTestSuite ( #192542 )
2023-09-08 11:01:38 +02:00
Sandeep Somavarapu
a4f08120ca
remove timeout ( #192541 )
2023-09-08 10:56:13 +02:00
João Moreno
2fdfa4627e
ensureNoDisposablesAreLeakedInTestSuite: lists and trees ( #192536 )
...
related to #190503
2023-09-08 10:44:04 +02:00
Johannes
ca6c87ff5c
Revert "Revert "Improves leak detection reporting.""
...
This reverts commit e541752986 .
2023-09-08 10:42:19 +02:00
Christof Marti
e073d674f3
Revert "feat: quick fix for redundant activation events ( #192495 )"
...
This reverts commit 0b4fd719e3 .
2023-09-08 10:31:35 +02:00
Benjamin Pasero
6777698a46
Unit test warnings: Throttler is disposed ( fix #192425 ) ( #192530 )
2023-09-08 10:27:14 +02:00
Johannes
aa24f9bf8c
some more ensureNoDisposablesAreLeakedInTestSuite adoptions
2023-09-08 09:58:49 +02:00
Johannes
e541752986
Revert "Improves leak detection reporting."
...
This reverts commit 1ad9d25cd5 .
2023-09-08 09:43:50 +02:00
Johannes Rieken
207caf648e
Merge pull request #192524 from microsoft/joh/frantic-chipmunk
...
fix some error logs for inline chat test
2023-09-08 09:41:39 +02:00
Johannes
9f8b0442d5
fix some error logs for inline chat test
...
https://github.com/microsoft/vscode/issues/192446
2023-09-08 09:23:48 +02:00
Sandeep Somavarapu
c63939af5b
adopt to ensureNoDisposablesAreLeakedInTestSuite ( #192522 )
...
#190503 adopt to ensureNoDisposablesAreLeakedInTestSuite
2023-09-08 09:09:55 +02:00
Benjamin Pasero
2f1fcb0b18
debt - enable skipped tests again ( #192515 )
2023-09-08 08:04:39 +02:00
Rob Lourens
d3b4505ef8
Debug test cleanup ( #192503 )
...
* Fix #192430
* Fix Debug ANSI tests that don't pass when run on their own
2023-09-08 02:28:20 +02:00
Tyler James Leonhardt
9fbd538cb3
Revert back to 2/3rds ( #192502 )
...
It was higher for debugging purposes.
2023-09-08 02:23:16 +02:00
Joyce Er
c9f35824b1
fix: don't show inline chat hint in output ( #192500 )
2023-09-08 01:36:17 +02:00
Connor Peet
b45dd06f62
Merge pull request #192499 from microsoft/connor4312/issue192409
...
testing: small fixes
2023-09-07 16:28:50 -07:00
Andrea Mah
c410d555fb
Cannot read properties of undefined (reading 'getSearchHistory') ( #192489 )
...
Fixes #189330
2023-09-07 16:13:41 -07:00
Connor Peet
b622283962
testing: use standard formatting for meta-messages in terminal
...
Fixes #192441
2023-09-07 16:10:21 -07:00
Connor Peet
4bc69a022a
testing: fix duplicate message for old results in terminal
...
Fixes #192436
2023-09-07 16:08:17 -07:00
Connor Peet
90654e8a06
testing: add separator between editor and list
...
Fixes #192409
2023-09-07 16:05:44 -07:00
Tyler James Leonhardt
d1594ed4e7
Use a logger ( #192496 )
...
Fixes https://github.com/microsoft/vscode/issues/192442
2023-09-08 00:30:15 +02:00
Joyce Er
0b4fd719e3
feat: quick fix for redundant activation events ( #192495 )
2023-09-07 15:12:23 -07:00
Tyler James Leonhardt
53d03d0742
Implement a "pending store" and only actually store the last one ( #192488 )
...
ref https://github.com/microsoft/vscode/issues/186693
2023-09-07 14:32:15 -07:00
Connor Peet
530f01336e
debug: some disassembly improvements ( #192483 )
...
* debug: some disassembly improvements
Fixes #191925 -- this was the largest change. Things seem to work well
in mock debug.
Then fixing some low-hanging fruit while I'm in the area:
Fixes #185314
Fixes #142571 (if I understand correctly)
Fixes #129527
Fixes #140562
Fixes #131669
Fixes #129655
* rm log
2023-09-07 14:11:01 -07:00
João Moreno
6de0c2326e
ensureNoDisposablesAreLeakedInTestSuite in splitview, gridview and grid ( #192473 )
2023-09-07 14:08:18 -07:00
Aaron Munger
7bc8e35b89
Merge pull request #192472 from microsoft/aamunger/scrollableOutput
...
page up/down should only scroll scrollable output when focused
2023-09-07 13:41:59 -07:00
João Moreno
b404fdc971
ensureNoDisposablesAreLeakedInTestSuite: zip ( #192476 )
...
related to #190503
2023-09-07 13:10:18 -07:00
Aaron Munger
808dd6dded
page up/down should only scroll scrollable output when focused
2023-09-07 11:57:02 -07:00
Daniel Imms
b85c99c7b6
Merge pull request #192453 from microsoft/tyriar/192451
...
Remove overriding of dispose from terminal
2023-09-07 11:27:36 -07:00
Sandeep Somavarapu
127eff7506
#190503 adopt to ensureNoDisposablesAreLeakedInTestSuite ( #192465 )
2023-09-07 11:25:27 -07:00
Daniel Imms
c70814cb87
Merge pull request #192458 from microsoft/tyriar/xterm_230907
...
xterm@5.3.0-beta.73
2023-09-07 11:24:09 -07:00
Daniel Imms
c275a04d43
Merge pull request #192450 from microsoft/tyriar/throttler
...
Fix Throttler dispose warning in unit tests
2023-09-07 10:33:35 -07:00
Tyler James Leonhardt
7303649696
Show theme id if it differs from label ( #192459 )
...
The idea here is that when the label is localized, it will be different than the id... so the id will be displayed next to the label.
This is similar to Configure Display Language... and also somewhat similar to the Command Palette showing the English label under the localized label.
Fixes https://github.com/microsoft/vscode/issues/192223
2023-09-07 19:23:47 +02:00
Daniel Imms
45dfc81349
xterm@5.3.0-beta.73
...
Fixes #192162
2023-09-07 09:56:10 -07:00
Peng Lyu
5a400e53e9
Merge pull request #192431 from microsoft/rebornix/grumpy-lynx
...
Re #190503 . Dispose components in editor/keyboard/list tests.
2023-09-07 09:52:24 -07:00
Daniel Imms
3ebfeebe3a
Remove overriding of dispose from terminal
...
This removed all cases except for the ones that could easily introduce
regressions.
Fixes #192451
2023-09-07 09:33:45 -07:00
Daniel Imms
34eeab3023
Fix Throttler dispose warning in unit tests
...
This was happening because dispose was being overridden so the isDisposed check
before a store is disposed again wasn't happening just for the throttler.
Fixes #192427
Fixes #192434
Part of #192425
2023-09-07 09:21:11 -07:00
Aaron Munger
821b6a1fa3
Merge pull request #192347 from microsoft/aamunger/notebookTestLeaks
...
ensure no leaked disposables in notebook tests
2023-09-07 08:55:08 -07:00
Daniel Imms
9560d57267
Merge pull request #192336 from microsoft/tyriar/190503
...
Adopt ensureNoDisposablesAreLeakedInTestSuite in terminal
2023-09-07 08:51:31 -07:00
Alex Ross
39cf14968a
Fix some leaks found by ensureNoDisposables... ( #192418 )
...
Part of #190503
2023-09-07 17:34:49 +02:00
rebornix
ba0ea792a5
Re #190503 . Dispose components in editor/keyboard/list tests.
2023-09-07 08:28:59 -07:00
Benjamin Pasero
c831e73d5f
debt - ensure more dispose from tests ( #192415 )
2023-09-07 16:51:32 +02:00
Alex Ross
971db807fb
Fix tab index of tree checkbox ( #192413 )
...
Fixes #189342
2023-09-07 16:13:30 +02:00
Benjamin Pasero
242d96340a
debt - dispose things in tests ( #192392 )
...
* debt - ensure more dispose from tests
* more
* input
* .
* more
* input
* inp
* fux
2023-09-07 16:03:20 +02:00
Sandeep Somavarapu
ae8de5902b
add logging when updating token ( #192412 )
2023-09-08 00:02:20 +10:00