Commit Graph

124157 Commits

Author SHA1 Message Date
Daniel Imms 376fd4561d Fix file clasification for extensions containing numbers
Fixes #224486
2024-08-01 08:53:27 -07:00
Justin Chen 3ccbb8a3be center aux window on current screen (#224440)
center issue reporter window
2024-07-31 23:43:56 -07:00
Bhavya U c0331c89c6 Remove on-label workflow (#224448) 2024-07-31 18:22:31 -07:00
Matt Bierner f0e91628e9 Fix unclosed code setting tag in release notes rendering (#224407)
* Fix unclosed code setting tag

* Fix test too
2024-07-31 17:14:44 -07:00
Rob Lourens b34298a3de Disable chat "thumbs up" button by default (#224443)
* Disable chat "thumbs up" button by default
Roll out with an experiment

* Flip experiment key

* Fix tests
2024-07-31 16:17:59 -07:00
Rob Lourens e28695268f Fix extra space under chat confirm widget (#224444)
Fix microsoft/vscode-copilot#6416
2024-07-31 14:58:19 -07:00
Rob Lourens 6c37657f06 Persist chat sessions in empty windows (#224430)
fix microsoft/vscode-copilot-release#1309
2024-07-31 13:11:13 -07:00
Bhavya U cdf38dc08e Remove on-open workflow (#224425) 2024-07-31 13:04:27 -07:00
Rob Moran 2b8881a7fd Add viewContainer contribution point (#212499)
* viewContainer contribution point

Signed-off-by: thegecko <rob.moran@arm.com>

* Updates from feedback

* Make extension point debug-only

* Rename proposal

---------

Signed-off-by: thegecko <rob.moran@arm.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
2024-07-31 12:54:21 -07:00
Daniel Imms 263eb7015b Merge pull request #224429 from microsoft/tyriar/excl_question
Also exclude $ from comletions from start logic
2024-07-31 12:09:37 -07:00
Daniel Imms cde35bb79b Also exclude $ from comletions from start logic 2024-07-31 11:53:52 -07:00
Bhavya U 0de5dad197 Remove bad-tag workflow (#224428) 2024-07-31 11:49:40 -07:00
Megan Rogge 14253f3cd9 fix flaky terminal persistence smoke test (#224414)
fix #216464
2024-07-31 11:25:36 -07:00
Megan Rogge 52e0f91d25 polish debug accessibility help dialogs, introduce Clear Console keybinding (#224409)
fixes #223959
2024-07-31 11:25:08 -07:00
Daniel Imms ae1b5e09c4 Merge pull request #224420 from microsoft/tyriar/224419
Request completions for args at beginning of word
2024-07-31 11:15:28 -07:00
Megan Rogge 67e68dbfd2 terminal chat cleanup (#224416)
fix #214797
2024-07-31 11:14:23 -07:00
Connor Peet 84f25c7827 debug: scope theme colors of breakpoints (#224417)
Fixes #224357
2024-07-31 11:05:13 -07:00
Daniel Imms 33458a85b5 Request completions for args at beginning of word
Fixes #224419
2024-07-31 10:58:03 -07:00
Michael Lively 79327ff958 Fix all x-model highlight flickering (#224415)
fix all x-model highlight flickering
2024-07-31 10:54:04 -07:00
Benjamin Pasero 284a605d61 NLS can get mixed up when stable overwrites insider metadata (fix #224385) (#224405) 2024-07-31 19:20:45 +02:00
Connor Peet 6f2764acf8 dom: make SafeTriangle smaller, add tests (#224401)
* debug: improve behavior for slow-running prelaunch tasks

Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes #218267

* hygenie

* dom: make SafeTriangle smaller, add tests
2024-07-31 09:31:05 -07:00
Benjamin Pasero 830e533dc0 Open Editors list is displays incorrect list when the SCM Working Sets feature is used (fix #219159) (#224399) 2024-07-31 09:27:19 -07:00
Daniel Imms 59a301ac73 Merge pull request #224398 from microsoft/tyriar/prompt_prefix
Add a convenience prop for prompt prefix
2024-07-31 09:26:26 -07:00
Bhavya U d9d5b1e1da Remove on-comments workflow and update commands (#224355) 2024-07-31 09:14:47 -07:00
Daniel Imms c3b93749cd Add a convenience prop for prompt prefix 2024-07-31 09:04:12 -07:00
Daniel Imms ab9c44e7ab Merge pull request #224396 from microsoft/tyriar/223883
Don't trigger suggest after [^\s]-
2024-07-31 09:01:34 -07:00
Bhavya U 3c737ad0f0 Remove release-pipeline labeler (#224342) 2024-07-31 08:58:41 -07:00
Ladislau Szomoru 151e03b633 Git - add support for reftable storage format (#224395) 2024-07-31 08:49:46 -07:00
Daniel Imms 990fdb02a6 Don't trigger suggest after [^\s]-
Fixes #223883
2024-07-31 08:45:51 -07:00
Daniel Imms cfcc0cdf38 Merge pull request #224393 from microsoft/tyriar/216564
Skip all terminal smoke tests on Linux
2024-07-31 08:27:35 -07:00
Daniel Imms 249b7c2c78 Skip all terminal smoke tests on Linux
These can flake due to the pty host crashing. Disabling for now, they require
more investigation. Tracked in #216564
2024-07-31 08:04:09 -07:00
Benjamin Pasero b18a8c5495 esm - reduce diff (#224388) 2024-07-31 15:59:06 +02:00
Alex Ross e23a9db6f3 Cannot parse treesitter telemetry (#224387)
Fixes #224310
2024-07-31 15:13:58 +02:00
Alexandru Dima d90ab31527 Revert StableEditorScroll changes (#224289)
Revert "Fixes #216824"

This reverts commit f46e9223f6.
2024-07-31 15:52:56 +03:00
Alex Ross ad5b8c3ebf Use trash icon to collapse empty comment threads (#224381)
Use trash icon to collaps empty comment threads
2024-07-31 14:09:50 +02:00
Alex Ross ae6995d6e9 Improve comment view behavior for empty comment (#224379) 2024-07-31 14:09:14 +02:00
Alex Ross 5410988877 Skip terminal editor tests (#224375)
Part of #224269
2024-07-31 01:29:03 -07:00
Justin Chen 41652ed737 new issue form service refactor (#224242)
* fix merge conflicts and refactor on issue form

* large rehaul, removing more stuff, merging into main base issue reporter service now

* more cleanup

* remove unused window configuration

* some cleanup

* more cleanup
2024-07-30 23:57:19 -07:00
Rob Lourens ddbd4f0e1f Add hover for breakpoint widget placeholder (#224356)
* Add hover for breakpoint widget placeholder
Because it can easily be cut off in a slightly narrow editor
Fix #221506

* cast
2024-07-30 20:31:18 -07:00
Connor Peet f7deb0ae46 editor: fix glyph margin links not working (#224352)
* debug: improve behavior for slow-running prelaunch tasks

Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes #218267

* hygenie

* editor: fix glyph margin links not working

The constructor was missing decorations, so _openingService was always undefined and links did not open.

Fixes #214786

cc @aiday-mar
2024-07-30 18:13:34 -07:00
Connor Peet 85fe3e7dfc testing: fix message lineBackground not being functional (#224303)
* testing: fix message lineBackground not being functional

Fixes #221264

* hygenie
2024-07-30 17:04:59 -07:00
Rob Lourens 3304003478 Spawn .bat/.cmd DebugAdapterExecutables with shell=true (#224350)
Spawn .bat/.cmd DebugAdapterExecutables with shell=true (#224320)

* Spawn .bat DAs with shell=true

* Also escape args

* And .cmd

* escape argument properly

* Don't escape \
2024-07-30 16:59:54 -07:00
Matt Bierner 9b08d9909a Add better link matching for chat streaming (#224345)
* Add better link matching for chat streaming

Another part of #224244

* Adding tests for parens and brackets
2024-07-30 16:59:35 -07:00
Connor Peet 5533ce3daa activity: require progress to be longer to count towards activity (#224349)
Unfortunately we don't have a signal around progress for what's user initiated or not. This attempts to solve the problem in a different way by only counting long-running progress towards activity, such that the occasional background updates that Git does are unlikely to cause the state to change.

Fixes #221396
2024-07-30 16:53:59 -07:00
Matt Bierner 84607a2fe2 Fix some always true/false errors in codebase (#223359)
* Fix some always true/false errors in codebase

Testing out latest TS nightly that can identify when an expression is always true/false. This caught a few likely coding mistakes in our codebase

Unsure about the intent in some of these cases but I've tried my best to understand them. Pinging relevant code owners for the confusing cases

* Bump TS version

* Fix unreachable in build scripts

* Bump versions

* restore intent

* Revert package.json change

* Fixing a few new layer checker errors

These are global in node now

* Skip lib check in integration project

* One more skiplibcheck

* More skip lib

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@gmail.com>
2024-07-30 15:37:27 -07:00
Megan Rogge ce8baddd73 select command line for windows bc aria alert does not work (#224341) 2024-07-30 15:01:50 -07:00
Anees Ahee 7d0a6b8a0a Fix missing "Restart TS Server" command in Command Palette (#223433)
Update TypeScript context keys when tab groups changed

Co-authored-by: Matt Bierner <matb@microsoft.com>
2024-07-30 14:33:33 -07:00
Daniel Imms 4d02fea6f7 Merge pull request #224336 from microsoft/tyriar/224331
Add cd - and + completions
2024-07-30 14:08:24 -07:00
Bhavya U b097a99867 Remove on-reopen workflow (#224334) 2024-07-30 13:57:19 -07:00
Peng Lyu 6886a7f992 feat: enhance notebook logging service. (#224335) 2024-07-30 13:56:52 -07:00