Daniel Imms
45dfc81349
xterm@5.3.0-beta.73
...
Fixes #192162
2023-09-07 09:56:10 -07:00
Peng Lyu and GitHub
5a400e53e9
Merge pull request #192431 from microsoft/rebornix/grumpy-lynx
...
Re #190503 . Dispose components in editor/keyboard/list tests.
2023-09-07 09:52:24 -07:00
Daniel Imms
3ebfeebe3a
Remove overriding of dispose from terminal
...
This removed all cases except for the ones that could easily introduce
regressions.
Fixes #192451
2023-09-07 09:33:45 -07:00
Daniel Imms
34eeab3023
Fix Throttler dispose warning in unit tests
...
This was happening because dispose was being overridden so the isDisposed check
before a store is disposed again wasn't happening just for the throttler.
Fixes #192427
Fixes #192434
Part of #192425
2023-09-07 09:21:11 -07:00
Aaron Munger and GitHub
821b6a1fa3
Merge pull request #192347 from microsoft/aamunger/notebookTestLeaks
...
ensure no leaked disposables in notebook tests
2023-09-07 08:55:08 -07:00
Daniel Imms and GitHub
9560d57267
Merge pull request #192336 from microsoft/tyriar/190503
...
Adopt ensureNoDisposablesAreLeakedInTestSuite in terminal
2023-09-07 08:51:31 -07:00
Alex Ross and GitHub
39cf14968a
Fix some leaks found by ensureNoDisposables... ( #192418 )
...
Part of #190503
2023-09-07 17:34:49 +02:00
rebornix
ba0ea792a5
Re #190503 . Dispose components in editor/keyboard/list tests.
2023-09-07 08:28:59 -07:00
Benjamin Pasero and GitHub
c831e73d5f
debt - ensure more dispose from tests ( #192415 )
2023-09-07 16:51:32 +02:00
Alex Ross and GitHub
971db807fb
Fix tab index of tree checkbox ( #192413 )
...
Fixes #189342
2023-09-07 16:13:30 +02:00
Benjamin Pasero and GitHub
242d96340a
debt - dispose things in tests ( #192392 )
...
* debt - ensure more dispose from tests
* more
* input
* .
* more
* input
* inp
* fux
2023-09-07 16:03:20 +02:00
Sandeep Somavarapu and GitHub
ae8de5902b
add logging when updating token ( #192412 )
2023-09-08 00:02:20 +10:00
Daniel Imms
3551954b33
Fix leak in Buffer Content Tracker test
2023-09-07 06:44:03 -07:00
Henning Dieterichs and Henning Dieterichs
afdf655f97
Refactors diff algorithm
2023-09-07 15:34:28 +02:00
Daniel Imms
0989cb2a6c
Fix leak in test
2023-09-07 06:07:20 -07:00
Alex Ross and GitHub
15094ed7fd
Cannot read properties of null (reading 'uri') ( #192404 )
...
Fixes #192331
2023-09-07 14:45:58 +02:00
Alex Ross and GitHub
df9171e630
vscode.TreeView.dispose doesn't clean up in the renderer (#192403 )
...
Fixes #192126
2023-09-07 14:36:47 +02:00
Daniel Imms and GitHub
2c9a74ab6e
Merge branch 'main' into tyriar/190503
2023-09-07 05:35:50 -07:00
Johannes Rieken and GitHub
d1be694dbc
Merge pull request #192400 from microsoft/joh/mass-crawdad
...
update notebook milesones
2023-09-07 14:34:19 +02:00
Johannes
4a6e5c124d
update notebook milesones
2023-09-07 14:16:36 +02:00
Daniel Imms
ab7b0c6db6
Remove unwanted code
2023-09-07 05:16:29 -07:00
Johannes Rieken and GitHub
d18fbe76b9
Merge pull request #192396 from microsoft/joh/selective-salmon
...
a bit more `ensureNoDisposablesAreLeakedInTestSuite` work
2023-09-07 14:15:31 +02:00
Johannes
ed0d3d50f1
a bit more ensureNoDisposablesAreLeakedInTestSuite work
2023-09-07 12:58:16 +02:00
Benjamin Simmonds and GitHub
afc0cc686f
Merge pull request #192390 from microsoft/benibenj/fixTabHeightScrollbar
...
fix floating scrollbar, remove hardcoded value
2023-09-07 12:37:00 +02:00
BeniBenj
c8024c8417
fix floating scrollbar, remove hardcoded value
2023-09-07 11:59:35 +02:00
Benjamin Pasero and GitHub
bb389f28ea
Merge pull request #192378 from microsoft/ben/bare-newt
...
Error: Throttler is disposed in serve-web (fix #191624 )
2023-09-07 09:58:42 +02:00
Hans and GitHub
b651f3399a
Adjust openview ( #191907 )
...
* add firstFileUnresolved for openView
* 💄
2023-09-07 09:48:31 +02:00
Benjamin Pasero
db2ae1d771
Error: Throttler is disposed in serve-web ( fix #191624 )
2023-09-07 09:43:04 +02:00
8adddf5d48
debt - dispose things in my unit tests ( #192112 )
...
* debt - dispose in `WorkingCopyHistoryTracker`
* adopt more
* more
* more
* more
* fix
* fix
* input
* input
* input
* input
* input
* input
* input
* input
* wtf
* .
* .
* inp
* .
* fix compile error
* fux
* give up
* fixup disposable
* testing: fix cannot read properties of undefined (reading 'layout') (#192340 )
Fixes #189326
* input
---------
Co-authored-by: Connor Peet <connor@peet.io >
2023-09-07 09:30:19 +02:00
Johannes Rieken and GitHub
744cb4af36
Merge pull request #192279 from microsoft/joh/dizzy-jay
...
a bit more `ensureNoDisposablesAreLeakedInTestSuite` work
2023-09-07 09:29:48 +02:00
Don Jayamanne and GitHub
9c17df54bd
Ensure orig_nbformat is not written to ipynb file ( #192359 )
2023-09-06 19:20:07 -07:00
aamunger
dad3abe3e7
removed failing check
2023-09-06 15:58:42 -07:00
Daniel Imms and GitHub
592f020ee0
Merge branch 'main' into tyriar/190503
2023-09-06 15:44:38 -07:00
Daniel Imms
95399e55ed
Finish terminal unit test leak
2023-09-06 15:41:51 -07:00
Joyce Er and GitHub
e71d562fd8
Show inline chat hint in empty text editors ( #192352 )
2023-09-06 15:40:44 -07:00
aamunger
258c8ca6da
fixed missed leaks
2023-09-06 15:40:18 -07:00
aamunger
f9169e658f
fix leaks, remove check from leaky insta service suite
2023-09-06 15:17:40 -07:00
Aaron Munger and GitHub
e82305d140
Merge branch 'main' into aamunger/notebookTestLeaks
2023-09-06 14:37:33 -07:00
aamunger
88925c0478
more notebook suites
2023-09-06 14:31:52 -07:00
173bc6d97c
Option for auto closing comments ( #192335 )
...
Implement support for `autoClosingComments`
---------
Co-authored-by: Sergey Sharybin <sergey.vfx@gmail.com >
2023-09-06 21:31:25 +00:00
Connor Peet and GitHub
4548d12f49
api: fix docs for extensionmode ( #192350 )
2023-09-06 23:20:56 +02:00
Connor Peet and GitHub
a9b5269b84
testing: fix icon order mismatch in test explorer and output ( #192343 )
...
Fixes #191182
2023-09-06 23:20:12 +02:00
aamunger
3500878275
another test suite
2023-09-06 14:17:00 -07:00
Rob Lourens and GitHub
df703092cd
Fix #192311 ( #192344 )
2023-09-06 22:30:58 +02:00
aamunger
d3a7a8dfb6
dispose disposables
2023-09-06 13:30:25 -07:00
Gabriela Araujo Britto and GitHub
efc1b30976
Add custom Node option to run TS Server ( #191019 )
...
* Add config for running tsserver on custom node
* log when custom node install is used
* create node version manager
* get node path from node version manager everywhere
* modify prompt
* fix useIpc
* use spawn for custom node and set windowsHide
* detect node
* link memory setting to node setting
2023-09-06 20:27:16 +00:00
Megan Rogge and GitHub
4f6f33e491
Merge pull request #192337 from microsoft/check
...
fix context key issues w chat accessibility help
2023-09-06 16:25:02 -04:00
Daniel Imms
a06b555357
Terminal test leak progress
2023-09-06 12:58:09 -07:00
Nathan Shively-Sanders
a0a2cb4de0
Pretty good ranges based on RefactorInfo
...
Results are not pretty good yet. They are still below average.
2023-09-06 12:54:07 -07:00
meganrogge
80becd6bc3
rm something
2023-09-06 15:47:16 -04:00
Daniel Imms
Peng LyuandGitHub
Aaron MungerandGitHub
Alex RossandGitHub
Benjamin PaseroandGitHub
Sandeep SomavarapuandGitHub
Henning DieterichsandHenning Dieterichs
Johannes RiekenandGitHub
Benjamin SimmondsandGitHub
BeniBenj
Benjamin PaseroandGitHub
HansandGitHub
Don JayamanneandGitHub
Joyce ErandGitHub
Rob LourensandGitHub
Gabriela Araujo BrittoandGitHub
Megan RoggeandGitHub
Nathan Shively-Sanders
meganrogge