Commit Graph
124157 Commits
Author SHA1 Message Date
Connor PeetandGitHub fbdc92cac0 cli: fix delegated http requests not working (#192620)
From a refactor last literation. I don't think this is candidate worthy
as it's an uncommon path with remote-tunnels, and we can just toggle
this off for remote-ssh for this iteration.
2023-09-08 13:26:36 -07:00
Ladislau SzomoruandGitHub 5ffa9573af Git - remove extra character from the log message (#192622) 2023-09-08 16:25:12 -04:00
Megan RoggeandGitHub c1bbcd1fab Merge branch 'main' into fix-192517 2023-09-08 15:33:34 -04:00
meganrogge 5753fde104 set as const 2023-09-08 14:24:18 -05:00
meganrogge c7190f1533 add comment 2023-09-08 14:22:23 -05:00
Megan RoggeandGitHub 0330eccd05 Merge branch 'main' into merogge/accessible-buffer 2023-09-08 15:17:12 -04:00
João MorenoandGitHub 338e449e42 More test disposables cleanup (new attempt) (#192618)
* ensureNoDisposablesAreLeakedInTestSuite: async

* ensureNoDisposablesAreLeakedInTestSuite: actionbar

* ensureNoDisposablesAreLeakedInTestSuite: buffer

* ensureNoDisposablesAreLeakedInTestSuite: cancellation

* one more async fix
2023-09-08 20:45:35 +02:00
Joyce ErandGitHub 9476bf37c1 fix: don't show inline chat hint in search editor (#192614) 2023-09-08 20:00:39 +02:00
cd4bd7e64b forwarding: add a warning for public ports (#192599)
* forwarding: add a warning for public ports

A number of users have raised some security concerns about port
forwarding. Forwarded ports are private (requiring auth with the same
GH account that did the forwarding) by default. When making a port
public, show the following dialog:

![](https://memes.peet.io/img/23-09-3f3351c7-cdcd-46e5-9d0f-123e4dda6b3c.png)

* Update extensions/tunnel-forwarding/src/extension.ts

Co-authored-by: Joyce Er <joyce.er@microsoft.com>

---------

Co-authored-by: Joyce Er <joyce.er@microsoft.com>
2023-09-08 19:19:50 +02:00
Sandeep SomavarapuandGitHub 8627ee4504 preps for ensureNoDisposablesAreLeakedInTestSuite (#192603)
#190503 preps for ensureNoDisposablesAreLeakedInTestSuite
2023-09-08 19:16:20 +02:00
Aaron Munger ddc81ac330 prioritize html links since they can wrap other link types 2023-09-08 10:11:44 -07:00
b257cce9e7 Fix leaks from extHostTreeView and test (#192578)
* Fix leaks from extHostTreeView and test
Part of #190503

* Fix build break

---------

Co-authored-by: Joyce Er <joyce.er@microsoft.com>
2023-09-08 18:50:34 +02:00
Peng LyuandGitHub 53ddd1a6f2 Merge branch 'main' into rebornix/holy-canidae 2023-09-08 09:41:10 -07:00
Martin AeschlimannandGitHub d97b7bbe5c theme initialization: Do not wait for settings sync (#192597) 2023-09-08 09:37:19 -07:00
Joyce ErandGitHub 079d0abf1c fix: don't show inline chat hint for log language (#192586)
* fix: don't show inline chat hint for log language

* fix: don't show hint in readonly editors
2023-09-08 09:34:58 -07:00
Sandeep SomavarapuandGitHub b45439143e adopt to ensureNoDisposablesAreLeakedInTestSuite (#192596)
#190503 adopt to ensureNoDisposablesAreLeakedInTestSuite
2023-09-08 18:34:41 +02:00
Nathan Shively-Sanders 3328d54c89 Clean up for review
Remove unused, abandoned ideas.
2023-09-08 09:28:53 -07:00
Andrea MahandGitHub 088d73042e Unexpected logs in SearchModel unit tests (#192501)
Fixes #192428
2023-09-08 09:04:49 -07:00
Joyce ErandGitHub a5b244bbc8 revert: "More test disposables cleanup" (#192593)
Revert "More test disposables cleanup (#192575)"

This reverts commit 35c2ce3aac.
2023-09-08 18:04:34 +02:00
Tyler James LeonhardtandGitHub a4a2d8f0f4 Rename --disable-keytar to --use-inmemory-secretstorage (#192312)
This renames the flag as the title suggests but keeps `--disable-keytar` in the `deprecates` section so it still works.

Fixes https://github.com/microsoft/vscode/issues/191498
2023-09-08 17:58:32 +02:00
Johannes RiekenandGitHub 93b79352e4 Merge pull request #192589 from microsoft/joh/personal-snipe
more `ensureNoDisposablesAreLeakedInTestSuite` work
2023-09-08 17:56:50 +02:00
Johannes e99a36178d use separator instead of spacing things out 2023-09-08 17:38:19 +02:00
Johannes d96e2858e9 move CC colors for better reuse 2023-09-08 17:23:30 +02:00
Johannes 2aa802458e more ensureNoDisposablesAreLeakedInTestSuite work 2023-09-08 17:14:11 +02:00
Jean PierreandGitHub fd49fb92f7 Merge branch 'main' into fix-192517 2023-09-08 09:40:57 -05:00
meganrogge e0cb8fc8b4 add more to store 2023-09-08 10:21:38 -04:00
Megan RoggeandGitHub 600397faa6 Merge branch 'main' into merogge/accessible-buffer 2023-09-08 10:19:11 -04:00
meganrogge 8428906334 register marker 2023-09-08 09:51:50 -04:00
João MorenoandGitHub 35c2ce3aac More test disposables cleanup (#192575)
* ensureNoDisposablesAreLeakedInTestSuite: async

* ensureNoDisposablesAreLeakedInTestSuite: actionbar

* ensureNoDisposablesAreLeakedInTestSuite: buffer

* ensureNoDisposablesAreLeakedInTestSuite: cancellation
2023-09-08 15:43:48 +02:00
gjsjohnmurray 38f7bbd4e0 Tab separator setting referred to the same setting twice (fix #192497) 2023-09-08 14:34:38 +01:00
Sandeep SomavarapuandGitHub 89719831aa adopt to ensureNoDisposablesAreLeakedInTestSuite (#192574)
#190503 adopt to ensureNoDisposablesAreLeakedInTestSuite
2023-09-08 15:27:34 +02:00
Martin AeschlimannandGitHub 79df0660a9 remove unused FormattingOptions.ranges (#192573) 2023-09-08 15:10:28 +02:00
Alex RossandGitHub b93082f0c0 Use markAsSingleton in touch.ts (#192572) 2023-09-08 15:05:54 +02:00
Henning DieterichsandHenning Dieterichs 83547819dc Fixes #192446 2023-09-08 14:58:50 +02:00
Alex RossandGitHub 5ae46ad300 Cache last quick diff (#188506)
Fixes #179441
2023-09-08 14:48:44 +02:00
Johannes 36b7d3c212 update CC background color when debugging 2023-09-08 14:46:57 +02:00
Johannes dfc7eb14b9 hide floating toolbar when using CC 2023-09-08 14:28:10 +02:00
Joyce ErandGitHub 0795888f65 fix: avoid fs dependency in web (#192565)
* feat: quick fix for redundant activation events

* fix: avoid `fs` dependency in web
2023-09-08 14:23:04 +02:00
Johannes cef7b78745 Add command center center menu, treat quickOpenWithModes special when alone, make it possible to have debug toolbar here 2023-09-08 14:21:04 +02:00
Sandeep SomavarapuandGitHub f4700718ba dispose throttler (#192563) 2023-09-08 14:20:37 +02:00
João MorenoandGitHub e2aa12d977 ensureNoDisposablesAreLeakedInTestSuite: paging (#192477)
* ensureNoDisposablesAreLeakedInTestSuite: paging

related to #190503

* fix hygiene
2023-09-08 14:16:40 +02:00
Henning DieterichsandHenning Dieterichs 758b4561b2 Improves error reporting. FYI @jrieken 2023-09-08 14:16:07 +02:00
Alex RossandGitHub 91fa749999 Fix local port error message (#192552)
Fixes #191929
2023-09-08 14:15:36 +02:00
Benjamin PaseroandGitHub 9238c19bf1 debt - fix more unit test disposables (#192538)
* debt - fix more unit test disposables

* input

* input

* input

* input

* input

* input

* input
2023-09-08 14:15:04 +02:00
meganrogge 89e3f22fe9 register buffer trackcer 2023-09-08 07:13:11 -04:00
Johannes 90e1615b27 Merge branch 'main' into joh/cc-debug 2023-09-08 12:31:50 +02:00
meganrogge 4a1172ec1d address feedback 2023-09-08 06:11:38 -04:00
a722d44539 Update src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2023-09-08 05:58:47 -04:00
20fbe3ec18 Update src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
2023-09-08 05:57:44 -04:00
Johannes RiekenandGitHub 1a3cfcf0ae Merge pull request #192528 from microsoft/joh/breakable-mule
Joh/breakable-mule
2023-09-08 11:57:21 +02:00