Matt Bierner
ecb45f5207
Move shared webview focus implementation into base class
2021-04-08 21:27:45 -07:00
Rob Lourens
ed655c2d2e
Fix split json editor underline
...
Fix #120876
2021-04-08 19:56:52 -07:00
Matt Bierner
4b5ef68872
Use cloneNode to inject default styles
2021-04-08 19:35:04 -07:00
Matt Bierner
02e5ed5280
Avoid calling applyStyle again if the style has not changed
2021-04-08 19:24:35 -07:00
Matt Bierner
6b5122bb06
Add typings
2021-04-08 19:20:05 -07:00
Matt Bierner
3fc15fb34a
Remove unused function
2021-04-08 18:53:42 -07:00
Matt Bierner
923fbc8c2a
Cancel resource load when the webview is disposed of
2021-04-08 18:49:49 -07:00
Matt Bierner
d5b46d6e56
Use transfer for sending resource buffer from webview to service worker
2021-04-08 18:48:26 -07:00
Matt Bierner
595c14a8d3
Inline rewriteUri into loadLocalResource
...
We now have a single caller to `loadLocalResource` so it makes sense to inline the uri rewriting logic
2021-04-08 17:46:50 -07:00
Matt Bierner
2d7ddf5a38
Remove extra indirection around loadLocalResource
...
`loadLocalResource` is now only used from a single calling path, so it does not need to allow passing in a custom file service implementation
2021-04-08 17:33:14 -07:00
Matt Bierner
8a91839989
Move webview resource loading from platform to workbench
...
These functions are now only needed on the renderer side, not on the main process
2021-04-08 17:24:00 -07:00
Matt Bierner
de9887d9e0
Remove vscode-webview-resource path normalization logic
...
We should now handle normalization before `loadLocalResource` is invoked and should never see a `vscode-webview-resource` uri being passed in
2021-04-08 17:10:43 -07:00
Matt Bierner
9c9e188aa0
Don't use 'self' for image editor csp
...
On desktop, we now serve webview resources from a different origin than the webview itself. This means we no longer can use `'self'` in our CSP as shorthand and instead should always use the provided `cspSource`
2021-04-08 17:08:08 -07:00
Matt Bierner
044a99585c
Make sure we use the webviewResourceRoot on for computing cspSource
...
Fixes #120879
2021-04-08 16:59:59 -07:00
Matt Bierner
84391165c3
Pass in correct project root for notebook cells
2021-04-08 16:49:04 -07:00
rebornix
f5ea03079a
turn off logging for notebook.
2021-04-08 16:35:39 -07:00
Eric Amodio
3622dafdc0
Adds new proposed api for scm input validation
2021-04-08 19:24:53 -04:00
Matt Bierner
852375649c
Remove extra whitespace
...
Mistakenly added as part of #120654
Doesn't seem to cause issues in the current builds but breaks our electron 12 build
2021-04-08 13:59:56 -07:00
Connor Peet
614dd5174f
testing: fix explorer view
2021-04-08 13:58:15 -07:00
rebornix
618705cc57
Merge branch 'notebook/dev' into main
2021-04-08 13:51:40 -07:00
rebornix
93934cacd0
precalcuate cell editor height: guess if the editor will render scrollbar.
2021-04-08 13:51:10 -07:00
Matt Bierner
bc506127ab
Temporarily restore vscode-webview-resource constant
...
Mistakenly checked in removal while Looking into removing this constant entirely
2021-04-08 13:46:32 -07:00
Matt Bierner
1c27a28517
Fix rewriting old-school vscode-resource uris
...
Fixes #120863
This centralizes the rewriting into `baseWebviewElement`, which lets us share more code between desktop and web (and hoepfully makes the behavior of the two consistent)
2021-04-08 13:34:45 -07:00
Sandeep Somavarapu
7c26f27d90
#120860 Implement trusted workspace settings
2021-04-08 22:26:54 +02:00
Raymond Zhao
f689971195
Mark Emmet trusted
2021-04-08 13:07:25 -07:00
Matt Bierner
bd815e462d
Don't warmup markdown preview when input is collapsed
...
Fixes #120845
2021-04-08 12:53:05 -07:00
Daniel Imms
437f2383b9
Add icon to terminal tabs
2021-04-08 12:44:17 -07:00
meganrogge
618f06314e
change terminal tab height for uniformity
2021-04-08 12:24:19 -07:00
João Moreno
2f26adffbe
fixes #120786
2021-04-08 20:50:58 +02:00
John Murray
8ec2bceec9
fix #120776 remove stray words from contextualTitle description. ( #120777 )
2021-04-08 11:25:00 -07:00
Matt Bierner
13f4f05258
Fix spacing
2021-04-08 11:18:24 -07:00
Matt Bierner
ae1452eea6
Add script to run build with noImplicitOverride
2021-04-08 10:52:34 -07:00
Matt Bierner
e29e1f908a
Adding a few more overrides
...
For #120675
- Manually fix a few more cases automation missed
- Fix cases where an injected service is incorrectly being re-declared in a subclass
2021-04-08 10:52:13 -07:00
Matt Bierner
86bf027920
Add a few more overrides in codebase
...
For #120675
- Manually fix a few cases the automation missed
- Fix cases where an injected service is incorrectly being re-declared in a subclass
2021-04-08 10:34:50 -07:00
deepak1556
5904b7b686
chore: info.plist => Info.plist
2021-04-08 10:33:02 -07:00
Matt Bierner
e1f0f8f513
Add override keyword in codebase ( #120755 )
...
For #120675
This uses a script to add the override keyword to places that need it in the codebase
Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Matt Bierner
604b950f0d
Reapply badclient commit
...
Fixes #120781
Add second file this time
2021-04-08 09:09:25 -07:00
meganrogge
3702538139
fix #120824
2021-04-08 09:02:39 -07:00
Ahmad Awais ⚡️
e956e0a0ee
🐛 FIX: Typo ( #120816 )
2021-04-08 08:56:19 -07:00
Alexandru Dima
464e51e24f
Merge pull request #120054 from stoyannk/fix_extensions_profile
...
Fixed wrong variable name shadowing that caused Profiles for extensio…
2021-04-08 17:07:49 +02:00
Benjamin Pasero
f4449876e4
file working copy - getAlternativeVersionId() => versionId
2021-04-08 16:30:01 +02:00
Daniel Imms
6062a5458a
Merge pull request #120591 from microsoft/merogge/tabs2
...
terminal tabs UI
2021-04-08 05:48:33 -07:00
Daniel Imms
7a1e1fd2af
Fix ctx menu, clean up DI
2021-04-08 05:47:49 -07:00
isidor
a4fed64a16
fixes #120188
2021-04-08 14:33:21 +02:00
Alex Ross
ffde5985b2
Update color for port wtih running process
...
Part of microsoft/vscode-remote-release#4826
2021-04-08 14:29:39 +02:00
Daniel Imms
37a44ac7db
Types, polish
2021-04-08 05:24:07 -07:00
Daniel Imms
29d772fc9e
Merge remote-tracking branch 'origin/main' into merogge/tabs2
2021-04-08 05:10:55 -07:00
Benjamin Pasero
c14109e5ec
perf - wait for dom ready when waiting for services
2021-04-08 14:01:53 +02:00
Alex Ross
61dacc2f81
Add hover underline to port address
...
Part of microsoft/vscode-remote-release#4826
2021-04-08 13:51:48 +02:00
Benjamin Pasero
e9b4e01a4b
process explorer - fix window title
2021-04-08 13:39:30 +02:00