Commit Graph

103201 Commits

Author SHA1 Message Date
Johannes f73bb21f27 wip 2022-12-02 13:03:16 +01:00
Sandeep Somavarapu 9433821f09 remove critical log level (#167820) 2022-12-01 10:55:56 +01:00
Johannes Rieken 33b2e92392 nullify actionbar and view item context on dispose, remove notebook overview ruler on dispose (#167817)
fixes https://github.com/microsoft/vscode/issues/167813
2022-12-01 10:35:05 +01:00
Ladislau Szomoru a1f2132aa8 Git - Fix command name (#167812)
Fix command name
2022-12-01 09:57:15 +01:00
Joyce Er 329de94191 Do not require manifest.activationEvents to generate implicit events (#167786) 2022-12-01 09:52:09 +01:00
Alex Ross 7cfb0123fc comments.visible should explain how it works with the Comments view (#167809)
Fixes #167569
2022-12-01 09:33:14 +01:00
Sandeep Somavarapu cbb2b2476c Complete fix #166196 (#167805) 2022-12-01 09:11:26 +01:00
Joyce Er 7f3301d361 Report cancellation errors in telemetry (#167799) 2022-12-01 07:19:51 +01:00
Joyce Er f3996b416f Add 1-step Continue in Local Folder option (#167795) 2022-11-30 22:00:43 -08:00
Connor Peet c87fa19f79 cli: avoid interactions when running integrated (#167780)
Fixes https://github.com/microsoft/vscode/issues/167760

The VS Code CLI gets run from a bash/shell script. This prevents interactions--in the former case, it doesn't look like a tty, and in the latter case batch scripts don't seem to support having interactive subprocesses.

This PR avoids interactions if stdin is not a tty, prompting the user to use the flag instead. Use of the flag is also persisted like an interactive agreement prompt.
2022-11-30 23:15:08 +00:00
Raymond Zhao 968026a46d Use includes instead of indexOf (#167778) 2022-11-30 22:44:10 +00:00
Harald Kirschner 2a16bdb467 Instrument webview usage (#167762)
Nov 30, 2022, 11:44 AM
2022-11-30 13:33:25 -08:00
Peng Lyu 56d73a45e3 Do not auto run source action when there is pending kernel detection. (#167763)
* Do not auto run source action when there is pending kernel detection.

* resolve comments
2022-11-30 20:55:57 +00:00
Raymond Zhao bffd0181d3 Restrict hover focus trap behaviour to Settings indicators (#167756)
Fixes #167520
2022-11-30 12:54:51 -08:00
Peng Lyu c8dd73b410 Fix #167683. Show selected kernel name during kernel detection. (#167761) 2022-11-30 19:53:07 +00:00
Matt Bierner cec4114c0c Ignore position parameter for now when laying out notebook widget (#167759)
Ignore position parameter for now

Fixes #167087

As discussed in https://github.com/microsoft/vscode/issues/167087#issuecomment-1332589925, the position is sometimes incorrect. Since we are close to release, the safest fix is to ignore this position. We can look into fixing the position for december
2022-11-30 19:12:56 +00:00
Raymond Zhao e84133953f Add application.experimental.* to Settings UI (#167746)
Fixes #167498
2022-11-30 10:28:43 -08:00
Raymond Zhao dfca1c7088 Add tabIndex only when there's data (#167753)
Fixes #167629
2022-11-30 18:11:15 +00:00
易良 0fd497a6df fix: typos (#158431) 2022-11-30 10:09:51 -08:00
Raymond Zhao 959c8b024c Improve hover accessibility (#167749)
- Search entire hover container when adding focus trap
- Change keyup to keydown event to activate hover action links properly
2022-11-30 17:50:54 +00:00
Johannes Rieken c5be23af01 fix https://github.com/microsoft/vscode/issues/166082 (#167739)
* fix https://github.com/microsoft/vscode/issues/166082

* also fix https://github.com/microsoft/vscode/issues/166080

* ops
2022-11-30 16:24:06 +00:00
Ladislau Szomoru d0b47f6c30 Git - Unsafe repositories flow polish (#167728) 2022-11-30 16:39:59 +01:00
Alex Ross c9d310b5f0 comment-sample + doesn't do anything on initial file (#167729)
* comment-sample `+` doesn't do anything on initial file
Fixes #167600

* Fix compile error
2022-11-30 15:01:21 +00:00
Sandeep Somavarapu a2857837bd Fix #167647 (#167727) 2022-11-30 14:52:46 +00:00
Johannes Rieken 6d24732a62 fix https://github.com/microsoft/vscode/issues/167548 (#167726) 2022-11-30 06:49:41 -08:00
Sandeep Somavarapu 78586cddd7 Fix #166196 (#167723) 2022-11-30 14:28:30 +00:00
Alex Ross 5c79f5c532 Toggle Comments Inconsistent Behavior With comments.visible Setting (#167722)
Fixes #167663
2022-11-30 06:14:15 -08:00
Alex Ross ba9399b83d Roll back variables in welcome views (#167720)
* Revert "Don't require workspace folder for welcome view variables (#167235)"

This reverts commit b5ce100fe1.

* Revert "Add variables to welcome views (#167163)"

This reverts commit 3dc0754369.
2022-11-30 13:50:10 +00:00
Henning Dieterichs b171fc21b2 Fixes #167585 (#167716) 2022-11-30 13:28:08 +01:00
Ladislau Szomoru 5c41d2b0fc Git - fix unsafe repository path to use \ as path separator (#167711)
Fix #167515
2022-11-30 11:46:12 +01:00
Sandeep Somavarapu 410665bd1c fix #167539 (#167709) 2022-11-30 10:22:48 +00:00
Ladislau Szomoru 4934caaf88 Git - improve unsafe repository message based on feedback (#167701)
Fix #167595
2022-11-30 10:15:44 +01:00
Benjamin Pasero a1fc4e3739 Untitled editors are not force opened when auto save is on (fix #167691) (#167694) 2022-11-30 08:15:02 +00:00
Sandeep Somavarapu a823f4af40 Fix #167630 (#167693) 2022-11-30 09:02:01 +01:00
Robo 9908b3d5ae chore: update electron@19.1.8 (#167677) 2022-11-29 18:28:23 -08:00
Joyce Er 1a1ff9cd96 Update Edit Sessions setting names (#167650)
* Disable edit sessions partial matches

* Update edit sessions setting names

* Better setting and loc key names

* Fix duplicate loc key
2022-11-30 00:59:30 +00:00
Connor Peet a315da7910 cli: fix service failing to install on older systemd (#167672)
Fixes https://github.com/microsoft/vscode/issues/167671

In newer systemd, enablement is apparently implicit with 'link', but it must be called for older setups.
2022-11-30 00:34:05 +00:00
Logan Ramos 8d585dbf89 Fix incorrect machine id (#167653) 2022-11-29 15:42:58 -08:00
Sandeep Somavarapu 89b0690e70 Fix #167566 (#167640)
* Fix #167566

* fix tests
2022-11-29 23:27:37 +00:00
Sandeep Somavarapu a45d1b4164 Fix #167513 (#167648) 2022-11-29 23:11:29 +00:00
Matt Bierner bf8e26d144 Fix extension private prop mangling when compiling all extensions (#167626)
Fix extension private prop mangling when compiling all projects

#167269

Re-applies previous commit with a fix for html's custom webpack logic
2022-11-29 14:20:23 -08:00
Joyce Er 4357b1c4d3 Surface 1-step vscode.dev Continue On option (#167636) 2022-11-29 22:16:39 +00:00
Connor Peet 2348f22d01 server: allow underscores in connection token (#167635)
Underscores are URL and path safe. Allowing them lets connection tokens
be generated by standard base64 URL encoding without additional escaping
or replacements.

Fixes #167631
2022-11-29 22:09:06 +00:00
Matt Bierner ce934ff443 Also run cleanNodeModules on extensions/node_modules (#167476)
Also run cleanNodeModules on extensions/node_modules

Fixes #166652
2022-11-29 12:15:09 -08:00
Megan Rogge f3d79ea766 reference var in zsh not string (#167618)
fix #167575
2022-11-29 20:07:07 +00:00
Raymond Zhao 096f4de76e Use includes instead of indexOf (#167608)
Tests microsoft/vscode-pull-request-github#4257
2022-11-29 11:24:18 -08:00
Matt Bierner 7b20bd008e Show default string value as code in setting description markdown (#167603)
Show default string value as code in setting description

From testing #167471
2022-11-29 19:00:37 +00:00
Connor Peet 510f84046f debug: bump js-debug (#167574) 2022-11-29 17:41:37 +00:00
Matt Bierner 8b9891739b Revert "Fix extension private prop mangling when compiling all projec… (#167490)
Revert "Fix extension private prop mangling when compiling all projects (#167464)"

This reverts commit 725330a7cd.
2022-11-29 07:42:07 +01:00
Matt Bierner 3e7637064d Use more generic button title for jsconfig create/open (#167482)
For #166808
2022-11-29 00:39:56 +00:00