Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-02 14:25:42 +01:00
Code Issues Packages Projects Releases Wiki Activity
61,894 Commits 4,968 Branches 386 Tags
f8fec0012a5eeffbf4ddc495ce4d3f11258403c8
Commit Graph
61894 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Johannes Rieken f8fec0012a fix https://github.com/microsoft/vscode/issues/91937 2020-03-03 09:11:14 +01:00
Johannes Rieken b52116021d sort by category only once, #91900 2020-03-03 08:45:46 +01:00
Benjamin Pasero 9ce4ebbf0f debt - fold electron environment and native environment into one 2020-03-03 08:34:59 +01:00
Matt Bierner 44c76bd3b9 Rework management of custom editor custom models 
Fixes #91670

- Move model type logic out of `CustomEditorInput` and into two different implementations of `ICustomEditorModel`
- Add `CustomTextEditorModel` that owns a proper model reference to a text document. This should ensure the text document is disposed of if there are no more references to it
- Move most of the previous `CustomEditorModel` into `mainThreadWebviews` directly. This removes some of the indirection that was previously required (such as using `waitUntil`)
 2020-03-02 20:27:06 -08:00
Matt Bierner ed8c0e4e1d Add explicit wait on protocol registration 
Possible fix for #89038/#91506. In both cases, it looks like we try to use the protocol before it is properly registered. If this fix doesn't work, there's probably something weird going on on the electron side of things
 2020-03-02 17:18:03 -08:00
Jackson Kearl 2158b1aa65 [Search Editor] Align results from the same file 2020-03-02 16:28:45 -08:00
Matt Bierner 24a5df3cc3 Type registerAndInstantiateContribution 
Type out the ctor argument type. This also removes the need to explicitly type the return type
 2020-03-02 16:20:36 -08:00
Matt Bierner 1b78eec1bd Remove extra overload for createInstance 2020-03-02 16:20:36 -08:00
Matt Bierner fa43b26237 More scoped try/catch 2020-03-02 16:20:36 -08:00
Matt Bierner 96d7905ca2 Remove unreachable code path 2020-03-02 16:20:36 -08:00
Matt Bierner d34c2e0ee3 Use standard for/of loop 2020-03-02 16:20:36 -08:00
Matt Bierner 0fa3af8b60 Use es6 version of methods 2020-03-02 16:20:36 -08:00
Rob Lourens b23926ba6f Merge pull request #91458 from urbas/remove-fields-from-irawfilematch 
fileSearch: removed unused `size` and redundant `basename` fields from IRawFileMatch
 2020-03-02 14:31:10 -08:00
Alex Dima bcc9532c1e Fixes #70490: resource is mandatory in ITextResourcePropertiesService 2020-03-02 22:23:25 +01:00
Martin Aeschlimann 6d4f8310a9 ITheme -> IColorTheme 2020-03-02 22:19:17 +01:00
Martin Aeschlimann e7f525fbad IIconTheme -> IFileIconTheme 2020-03-02 22:19:17 +01:00
Alex Dima 79280beee2 Fixes #81424: Throw when a request is made with invalid arguments 2020-03-02 22:09:19 +01:00
Rachel Macfarlane b2b488fa43 Only write config file during postinstall if process env variables are present (#91793) 2020-03-02 12:45:33 -08:00
rebornix a8c3c47555 only when row height is not set, we can check item dom node height 2020-03-02 11:58:43 -08:00
Jackson Kearl e612ed9492 Add aria alerts to F4 in serach viewlet and editor 
Fixes #91705.
 2020-03-02 11:56:55 -08:00
Matt Bierner a8a3f4a91e Try using a private field in Disposable 
Test of #91129
 2020-03-02 11:43:08 -08:00
SteVen Batten bc43ec6fd5 fixes #81630 2020-03-02 11:33:20 -08:00
SteVen Batten 5de133e5e9 refs #81360 2020-03-02 11:29:39 -08:00
Matt Bierner 6e30cf38a7 Mark markdown comment folding regions as comments 
Fixes #91271
 2020-03-02 11:26:29 -08:00
Rob Lourens 13b4c8500d Merge branch 'master' into remove-fields-from-irawfilematch 2020-03-02 11:15:05 -08:00
Rob Lourens 7cc0c75e54 Merge pull request #89765 from urbas/master 
file search: include workspace folder in filter
 2020-03-02 11:11:34 -08:00
Rob Lourens 2191265521 Revert "make sure unnotarized build is published even if notarization fails" 
This reverts commit 7298bf4bd1.
 2020-03-02 19:52:20 +01:00
Rob Lourens 32beb6c67c Merge pull request #91429 from jaqra/fix-search-view-padding 
Fix search view 'Toggle Search Detail' padding
 2020-03-02 10:40:18 -08:00
Rob Lourens 3e0d421e2e Merge branch 'master' into master 2020-03-02 10:36:38 -08:00
Daniel Imms 018b3fe7df Allow menu bar mnemonics in the terminal (setting) 
Fixes #91908
 2020-03-02 10:19:41 -08:00
Sandeep Somavarapu 78b5a91c77 update distro 2020-03-02 18:23:01 +01:00
Alex Dima 0089596fc4 Rename isEdgeOrIE to isEdge 2020-03-02 17:33:59 +01:00
Alex Dima 7e4c8c983d Remove browser.isIE 2020-03-02 17:32:17 +01:00
Eric Amodio 8cbde76c84 Fixes missing loading message in certain cases 2020-03-02 11:31:48 -05:00
Benjamin Pasero 3b975102e7 types 💄 2020-03-02 17:25:00 +01:00
Benjamin Pasero 5651fa0a8a debt - some 💄 
* add a few more readonly to properties
* move IVisibleEditor closer to IEditor
* remove options accessor from IEditor
 2020-03-02 16:57:56 +01:00
Johannes Rieken c5dd0e5582 add Iterable-utils (completing Iterator-utils) and adopt in bulk edit preview, https://github.com/microsoft/vscode/issues/90676 2020-03-02 16:55:51 +01:00
Alex Dima f3c0ea571c Remove notice since promise-polyfill was removed 2020-03-02 16:41:47 +01:00
Johannes Rieken c788fccaa2 Merge pull request #91896 from microsoft/joh/no-polyfill-promise 
remove polyfill promise
 2020-03-02 16:34:23 +01:00
Johannes Rieken 2a12c9a458 add es6 deprecation messages to some utils, remove duplicated utils, https://github.com/microsoft/vscode/issues/90676 2020-03-02 16:11:18 +01:00
Sandeep Somavarapu 4f2ea532c7 Fix #91757 2020-03-02 15:50:03 +01:00
Johannes Rieken 02f23e5680 remove polyfill promise 2020-03-02 15:30:43 +01:00
Martin Aeschlimann a55b3e9525 Ok -> OK 2020-03-02 15:27:41 +01:00
Martin Aeschlimann d3da6f4792 Remote: seeing an error message when not having remote extension installed. Fixes #91526 2020-03-02 15:24:21 +01:00
Sandeep Somavarapu c2d241d963 fix monaco build failure 2020-03-02 15:20:18 +01:00
Johannes Rieken c3efba96a7 Merge pull request #90682 from microsoft/joh/es6 
ES6 everywhere
 2020-03-02 15:18:52 +01:00
Sandeep Somavarapu 452e16a1ac Fix #91731 2020-03-02 14:49:25 +01:00
Johannes Rieken 1bccecab0a remove more files from typings for which we have lib.*.d.ts files 2020-03-02 14:36:25 +01:00
Sandeep Somavarapu 16faaa5d81 Fix #69480 2020-03-02 14:29:05 +01:00
Johannes Rieken 1c6efa678a Merge branch 'master' into joh/es6 2020-03-02 14:27:57 +01:00