Commit Graph

115935 Commits

Author SHA1 Message Date
Benjamin Pasero fd80237082 aux window - cleanup layout service (#198292) 2023-11-15 13:10:40 +01:00
Benjamin Pasero ce711aae31 aux window - introduce and adopt ILayoutService.mainContainer (#198288) 2023-11-15 12:31:20 +01:00
Benjamin Pasero b6b7a942bd aux window - improve DND (#198286) 2023-11-15 11:47:08 +01:00
Henning Dieterichs 59b1480f1e Merge pull request #198227 from hsfzxjy/inline-suggest-show-toolbar-never-198070
Add inlineSuggest.showToolbar.never
2023-11-15 10:50:11 +01:00
Benjamin Pasero 3d0503d96a Progress bar is not below editor title anymore (fix #198176) (#198280) 2023-11-15 10:08:09 +01:00
Ole b3a649fe52 Remove cycle browserHostService.ts -> web.api.ts. (#198221)
* Remove cycle  browserHostService.ts -> web.api.ts.

Before this change, `IWorkbenchConstructionOptions` in web.api.ts
depended on `IWorkspaceProvider` in browserHostService.ts, which
depends on some types from web.api.ts.

While this apparently does not pose problems in VS Code's build, other
build system of downstream projects do not allow this, and it is also
overall harder to follow the code if "the API" depends on types defined
in ""the implementation".

* Fix one reference I missed
2023-11-15 07:17:50 +00:00
Arvid Lunnemark 0bc6184910 fix blank settings page (#198261) 2023-11-14 23:16:25 -08:00
Peng Lyu beb804d1d2 Merge pull request #198272 from microsoft/rebornix/ambitious-pigeon
💄 better handling optional
2023-11-14 23:07:23 -08:00
Benjamin Pasero 1368f2a052 dom - use getWindow in more places (#198269) 2023-11-14 22:20:49 -08:00
Benjamin Pasero d2d14e541e aux window - cleanup merge on close (#198268) 2023-11-14 22:18:20 -08:00
rebornix bed797335d 💄 better handling optional 2023-11-14 22:17:15 -08:00
Raymond Zhao e1c8870cd2 chore: bump vscode-tas-client (#198257) 2023-11-15 00:12:17 +01:00
Ladislau Szomoru 6e1f0594ee Engineering - update distro (#198253) 2023-11-14 22:45:33 +01:00
Daniel Imms 13971b36f4 Merge pull request #198250 from microsoft/overseas-horse
Remove out dated setting
2023-11-14 13:12:24 -08:00
Daniel Imms 4884e6a01b Merge pull request #198247 from microsoft/tyriar/198246
Fix serialize addon bricking terminal
2023-11-14 12:58:56 -08:00
Daniel Imms 0d0217205f Remove out dated setting 2023-11-14 12:57:50 -08:00
Daniel Imms f04021abcf Fix serialize addon bricking terminal
Fixes #198246
2023-11-14 12:43:47 -08:00
Rob Lourens 39d7357aba Move usedContext/contentReferences out of Response (#198240) 2023-11-14 20:54:57 +01:00
Benjamin Pasero ba035ccf38 aux window - merge groups back to main on window close (#198239) 2023-11-14 20:52:45 +01:00
Megan Rogge bee13ad3bf Merge pull request #198236 from microsoft/merogge/button
ensure menu has role of `button` rather than `presentation`
2023-11-14 11:45:16 -08:00
Peng Lyu 44488fc1ad allow metadata label to be optional (#198238) 2023-11-14 20:44:15 +01:00
meganrogge 54d55a32f6 fix #198233 2023-11-14 11:23:38 -08:00
Ladislau Szomoru e121560310 SCM - add input box value provider proposal (#198232)
* Initial implementation

* Remove new toolbar widget

* Remove TestCommitMessageProvider2

* Remove more changes
2023-11-14 19:59:05 +01:00
Megan Rogge b0584f4202 Merge pull request #198230 from microsoft/merogge/checked
don't include `aria-checked` property unless an item is checkable
2023-11-14 10:30:14 -08:00
meganrogge 8696e89eb5 fix #198228 2023-11-14 10:09:29 -08:00
Rob Lourens 7dcfb8c5b7 Add no-base-to-string rule to chat (#198226)
* Add no-base-to-string rule to chat

* Fix rule hit in chatmodel
2023-11-14 18:53:46 +01:00
Rob Lourens cc5dca3ab4 Make chat progress types nicer, take 2 (#198225)
Clean up IChatProgress types and handling
2023-11-14 18:48:43 +01:00
hsfzxjy 4dd5e2ae56 Add inlineSuggest.showToolbar.never 2023-11-15 01:45:32 +08:00
Henning Dieterichs a7f57a4eae Fix 2023-11-14 18:18:48 +01:00
Henning Dieterichs 028e94157e Design improvements, sticky scroll 2023-11-14 18:18:48 +01:00
Henning Dieterichs 5896510fd0 Fixes #197936 2023-11-14 18:18:48 +01:00
Henning Dieterichs d2204f853f Clears input properly 2023-11-14 18:18:48 +01:00
Henning Dieterichs 666f8ddefc Fixes #197942 2023-11-14 18:18:48 +01:00
Peng Lyu d68e8f4016 Merge pull request #197794 from microsoft/rebornix/conservation-dormouse
Report issue contrib for inline widget and sidebar.
2023-11-14 08:38:21 -08:00
rebornix 293db236d4 Update sidebar action names to align 2023-11-14 08:20:11 -08:00
rebornix 49eb796101 Resolve conflicts 2023-11-14 08:19:07 -08:00
rebornix 99b78d90be Tweak name 2023-11-14 08:18:27 -08:00
rebornix dec5c41526 Update proposed api check 2023-11-14 08:17:04 -08:00
rebornix 29b0e44ed7 Resolve comments 2023-11-14 08:14:32 -08:00
Aiday Marlen Kyzy 7c6e7d2832 Merge pull request #198213 from microsoft/aiday/buttonStartsInlineChat
Add Start Inline Chat button to editor title menu
2023-11-14 15:40:01 +01:00
Aiday Marlen Kyzy f22f552a8d changing name of the icon 2023-11-14 15:25:23 +01:00
Aiday Marlen Kyzy c3c3e671f0 registering an icon also 2023-11-14 15:23:52 +01:00
Aiday Marlen Kyzy 63779d3974 setting the menu to the editor title 2023-11-14 15:09:54 +01:00
Aiday Marlen Kyzy 22ab376bfc appending the menu item in order to show the sparkle as a button that executes the start inline chat action 2023-11-14 14:52:48 +01:00
Ladislau Szomoru ed30010d3f Git - better error handling for git merge-base (#198208) 2023-11-14 14:51:17 +01:00
Christof Marti 67aa71296f Avoid excessive trace logging (microsoft/vscode#197549) 2023-11-14 14:12:44 +01:00
Alexandru Dima 54821ee1f1 Revert "Make the chat progress types nicer (#198175)" (#198198)
This reverts commit 94959e8550.
2023-11-14 12:51:10 +01:00
Christof Marti f9cadb5e57 Update distro hash 2023-11-14 12:50:24 +01:00
Ladislau Szomoru bf65efeb4c SCM - fix files icon color in statistics badge (#198197) 2023-11-14 03:45:04 -08:00
Del 62686a38cc feat: introducing new hover focus options for editor.action.showHover (#196891)
* fix: revert and optimize showHover action behavior

* feat: update focus option for controlling hover focus behavior

* polishing the code, extracting an enum, doing a check on the focus argument

* refactoring the code

* Refactor default value to use ShowOrFocusHoverArgument enum

* misc: renaming the enums to more accurately reflect their behavior

---------

Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
2023-11-14 09:48:26 +01:00