Commit Graph

44888 Commits

Author SHA1 Message Date
Joao Moreno fd8dd511d3 fixes #66876 2019-01-23 09:15:27 +01:00
Sandeep Somavarapu 11f3201d35 #66907 💄 2019-01-23 08:40:25 +01:00
Matt Bierner 2d79ffe0cd Expand code action range to entire document range when source actions are requested without any active selection
Fixes #53525
2019-01-22 16:37:54 -08:00
Matt Bierner cc0be8db2a Extract code action filtering logic to own files 2019-01-22 16:18:01 -08:00
Matt Bierner 3ff312e36c Use CodeActionKind.intersects internally 2019-01-22 15:38:05 -08:00
Matt Bierner 401dd1caf4 Convert to test to use async 2019-01-22 15:32:37 -08:00
Matt Bierner 8c75f078ff Always require getCodeActions.trigger 2019-01-22 15:29:08 -08:00
Matt Bierner 7b095ea781 Pick up TS 3.3 rc
#66175
2019-01-22 15:23:29 -08:00
Matt Bierner cf27b0ed05 Make sure we cancel code action requests for mainThreadSave
If a code action provider takes too long to compute a code action during save, we skip that code action. However we do not cancel the request itself

With this change, we now cancel `getCodeActions` when the request times out
2019-01-22 15:05:07 -08:00
Matt Bierner 508f43166b Rename source.autoFix to source.fixAll
Part of #62110

`autoFix` is a confusing term since we have a `auto fix` command now. Using `fix all` as this term is used by many linters for this type of operation
2019-01-22 14:34:43 -08:00
Matt Bierner 73dfd92e65 Fix spelling 2019-01-22 14:34:43 -08:00
Matt Bierner c800831ffc Update js/ts grammar 2019-01-22 14:34:43 -08:00
Alex Dima 89721c99d7 Fixes #66944: Tokenize viewport with debouncing after scrolling and when the tokenization support has changed 2019-01-22 22:37:02 +01:00
Alex Dima 042e96cb08 Move tokenizeViewport call to the view model (#66944) 2019-01-22 22:12:46 +01:00
Alex Dima f6f255db3f Simplify TextModel.tokenizeViewport (#66944) 2019-01-22 22:11:57 +01:00
Alex Dima e68066faf0 Add possibility for error case 2019-01-22 20:35:59 +01:00
Alex Dima b2736fdc7c Capture console log and send it through the extension host protocol 2019-01-22 20:03:24 +01:00
Alex Dima c16d569a32 Add IInitData.resolvedExtensions 2019-01-22 20:01:56 +01:00
Alex Dima 7ed411c3c2 Improve error messages 2019-01-22 19:59:28 +01:00
Sandeep Somavarapu c5486fe763 #66907 Support non file workspaces
- File workspaces: Use node services until file service is acquired
- Non file workspaces:  Use cached workspace until file service is acquired
2019-01-22 19:06:16 +01:00
Daniel Imms a865e6691b Sanitize terminal environment variables 2019-01-22 07:47:00 -08:00
Greg Van Liew c7d9055b73 Merge pull request #66928 from Yash-Garg/patch-1
Update README.md
2019-01-22 07:36:08 -08:00
Yash Garg 35689d1261 Update README.md 2019-01-22 20:38:28 +05:30
Martin Aeschlimann ddd17d938f argv: fix null checks 2019-01-22 15:56:28 +01:00
Martin Aeschlimann 585099e139 support add/diffMode in windowService.openWindow 2019-01-22 15:56:28 +01:00
Martin Aeschlimann 998d665c39 cli server for internal terminal 2019-01-22 15:56:28 +01:00
Martin Aeschlimann 032f640ba7 support files in windowOpen 2019-01-22 15:56:28 +01:00
Martin Aeschlimann efc4d93818 make argv handling reusable 2019-01-22 15:56:28 +01:00
isidor 5d00c4b2ca fixes #66791 2019-01-22 15:52:12 +01:00
Martin Aeschlimann 6ecf349967 Make color/icon theme contribution points dynamic 2019-01-22 15:40:40 +01:00
isidor cf67606c1f open editors: drag to outside of vscode
fixes #66747
2019-01-22 15:35:57 +01:00
isidor 55951f06fa fixes #66810 2019-01-22 14:51:01 +01:00
isidor 93b0145d37 explorer: do not react on selection events if user is modifying selection via shift
fixes #66792
2019-01-22 11:58:56 +01:00
Sandeep Somavarapu b29504c5c2 #66907 Move cached configurations to user home directory 2019-01-22 11:00:28 +01:00
Johannes Rieken 23f534b7b7 fix tests 2019-01-21 21:07:57 -08:00
Johannes Rieken 9faa15ed6f fix strict null errors 2019-01-21 19:39:21 -08:00
Johannes Rieken 97ed8aba29 add developer command that prints available formatters to console, #41882 2019-01-21 18:19:02 -08:00
Matt Bierner 65b0d6d274 Fix spelling error 2019-01-21 18:04:01 -08:00
Matt Bierner f929531dfb Add CodeActionKind.intersects
Fixes #66881
2019-01-21 18:04:01 -08:00
Matt Bierner 86bb14550b Strict null check tokenization 2019-01-21 18:04:01 -08:00
Johannes Rieken e910e4e678 OpenerService#open should return a boolean 2019-01-21 17:39:26 -08:00
Johannes Rieken 1d4bed79e1 add some jsdoc #66741 2019-01-21 17:39:26 -08:00
Matt Bierner 73ba671e2b Merge pull request #66754 from piraces/suggestMemory
Add strict null checks to suggestMemory.test.ts
2019-01-21 17:20:08 -08:00
Matt Bierner d8375f6967 Merge pull request #66521 from Microsoft/dev/mjbvz/source-auto-fix-prototype
Prototype autoFix source code action
2019-01-21 17:18:08 -08:00
Matt Bierner c994fc20fa Apply auto fix on save actions sequentially and make sure we request fixes of the specific type we are interested in 2019-01-21 17:16:06 -08:00
Matt Bierner 2ebdac4afd Fix potential crash when using preferred code actions 2019-01-21 17:16:06 -08:00
Matt Bierner ee65a242a9 Gate auto fix for TS to use an undocumented experimental TS setting
We likely do not want to enable autofixes until we have proper TS support: https://github.com/Microsoft/TypeScript/issues/29452
2019-01-21 17:16:06 -08:00
Matt Bierner 4e6bd4aedd Prototype autofix source code action
Part of #62110

* Adds a new `CodeActionKind`: `source.autoFix`.
* Implements a simple auto fix provider for typescript. This provider can auto fix `implement interface` and `spelling` errors (provided there is only a single valid fix listed)

The provider is likely not something we actually want to check it (especially in its current state), we should ask TS for proper autoFix support
2019-01-21 17:16:06 -08:00
Matt Bierner 4f8d546aa7 De-duplicate "fix all" quick fixes across requests for multiple diagnostics in selection range
For https://github.com/Microsoft/typescript-tslint-plugin/issues/49
2019-01-21 17:15:49 -08:00
Johannes Rieken 232006c427 use electron openExternal, return boolean-promise, rename to 'open', #66741 2019-01-21 17:03:15 -08:00