Commit Graph

141 Commits

Author SHA1 Message Date
Oleg Solomko 1195e2cf77 fix the the the typos (#239646)
fix the `the the` -> `the` typos
2025-02-04 15:35:23 -08:00
Don Jayamanne 8cc255e03a Ensure execution_count is cleared when clearing outputs (#237301) 2025-01-05 19:58:34 -08:00
Don Jayamanne 008340a55c Ensure notebook execution count is cleared only when necessary (#234776) 2024-11-27 18:45:53 +01:00
Matt Bierner c83b443da0 Clean up support for paste edits (#234240)
- Allow setting an array of preferences for paste as keybindings
- Clarifies kinds used for core and extensions
- Exports text kind as API
2024-11-20 07:14:10 +01:00
Don Jayamanne 27d99fbee7 Set execution_count to null when clearning notebook outputs (#231806)
* Set execution_count to null when clearning notebook outputs

* Fix tests
2024-10-21 06:56:16 +02:00
Johannes e6f315d2fc eng - use esModuleInterop for extensions 2024-10-01 21:57:30 +02:00
Don Jayamanne 620fd6cb9a Support serialization of IPYNB in web worker (#230190) 2024-10-01 21:22:55 +10:00
Don Jayamanne c35d5e21fc Exclude cells and indentAmount from notebook metadta diff view (#230173) 2024-09-30 15:50:47 -07:00
Matt Bierner 51fa4d0172 Fix more type assertions (#230156)
* Fix more type assertions

For #211878

* Fix type error
2024-09-30 14:17:06 -07:00
Don Jayamanne c4645ea0ec Restore changes to ipynb extension to serialize notebook in node worker for desktop (#228319)
* Revert usage of node worker due to failing web compilation

* Revert "Revert usage of node worker due to failing web compilation"

This reverts commit 3190f58c7e.

* Ensure node worker is used only in desktop bundle of ipynb extension

---------

Co-authored-by: Aaron Munger <aamunger@microsoft.com>
2024-09-12 23:56:34 +02:00
Don Jayamanne 102ff8db3f Revert usage of node worker due to failing web compilation (#228318)
* Revert usage of node worker due to failing web compilation

* fix linter error
2024-09-12 17:44:02 +09:00
Don Jayamanne edd3903933 Updates 2024-09-10 01:19:53 +10:00
Don Jayamanne 692656799a Safer way to determine whether node or browser 2024-09-09 12:07:43 +10:00
Don Jayamanne 1865c2979d Import node worker 2024-09-09 11:48:21 +10:00
Don Jayamanne ddd0f1fe34 Updates to perform all operations in worker 2024-09-09 11:37:44 +10:00
nojaf cdc45ffb42 Include ending new line 2024-09-05 10:46:28 +02:00
nojaf 12abcccc81 Duplicate sortObjectPropertiesRecursively 2024-09-04 09:15:29 +02:00
nojaf e3caeae15d Verify that node worker is only used in node context. 2024-09-04 09:15:29 +02:00
nojaf c363defd73 Update worker file to esm 2024-09-04 09:15:29 +02:00
nojaf 366df5a69d Put worker behind setting 2024-09-04 09:15:29 +02:00
nojaf eb948e1ab7 Use Worker to serialize Notebook 2024-09-04 09:15:27 +02:00
Don Jayamanne 9b2e9634aa Remove code used to store metadata in custom property for notebooks (#227418)
* Remove code used to store metadata in custom property for notebooks

* oops
2024-09-03 09:24:35 +02:00
Don Jayamanne c0e1202c12 Stop adding a default cell in notebooks (#226692) 2024-09-02 08:20:26 +02:00
Don Jayamanne 2503ccd9d0 Support reverting Jupyter execution count via nb diff editor (#227157)
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2024-09-02 06:23:17 +02:00
Don Jayamanne 5809a68666 wip 2024-08-23 05:59:29 +10:00
Aaron Munger d7ade261f8 remove giant unused context key (#214504) 2024-06-12 08:34:29 -07:00
Don Jayamanne 804f8e3929 Debounce notebook cell metadata edit updates (#210005)
* Debounce notebook cell metadata edit updates

* Clear timer

* Check notebook type

* Try again

* Ignore IW notebooks

* oops
2024-04-11 07:44:14 +02:00
Don Jayamanne e079f1e07b Drop custom property from Jupyter Nb metadata (#210011) 2024-04-10 08:30:18 +02:00
Matt Bierner 8c363b460b Merge and cleanup drop and paste proposal (#209591)
These two proposals overlap a lot and will be finalized together
2024-04-05 13:03:10 -07:00
Don Jayamanne e3cf2530e6 Include execution count in jupyter notebook diff (#208292)
* Include execution count in notebook diff

* Fix tests

* Misc changes

* Fix tests

* Fix more tests
2024-03-21 14:14:33 +01:00
Don Jayamanne c0fa2a7b47 Expose prop to determine if custom prop is used (#208145) 2024-03-19 17:12:07 -07:00
Don Jayamanne 0f6d7c03fc Rename property to lineup with other exp props (#208121) 2024-03-19 20:31:31 +01:00
Don Jayamanne 55d6f3050d Drop custom metadata property from notebooks behind setting (#208065)
* Drop custom metadata property behind setting

* Do not update existing object
2024-03-19 19:37:59 +11:00
Don Jayamanne 1e95cb902e Keep notebook model in sync with the ipynb json (#208052) 2024-03-18 20:17:46 -07:00
Don Jayamanne 3242621276 Remove unwanted vscode property when not required (#208014) 2024-03-18 08:50:28 -07:00
Matt Bierner 9aecd9794a Cleaning up paste api proposal (#207495) 2024-03-12 21:11:05 +01:00
Don Jayamanne 7696df9026 Avoid blocking event loop when saving nb (#207381) 2024-03-12 08:18:20 +01:00
Don Jayamanne 9c3cc8b994 Avoid unnecessary workspace edits (#207377) 2024-03-12 02:03:43 +01:00
Matt Bierner 091987d943 Update paste and drop proposals (#206496)
* Update paste and drop proposals

Reworks the document paste and drop API proposals. Main highlights:

- Align more with code action api
- Allow a single paste provider to return multiple edits
- Allow resolving applied edits lazily
- Switch from using ids to scoped kinds like used for code actions

* Adding paste context

* Add context

* Update test
2024-03-07 16:04:36 -08:00
Don Jayamanne 46cd720f83 Drop uuid pkg used to to generate notebook cell id (#198647) 2023-11-20 06:12:55 +01:00
Don Jayamanne cb6c07d46d Use JSON output object for json mimetype (#197871) 2023-11-10 01:13:42 +01:00
Don Jayamanne 9c17df54bd Ensure orig_nbformat is not written to ipynb file (#192359) 2023-09-06 19:20:07 -07:00
Matt Bierner 8c7747252e Move drop/paste ids onto providers (#189961)
For #179430, #30066

This lets us call just the provider we are interested in
2023-08-08 14:44:03 -07:00
Matt Bierner 39df243d21 priority -> yieldTo for drop/paste API proposals (#189881)
Move await from `priority` for drop/paste API proposals

For #179430, #30066

Switching to use `yieldTo` instead of `priority` to let an extension de-rank itself in the list of edits. `priority` was an arbitrary number while `yieldTo` gives more control over how the ranking takes place
2023-08-07 18:32:03 -07:00
Peng Lyu bce3304e98 Fix vscode-jupyter#13522. Clear attachment if it does not exit. (#186578)
Fix #184630. Clear attachment if it does not exit.
2023-06-29 09:41:01 +10:00
aamunger 2c37a5be5a use same notebook serializer for IW 2023-06-16 11:52:40 -07:00
Michael Lively 34bde274c1 debt - remove field when no attachments present (#184630) 2023-06-09 00:18:46 +02:00
Matt Bierner bf7ca503c2 Fix drop priorities for notebooks (#182209)
For copy paste, I added logic to prefer using the text content if there's both `image/*` and `text/*` content in the clipboard

This however I also incorrectly applied this logic when dropping. In those cases, we instead want to prefer the image data (at least we do in the case of dragging and dropping from VS Code's explorer)
2023-05-11 13:03:28 -07:00
Matt Bierner 4d38422afe Add priority to paste / drop apis (#182109)
* Add priority to paste / drop apis

Fixes #181886

Replacement for #181453

* Make notebooks prefer text over creating attachments
2023-05-10 14:18:05 -07:00
Matt Bierner ca51a4b04c Add paste as command (#181959)
For #30066

This command shows a quick pick that lets you select how to paste content
2023-05-10 06:17:42 -07:00